unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Paul Eggert <eggert@cs.ucla.edu>
To: Lars Ingebrigtsen <larsi@gnus.org>, Eli Zaretskii <eliz@gnu.org>
Cc: michael.albinus@gmx.de, 42431@debbugs.gnu.org
Subject: bug#42431: 28.0.50; browse-url-of-dired-file confusing messaging
Date: Thu, 13 Oct 2022 01:51:00 -0700	[thread overview]
Message-ID: <e67a93f2-55c2-b7c5-8135-3b894b2109e6@cs.ucla.edu> (raw)
In-Reply-To: <87wn948ay1.fsf@gnus.org>

[-- Attachment #1: Type: text/plain, Size: 163 bytes --]

On 2022-10-13 00:00, Lars Ingebrigtsen wrote:

> I've now fixed this in Emacs 29.

Thanks, I simplified the fileio.c fix by installing the attached further 
patch.

[-- Attachment #2: 0001-Simplify-recent-File-exists-fix.patch --]
[-- Type: text/x-patch, Size: 882 bytes --]

From 97de273dca8d97039131f9d3f29b2820b5497805 Mon Sep 17 00:00:00 2001
From: Paul Eggert <eggert@cs.ucla.edu>
Date: Thu, 13 Oct 2022 01:48:10 -0700
Subject: [PATCH] Simplify recent "File exists" fix

* src/fileio.c (Finsert_file_contents):
Simplify previous change that fixed bug#42431.
---
 src/fileio.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/fileio.c b/src/fileio.c
index a238889803..49553f3c91 100644
--- a/src/fileio.c
+++ b/src/fileio.c
@@ -5000,7 +5000,7 @@ because (1) it preserves some marker positions (in unchanged portions
       unbind_to (count1, Qnil);
     }
 
-  if (NILP (handler) && !NILP (visit) && current_buffer->modtime.tv_nsec < 0)
+  if (save_errno != 0)
     {
       /* Signal an error if visiting a file that could not be opened.  */
       report_file_errno ("Opening input file", orig_filename, save_errno);
-- 
2.34.1


  reply	other threads:[~2022-10-13  8:51 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-19 19:34 bug#42431: 28.0.50; browse-url-of-dired-file confusing messaging Lars Ingebrigtsen
2020-07-19 19:37 ` Lars Ingebrigtsen
2020-07-27 22:24 ` Lars Ingebrigtsen
2020-08-08  7:46   ` Eli Zaretskii
2020-08-08 10:05     ` Lars Ingebrigtsen
2020-08-08 10:22       ` Eli Zaretskii
2020-08-09  9:35         ` Lars Ingebrigtsen
2020-08-09  9:45           ` Lars Ingebrigtsen
2020-08-09 14:05             ` Eli Zaretskii
2020-08-09 14:08               ` Lars Ingebrigtsen
2022-10-13  7:00             ` Lars Ingebrigtsen
2022-10-13  8:51               ` Paul Eggert [this message]
2022-10-13 10:35                 ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e67a93f2-55c2-b7c5-8135-3b894b2109e6@cs.ucla.edu \
    --to=eggert@cs.ucla.edu \
    --cc=42431@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    --cc=larsi@gnus.org \
    --cc=michael.albinus@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).