unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Lars Ingebrigtsen <larsi@gnus.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: michael.albinus@gmx.de, 42431@debbugs.gnu.org
Subject: bug#42431: 28.0.50; browse-url-of-dired-file confusing messaging
Date: Sat, 08 Aug 2020 12:05:04 +0200	[thread overview]
Message-ID: <87a6z55u7j.fsf@gnus.org> (raw)
In-Reply-To: <83eeoh7f68.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 08 Aug 2020 10:46:55 +0300")

Eli Zaretskii <eliz@gnu.org> writes:

>> (defun find-file-noselect-1 (buf filename nowarn rawfile truename number)
>> 
>> [...]
>> 
>> 	  (condition-case ()
>> 	      (let ((inhibit-read-only t))
>> 		(insert-file-contents-literally filename t))
>> 	    (file-error
>> 	     (when (and (file-exists-p filename)
>> 			(not (file-readable-p filename)))
>> 	       (kill-buffer buf)
>> 	       (signal 'file-error (list "File is not readable"
>> 					 filename)))
>
> Is this because file-readable-p returns nil for file:// URLs?

That's the direct cause of the message, but the underlying reason is
that insert-file-contents-literally signalled a file-error here (after
inserting the contents).  I haven't yet chased down why.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no





  reply	other threads:[~2020-08-08 10:05 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-19 19:34 bug#42431: 28.0.50; browse-url-of-dired-file confusing messaging Lars Ingebrigtsen
2020-07-19 19:37 ` Lars Ingebrigtsen
2020-07-27 22:24 ` Lars Ingebrigtsen
2020-08-08  7:46   ` Eli Zaretskii
2020-08-08 10:05     ` Lars Ingebrigtsen [this message]
2020-08-08 10:22       ` Eli Zaretskii
2020-08-09  9:35         ` Lars Ingebrigtsen
2020-08-09  9:45           ` Lars Ingebrigtsen
2020-08-09 14:05             ` Eli Zaretskii
2020-08-09 14:08               ` Lars Ingebrigtsen
2022-10-13  7:00             ` Lars Ingebrigtsen
2022-10-13  8:51               ` Paul Eggert
2022-10-13 10:35                 ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87a6z55u7j.fsf@gnus.org \
    --to=larsi@gnus.org \
    --cc=42431@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    --cc=michael.albinus@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).