bug#2356: 23.0.90; customize-group of flymake signals error

bug#2356: 23.0.90; customize-group of flymake signals error

[Bruce Stephens]

After emacs-snapshot -Q, M-x customize-group flymake signals an error
widget-apply: Wrong type argument: char-or-string-p, nil

In GNU Emacs 23.0.90.1 (i486-pc-linux-gnu, GTK+ Version 2.12.11)
 of 2009-02-17 on tiny.isode.net, modified by Debian
 (emacs-snapshot package, version 1:20090207-1)
Windowing system distributor `The X.Org Foundation', version 11.0.10402000
configured using `configure  '--build' 'i486-linux-gnu' '--host' 'i486-linux-gnu' '--prefix=/usr' '--sharedstatedir=/var/lib' '--libexecdir=/usr/lib' '--localstatedir=/var' '--infodir=/usr/share/info' '--mandir=/usr/share/man' '--with-pop=yes' '--enable-locallisppath=/etc/emacs-snapshot:/etc/emacs:/usr/local/share/emacs/23.0.90/site-lisp:/usr/local/share/emacs/site-lisp:/usr/share/emacs/23.0.90/site-lisp:/usr/share/emacs/site-lisp' '--with-x=yes' '--with-x-toolkit=gtk' 'build_alias=i486-linux-gnu' 'host_alias=i486-linux-gnu' 'CFLAGS=-DDEBIAN -DSITELOAD_PURESIZE_EXTRA=5000 -g -O2' 'LDFLAGS=-g -Wl,--as-needed' 'CPPFLAGS=''

Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: en_GB.UTF-8
  value of $XMODIFIERS: nil
  locale-coding-system: utf-8-unix
  default-enable-multibyte-characters: t

Major mode: Custom

Minor modes in effect:
  tooltip-mode: t
  tool-bar-mode: t
  mouse-wheel-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  global-auto-composition-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  line-number-mode: t
  transient-mark-mode: t

Recent input:
M-x c u s t o m i z e - g r o u p <tab> <return> f 
l y m a k e <return> M-x r e p o r t <tab> <return
>

Recent messages:
For information about GNU Emacs and the GNU system, type C-h C-a.
Creating customization items...
widget-apply: Wrong type argument: char-or-string-p, nil

bug#2356: 23.0.90; customize-group of flymake signals error

[martin rudalics]

 > After emacs-snapshot -Q, M-x customize-group flymake signals an error
 > widget-apply: Wrong type argument: char-or-string-p, nil
 >
 > In GNU Emacs 23.0.90.1 (i486-pc-linux-gnu, GTK+ Version 2.12.11)
 >  of 2009-02-17 on tiny.isode.net, modified by Debian
 >  (emacs-snapshot package, version 1:20090207-1)
 > Windowing system distributor `The X.Org Foundation', version 11.0.10402000
 > configured using `configure  '--build' 'i486-linux-gnu' '--host' 'i486-linux-gnu' '--prefix=/usr' '--sharedstatedir=/var/lib' '--libexecdir=/usr/lib' '--localstatedir=/var' '--infodir=/usr/share/info' '--mandir=/usr/share/man' '--with-pop=yes' '--enable-locallisppath=/etc/emacs-snapshot:/etc/emacs:/usr/local/share/emacs/23.0.90/site-lisp:/usr/local/share/emacs/site-lisp:/usr/share/emacs/23.0.90/site-lisp:/usr/share/emacs/site-lisp' '--with-x=yes' '--with-x-toolkit=gtk' 'build_alias=i486-linux-gnu' 'host_alias=i486-linux-gnu' 'CFLAGS=-DDEBIAN -DSITELOAD_PURESIZE_EXTRA=5000 -g -O2' 'LDFLAGS=-g -Wl,--as-needed' 'CPPFLAGS=''

IIUC, there's simply no customization group called `flymake'.

So adding something like

(defgroup flymake nil
   "Flymake."
   :version "23.1"
   :group 'tools)

to flymake.el should fix this.

martin

bug#2356: 23.0.90; customize-group of flymake signals error

[Stefan Monnier]

>> After emacs-snapshot -Q, M-x customize-group flymake signals an error
>> widget-apply: Wrong type argument: char-or-string-p, nil

> IIUC, there's simply no customization group called `flymake'.

I think there are two bugs:
1- the `flymake' group is missing: plase install your suggested patch, Martin.
2- customize-group should signals the error in a cleaner way
   (especially since it happily completed the word "flymake").


        Stefan

bug#2356: 23.0.90; customize-group of flymake signals error

[martin rudalics]

 > 1- the `flymake' group is missing: plase install your suggested patch, Martin.

Done.

 > 2- customize-group should signals the error in a cleaner way
 >    (especially since it happily completed the word "flymake").

It "completes" because apparently `custom-make-dependencies', when
reading defcustoms from flymake.el, concludes that `flymake' is a valid
customization group and adds a

(put 'flymake 'custom-loads '(flymake))

to cus-load.el.

I now don't raise an error any more.  If you think some signalling is
needed, please tell me what kind of message you want and what its text
should be.

martin

bug#2356: 23.0.90; customize-group of flymake signals error

[Stefan Monnier]

> I now don't raise an error any more.  If you think some signalling is
> needed, please tell me what kind of message you want and what its text
> should be.

It should signal an error like "can't find the group's definition".
Or maybe it can even be made to work (after all the `defgroup' usually
only provides non-vital info such as parent groups and a docstring).


        Stefan

bug#2356: 23.0.90; customize-group of flymake signals error

[martin rudalics]

 > Or maybe it can even be made to work (after all the `defgroup' usually
 > only provides non-vital info such as parent groups and a docstring).

Indeed that's what I've tried to do.

martin.

bug#2356: 23.0.90; customize-group of flymake signals error

[Stefan Monnier]

>> Or maybe it can even be made to work (after all the `defgroup' usually
>> only provides non-vital info such as parent groups and a docstring).

> Indeed that's what I've tried to do.

That's good.  It could just replace the groups' docstring with a message
along the lines of "can't find the group's definition".


        Stefan

bug#2356: 23.0.90; customize-group of flymake signals error

[Lennart Borgman]

On Wed, Feb 18, 2009 at 5:59 PM, Stefan Monnier
<monnier@iro.umontreal.ca> wrote:
>>> Or maybe it can even be made to work (after all the `defgroup' usually
>>> only provides non-vital info such as parent groups and a docstring).
>
>> Indeed that's what I've tried to do.
>
> That's good.  It could just replace the groups' docstring with a message
> along the lines of "can't find the group's definition".

Maybe "group ... does not seem to be defined"?

bug#2356: marked as done (23.0.90; customize-group of flymake signals error)

[Emacs bug Tracking System]

[-- Attachment #1: Type: text/plain, Size: 891 bytes --]


Your message dated Wed, 18 Feb 2009 19:39:43 +0100
with message-id <499C55EF.8050209@gmx.at>
and subject line Re: bug#2356: 23.0.90; customize-group of flymake signals error
has caused the Emacs bug report #2356,
regarding 23.0.90; customize-group of flymake signals error
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@emacsbugs.donarmstrong.com
immediately.)


-- 
2356: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=2356
Emacs Bug Tracking System
Contact owner@emacsbugs.donarmstrong.com with problems

[-- Attachment #2: Type: message/rfc822, Size: 4280 bytes --]

From: Bruce Stephens <bruce.stephens@isode.com>
To: emacs-pretest-bug@gnu.org
Cc: rfrancoise@debian.org
Subject: 23.0.90; customize-group of flymake signals error
Date: Tue, 17 Feb 2009 12:20:53 +0000
Message-ID: <80y6w5ntju.fsf@tiny.isode.net>

After emacs-snapshot -Q, M-x customize-group flymake signals an error
widget-apply: Wrong type argument: char-or-string-p, nil

In GNU Emacs 23.0.90.1 (i486-pc-linux-gnu, GTK+ Version 2.12.11)
 of 2009-02-17 on tiny.isode.net, modified by Debian
 (emacs-snapshot package, version 1:20090207-1)
Windowing system distributor `The X.Org Foundation', version 11.0.10402000
configured using `configure  '--build' 'i486-linux-gnu' '--host' 'i486-linux-gnu' '--prefix=/usr' '--sharedstatedir=/var/lib' '--libexecdir=/usr/lib' '--localstatedir=/var' '--infodir=/usr/share/info' '--mandir=/usr/share/man' '--with-pop=yes' '--enable-locallisppath=/etc/emacs-snapshot:/etc/emacs:/usr/local/share/emacs/23.0.90/site-lisp:/usr/local/share/emacs/site-lisp:/usr/share/emacs/23.0.90/site-lisp:/usr/share/emacs/site-lisp' '--with-x=yes' '--with-x-toolkit=gtk' 'build_alias=i486-linux-gnu' 'host_alias=i486-linux-gnu' 'CFLAGS=-DDEBIAN -DSITELOAD_PURESIZE_EXTRA=5000 -g -O2' 'LDFLAGS=-g -Wl,--as-needed' 'CPPFLAGS=''

Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: en_GB.UTF-8
  value of $XMODIFIERS: nil
  locale-coding-system: utf-8-unix
  default-enable-multibyte-characters: t

Major mode: Custom

Minor modes in effect:
  tooltip-mode: t
  tool-bar-mode: t
  mouse-wheel-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  global-auto-composition-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  line-number-mode: t
  transient-mark-mode: t

Recent input:
M-x c u s t o m i z e - g r o u p <tab> <return> f 
l y m a k e <return> M-x r e p o r t <tab> <return
>

Recent messages:
For information about GNU Emacs and the GNU system, type C-h C-a.
Creating customization items...
widget-apply: Wrong type argument: char-or-string-p, nil



[-- Attachment #3: Type: message/rfc822, Size: 2166 bytes --]

From: martin rudalics <rudalics@gmx.at>
To: 2356-done@emacsbugs.donarmstrong.com
Cc: Stefan Monnier <monnier@iro.umontreal.ca>, Bruce Stephens <bruce.stephens@isode.com>, rfrancoise@debian.org
Subject: Re: bug#2356: 23.0.90; customize-group of flymake signals error
Date: Wed, 18 Feb 2009 19:39:43 +0100
Message-ID: <499C55EF.8050209@gmx.at>

Fixed as

	* cus-edit.el (custom-group-value-create): Insert some
	informatory text in the WIDGET-misses-doc-string case.

	* cus-edit.el (custom-group-value-create): Don't throw an error
	when WIDGET has no doc-string.  (Bug#2356)

	* progmodes/flymake.el (flymake): Add defgroup.  (Bug#2356)

Thanks for reporting, martin.