bug#21340: 24.5; trash-directory uses FreeDesktop location on OSX

bug#21340: 24.5; trash-directory uses FreeDesktop location on OSX

[Harvey Chapman]

I set "(setq delete-by-moving-to-trash t)", and emacs moved
deleted files to ~/.local/share/Trash, the FreeDesktop location.
The files should have been moved to ~/.Trash, the standard OSX
location. I was deleting files in my home directory using dired.

Work around: (setq trash-directory "~/.Trash")

I get emacs from http://emacsformacosx.com/



In GNU Emacs 24.5.1 (x86_64-apple-darwin13.4.0, NS apple-appkit-1265.21)
of 2015-04-10 on builder10-9.porkrind.org
Windowing system distributor `Apple', version 10.3.1348
Configured using:
`configure --with-ns '--enable-locallisppath=/Library/Application
Support/Emacs/${version}/site-lisp:/Library/Application
Support/Emacs/site-lisp''

Important settings:
  locale-coding-system: utf-8-unix

Major mode: Emacs-Lisp

Minor modes in effect:
  subword-mode: t
  show-paren-mode: t
  savehist-mode: t
  which-function-mode: t
  desktop-save-mode: t
  override-global-mode: t
  tooltip-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  buffer-read-only: t
  column-number-mode: t
  line-number-mode: t
  transient-mark-mode: t

Recent messages:
Loading sh-script...done
Setting up indent for shell type sh
Indentation variables are now local.
Indentation setup for shell type sh
Loading ruby-mode...done
Wrote /Users/hchapman/.emacs.d/desktop/.emacs.desktop.lock
Desktop: 18 buffers restored.
For information about GNU Emacs and the GNU system, type C-h C-a.
Trashing...done
Making completion list...

Load-path shadows:
~/.emacs.d/lisp/go-mode.el/go-mode hides ~/.emacs.d/lisp/go-mode
~/.emacs.d/lisp/expand-region hides /Users/hchapman/.emacs.d/elpa/expand-region-20150525.205/expand-region
~/.emacs.d/lisp/helm/helm hides /Users/hchapman/.emacs.d/elpa/helm-20150622.857/helm
~/.emacs.d/lisp/helm/helm-utils hides /Users/hchapman/.emacs.d/elpa/helm-20150622.857/helm-utils
~/.emacs.d/lisp/helm/helm-tags hides /Users/hchapman/.emacs.d/elpa/helm-20150622.857/helm-tags
~/.emacs.d/lisp/helm/helm-sys hides /Users/hchapman/.emacs.d/elpa/helm-20150622.857/helm-sys
~/.emacs.d/lisp/helm/helm-source hides /Users/hchapman/.emacs.d/elpa/helm-20150622.857/helm-source
~/.emacs.d/lisp/helm/helm-semantic hides /Users/hchapman/.emacs.d/elpa/helm-20150622.857/helm-semantic
~/.emacs.d/lisp/helm/helm-ring hides /Users/hchapman/.emacs.d/elpa/helm-20150622.857/helm-ring
~/.emacs.d/lisp/helm/helm-regexp hides /Users/hchapman/.emacs.d/elpa/helm-20150622.857/helm-regexp
~/.emacs.d/lisp/helm/helm-plugin hides /Users/hchapman/.emacs.d/elpa/helm-20150622.857/helm-plugin
~/.emacs.d/lisp/helm/helm-pkg hides /Users/hchapman/.emacs.d/elpa/helm-20150622.857/helm-pkg
~/.emacs.d/lisp/helm/helm-org hides /Users/hchapman/.emacs.d/elpa/helm-20150622.857/helm-org
~/.emacs.d/lisp/helm/helm-net hides /Users/hchapman/.emacs.d/elpa/helm-20150622.857/helm-net
~/.emacs.d/lisp/helm/helm-mode hides /Users/hchapman/.emacs.d/elpa/helm-20150622.857/helm-mode
~/.emacs.d/lisp/helm/helm-misc hides /Users/hchapman/.emacs.d/elpa/helm-20150622.857/helm-misc
~/.emacs.d/lisp/helm/helm-match-plugin hides /Users/hchapman/.emacs.d/elpa/helm-20150622.857/helm-match-plugin
~/.emacs.d/lisp/helm/helm-man hides /Users/hchapman/.emacs.d/elpa/helm-20150622.857/helm-man
~/.emacs.d/lisp/helm/helm-locate hides /Users/hchapman/.emacs.d/elpa/helm-20150622.857/helm-locate
~/.emacs.d/lisp/helm/helm-info hides /Users/hchapman/.emacs.d/elpa/helm-20150622.857/helm-info
~/.emacs.d/lisp/helm/helm-imenu hides /Users/hchapman/.emacs.d/elpa/helm-20150622.857/helm-imenu
~/.emacs.d/lisp/helm/helm-help hides /Users/hchapman/.emacs.d/elpa/helm-20150622.857/helm-help
~/.emacs.d/lisp/helm/helm-grep hides /Users/hchapman/.emacs.d/elpa/helm-20150622.857/helm-grep
~/.emacs.d/lisp/helm/helm-font hides /Users/hchapman/.emacs.d/elpa/helm-20150622.857/helm-font
~/.emacs.d/lisp/helm/helm-files hides /Users/hchapman/.emacs.d/elpa/helm-20150622.857/helm-files
~/.emacs.d/lisp/helm/helm-external hides /Users/hchapman/.emacs.d/elpa/helm-20150622.857/helm-external
~/.emacs.d/lisp/helm/helm-eval hides /Users/hchapman/.emacs.d/elpa/helm-20150622.857/helm-eval
~/.emacs.d/lisp/helm/helm-eshell hides /Users/hchapman/.emacs.d/elpa/helm-20150622.857/helm-eshell
~/.emacs.d/lisp/helm/helm-elscreen hides /Users/hchapman/.emacs.d/elpa/helm-20150622.857/helm-elscreen
~/.emacs.d/lisp/helm/helm-elisp hides /Users/hchapman/.emacs.d/elpa/helm-20150622.857/helm-elisp
~/.emacs.d/lisp/helm/helm-elisp-package hides /Users/hchapman/.emacs.d/elpa/helm-20150622.857/helm-elisp-package
~/.emacs.d/lisp/helm/helm-dabbrev hides /Users/hchapman/.emacs.d/elpa/helm-20150622.857/helm-dabbrev
~/.emacs.d/lisp/helm/helm-config hides /Users/hchapman/.emacs.d/elpa/helm-20150622.857/helm-config
~/.emacs.d/lisp/helm/helm-command hides /Users/hchapman/.emacs.d/elpa/helm-20150622.857/helm-command
~/.emacs.d/lisp/helm/helm-color hides /Users/hchapman/.emacs.d/elpa/helm-20150622.857/helm-color
~/.emacs.d/lisp/helm/helm-buffers hides /Users/hchapman/.emacs.d/elpa/helm-20150622.857/helm-buffers
~/.emacs.d/lisp/helm/helm-bookmark hides /Users/hchapman/.emacs.d/elpa/helm-20150622.857/helm-bookmark
~/.emacs.d/lisp/helm/helm-autoloads hides /Users/hchapman/.emacs.d/elpa/helm-20150622.857/helm-autoloads
~/.emacs.d/lisp/helm/helm-apt hides /Users/hchapman/.emacs.d/elpa/helm-20150622.857/helm-apt
~/.emacs.d/lisp/helm/helm-aliases hides /Users/hchapman/.emacs.d/elpa/helm-20150622.857/helm-aliases
~/.emacs.d/lisp/helm/helm-adaptive hides /Users/hchapman/.emacs.d/elpa/helm-20150622.857/helm-adaptive
~/.emacs.d/lisp/desktop hides /Users/hchapman/Applications/Emacs.app/Contents/Resources/lisp/desktop

Features:
(shadow sort mail-extr emacsbug message rfc822 mml mml-sec mm-decode
mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader
sendmail rfc2047 rfc2045 ietf-drums mail-utils help-mode ruby-mode
sh-script smie executable conf-mode vc-git cc-langs cc-mode cc-fonts
cc-guess cc-menus cc-cmds cc-styles cc-align cc-engine cc-vars cc-defs
dired vc-hg superword subword advice markdown-mode noutline outline
go-mode derived find-file ffap thingatpt etags metar url url-proxy
url-privacy url-expand url-methods url-history url-cookie url-domsuf
url-util url-parse auth-source eieio byte-opt eieio-core gnus-util
mm-util mail-prsvr password-cache url-vars mailcap solar cal-dst
cal-menu calendar cal-loaddefs rx format-spec calc-units calc-ext calc
calc-loaddefs calc-macs paren savehist cus-start cus-load which-func
imenu xcscope ring easymenu desktop comint-scroll-to-bottom undo-tree
help-fns diff edmacro kmacro server use-package cl-macs cl gv diminish
bytecomp byte-compile cl-extra cconv bind-key easy-mmode cl-loaddefs
cl-lib package epg-config time-date tooltip electric uniquify ediff-hook
vc-hooks lisp-float-type mwheel ns-win tool-bar dnd fontset image
regexp-opt fringe tabulated-list newcomment lisp-mode prog-mode register
page menu-bar rfn-eshadow timer select scroll-bar mouse jit-lock
font-lock syntax facemenu font-core frame cham georgian utf-8-lang
misc-lang vietnamese tibetan thai tai-viet lao korean japanese hebrew
greek romanian slovak czech european ethiopic indian cyrillic chinese
case-table epa-hook jka-cmpr-hook help simple abbrev minibuffer nadvice
loaddefs button faces cus-face macroexp files text-properties overlay
sha1 md5 base64 format env code-pages mule custom widget
hashtable-print-readable backquote make-network-process cocoa ns
multi-tty emacs)

Memory information:
((conses 16 271724 10178)
(symbols 48 33317 0)
(miscs 40 440 257)
(strings 32 58404 7719)
(string-bytes 1 1639691)
(vectors 16 22480)
(vector-slots 8 536265 7901)
(floats 8 439 229)
(intervals 56 1291 0)
(buffers 960 30))

bug#21340: 24.5; trash-directory uses FreeDesktop location on OSX

[Eli Zaretskii]

> From: Harvey Chapman <hchapman@3gfp.com>
> Date: Mon, 24 Aug 2015 12:55:19 -0400
> 
> I set "(setq delete-by-moving-to-trash t)", and emacs moved
> deleted files to ~/.local/share/Trash, the FreeDesktop location.

As expected.

> The files should have been moved to ~/.Trash, the standard OSX
> location. I was deleting files in my home directory using dired.
> 
> Work around: (setq trash-directory "~/.Trash")

You need to customize that variable to point to the directory where
you want your trash.  The doc string says:

    Directory for `move-file-to-trash' to move files and directories to.
  This directory is only used when the function `system-move-file-to-trash'
  is not defined.
  Relative paths are interpreted relative to `default-directory'.
  If the value is nil, Emacs uses a freedesktop.org-style trashcan.
  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

The default is nil, so what you see is Emacs functioning as designed.

bug#21340: 24.5; trash-directory uses FreeDesktop location on OSX

[Harvey Chapman]

> On Aug 24, 2015, at 1:32 PM, Eli Zaretskii <eliz@gnu.org> wrote:
> 
>> From: Harvey Chapman <hchapman@3gfp.com>
>> Date: Mon, 24 Aug 2015 12:55:19 -0400
>> 
>> I set "(setq delete-by-moving-to-trash t)", and emacs moved
>> deleted files to ~/.local/share/Trash, the FreeDesktop location.
> 
> As expected.
> 
>> The files should have been moved to ~/.Trash, the standard OSX
>> location. I was deleting files in my home directory using dired.
>> 
>> Work around: (setq trash-directory "~/.Trash")
> 
> You need to customize that variable to point to the directory where
> you want your trash.  The doc string says:
> 
>    Directory for `move-file-to-trash' to move files and directories to.
>  This directory is only used when the function `system-move-file-to-trash'
>  is not defined.
>  Relative paths are interpreted relative to `default-directory'.
>  If the value is nil, Emacs uses a freedesktop.org-style trashcan.
>  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> 
> The default is nil, so what you see is Emacs functioning as designed.

I guess I considered it a bug, because `system-move-file-to-trash` is
used by Emacs for Windows to put files in the correct location. If Emacs
can cater to Windows, surely it can cater to another very largely used
OS? Emacs putting files in ~/.local on OSX just makes it appear that it
doesn’t know what it is doing.

Thank you all the same.

bug#21340: 24.5; trash-directory uses FreeDesktop location on OSX

[Eli Zaretskii]

> From: Harvey Chapman <hchapman@3gfp.com>
> Date: Mon, 24 Aug 2015 13:49:33 -0400
> Cc: 21340@debbugs.gnu.org
> 
> >  If the value is nil, Emacs uses a freedesktop.org-style trashcan.
> >  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> > 
> > The default is nil, so what you see is Emacs functioning as designed.
> 
> I guess I considered it a bug, because `system-move-file-to-trash` is
> used by Emacs for Windows to put files in the correct location. If Emacs
> can cater to Windows, surely it can cater to another very largely used
> OS?

It doesn't cater to Windows, it caters to any platform that has a
'system-move-file-to-trash' primitive (which is supposed to know the
location of trash internally), and Windows just happens to have it.
When such a primitive is not available, Emacs moves the file using the
"normal" file I/O, and then it has to know where to move it.

bug#21340: 24.5; trash-directory uses FreeDesktop location on OSX

[Glenn Morris]

I don't use OS X, but it sounds to like it would be better to change the
default value of trash-directory to

(if (eq system-type 'darwin) "~/.Trash/")

bug#21340: 24.5; trash-directory uses FreeDesktop location on OSX

[Stefan Monnier]

> I don't use OS X, but it sounds to like it would be better to change the
> default value of trash-directory to
> (if (eq system-type 'darwin) "~/.Trash/")

Or to define a system-move-file-to-trash, which defers to the
(presumably existing) system function that does that for us.


        Stefan

bug#21340: 24.5; trash-directory uses FreeDesktop location on OSX

[Lars Ingebrigtsen]

Stefan Monnier <monnier@iro.umontreal.ca> writes:

> Or to define a system-move-file-to-trash, which defers to the
> (presumably existing) system function that does that for us.

Alan, do you know whether this would make sense on Macos?

If not, then I think Glenn's suggestion here makes sense, i.e., add:

(if (eq system-type 'darwin) "~/.Trash/")

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#21340: 24.5; trash-directory uses FreeDesktop location on OSX

[Alan Third]

On Thu, Dec 02, 2021 at 10:31:27AM +0100, Lars Ingebrigtsen wrote:
> Stefan Monnier <monnier@iro.umontreal.ca> writes:
> 
> > Or to define a system-move-file-to-trash, which defers to the
> > (presumably existing) system function that does that for us.
> 
> Alan, do you know whether this would make sense on Macos?
> 
> If not, then I think Glenn's suggestion here makes sense, i.e., add:
> 
> (if (eq system-type 'darwin) "~/.Trash/")

It looks like there's a method available to trash items on macOS 10.8
and above, so I suppose that's the logical thing to use.

https://developer.apple.com/documentation/foundation/nsfilemanager/1414306-trashitematurl?language=objc

macOS < 10.8 uses some Carbon API, which I'd rather not bother with,
and GNUstep doesn't support it at all, so I imagine it's as well using
the XDG location or whatever the default is.
-- 
Alan Third

bug#21340: 24.5; trash-directory uses FreeDesktop location on OSX

[Lars Ingebrigtsen]

Alan Third <alan@idiocy.org> writes:

> It looks like there's a method available to trash items on macOS 10.8
> and above, so I suppose that's the logical thing to use.
>
> https://developer.apple.com/documentation/foundation/nsfilemanager/1414306-trashitematurl?language=objc
>
> macOS < 10.8 uses some Carbon API, which I'd rather not bother with,
> and GNUstep doesn't support it at all, so I imagine it's as well using
> the XDG location or whatever the default is.

Sounds good to me.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#21340: 24.5; trash-directory uses FreeDesktop location on OSX

[Alan Third]

[-- Attachment #1: Type: text/plain, Size: 720 bytes --]

On Fri, Dec 03, 2021 at 05:16:20PM +0100, Lars Ingebrigtsen wrote:
> Alan Third <alan@idiocy.org> writes:
> 
> > It looks like there's a method available to trash items on macOS 10.8
> > and above, so I suppose that's the logical thing to use.
> >
> > https://developer.apple.com/documentation/foundation/nsfilemanager/1414306-trashitematurl?language=objc
> >
> > macOS < 10.8 uses some Carbon API, which I'd rather not bother with,
> > and GNUstep doesn't support it at all, so I imagine it's as well using
> > the XDG location or whatever the default is.
> 
> Sounds good to me.

Well, I've written a patch but the function doesn't appear in lisp and
I don't know what I've done wrong.

Patch attached.
-- 
Alan Third

[-- Attachment #2: 0001-Make-use-of-Trash-on-macOS-bug-21340.patch --]
[-- Type: text/x-diff, Size: 2338 bytes --]

From 4f21ff07ad9b9d06960a9ea6d000e0636f49c3d1 Mon Sep 17 00:00:00 2001
From: Alan Third <alan@idiocy.org>
Date: Fri, 3 Dec 2021 22:17:45 +0000
Subject: [PATCH] Make use of Trash on macOS (bug#21340)

* src/nsfns.m (Fsystem_move_file_to_trash): New function.
---
 src/nsfns.m | 41 +++++++++++++++++++++++++++++++++++++++++
 1 file changed, 41 insertions(+)

diff --git a/src/nsfns.m b/src/nsfns.m
index c2791aa15a..5e319e1915 100644
--- a/src/nsfns.m
+++ b/src/nsfns.m
@@ -2362,6 +2362,47 @@ Frames are listed from topmost (first) to bottommost (last).  */)
    ========================================================================== */
 
 
+#if defined (NS_IMPL_COCOA) && MAC_OS_X_VERSION_MAX_ALLOWED >= 1080
+/* Moving files to the system recycle bin.
+   Used by `move-file-to-trash' instead of the default moving to ~/.Trash  */
+DEFUN ("system-move-file-to-trash", Fsystem_move_file_to_trash,
+       Ssystem_move_file_to_trash, 1, 1, 0,
+       doc: /* Move file or directory named FILENAME to the recycle bin.  */)
+  (Lisp_Object filename)
+{
+  Lisp_Object handler;
+  Lisp_Object operation;
+
+  operation = Qdelete_file;
+  if (!NILP (Ffile_directory_p (filename))
+      && NILP (Ffile_symlink_p (filename)))
+    {
+      operation = intern ("delete-directory");
+      filename = Fdirectory_file_name (filename);
+    }
+
+  /* Must have fully qualified file names for moving files to Trash. */
+  filename = Fexpand_file_name (filename, Qnil);
+
+  handler = Ffind_file_name_handler (filename, operation);
+  if (!NILP (handler))
+    return call2 (handler, operation, filename);
+  else
+    {
+      NSFileManager *fm = [NSFileManager defaultManager];
+      BOOL result = NO;
+      NSURL *fileURL = [NSURL fileURLWithPath:[NSString stringWithLispString:filename]
+                                  isDirectory:!NILP (Ffile_directory_p (filename))];
+      if ([fm respondsToSelector:@selector(trashItemAtURL:resultingItemURL:error:)])
+        result = [fm trashItemAtURL:fileURL resultingItemURL:nil error:nil];
+
+      if (!result)
+	report_file_error ("Removing old name", list1 (filename));
+    }
+  return Qnil;
+}
+#endif
+
 DEFUN ("xw-color-defined-p", Fxw_color_defined_p, Sxw_color_defined_p, 1, 2, 0,
        doc: /* SKIP: real doc in xfns.c.  */)
      (Lisp_Object color, Lisp_Object frame)
-- 
2.33.0

bug#21340: 24.5; trash-directory uses FreeDesktop location on OSX

[Lars Ingebrigtsen]

Alan Third <alan@idiocy.org> writes:

> Well, I've written a patch but the function doesn't appear in lisp and
> I don't know what I've done wrong.

I think you're just missing the defsubr for the symbol:

  defsubr (&Ssystem_move_file_to_trash);


-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#21340: 24.5; trash-directory uses FreeDesktop location on OSX

[Alan Third]

On Sat, Dec 04, 2021 at 12:11:04AM +0100, Lars Ingebrigtsen wrote:
> Alan Third <alan@idiocy.org> writes:
> 
> > Well, I've written a patch but the function doesn't appear in lisp and
> > I don't know what I've done wrong.
> 
> I think you're just missing the defsubr for the symbol:
> 
>   defsubr (&Ssystem_move_file_to_trash);

That was it, thank you!

I've pushed this change to master.
-- 
Alan Third