unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Peter Oliver <p.d.oliver@mavit.org.uk>
To: 49504@debbugs.gnu.org
Subject: bug#49504: Acknowledgement (Server support for Freedesktop.org startup notification)
Date: Sat, 10 Jul 2021 13:41:56 +0100 (BST)	[thread overview]
Message-ID: <d0e8ff43-2b7b-1751-a4aa-204253762741@froglet.home.mavit.org.uk> (raw)
In-Reply-To: <handler.49504.B.16259174312311.ack@debbugs.gnu.org>

[-- Attachment #1: Type: text/plain, Size: 125 bytes --]

In the meantime, here’s a patch which unadvertises startup notification support from emacsclient.desktop.

-- 
Peter Oliver

[-- Attachment #2: Type: text/plain, Size: 1772 bytes --]

From a8567bf18abe95d1d39209496ca488c76523cde3 Mon Sep 17 00:00:00 2001
From: Peter Oliver <git@mavit.org.uk>
Date: Sat, 10 Jul 2021 12:10:08 +0100
Subject: [PATCH] =?UTF-8?q?Don=E2=80=99t=20claim=20support=20for=20startup?=
 =?UTF-8?q?=20notification=20for=20emacsclient?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

GTK gives us free support for Freedesktop.org startup notification,
but only in the simple case that we are displaying a window for the
first time from a process that has been passed the appropriate
DESKTOP_STARTUP_ID environment variable by the launcher.  With
emacsclient, that’s often not the case.

* etc/emacsclient.desktop: Don’t advertise StartupNotify support.
---
 Makefile.in             | 1 -
 etc/emacsclient.desktop | 1 -
 2 files changed, 2 deletions(-)

diff --git a/Makefile.in b/Makefile.in
index 97d954b6ce..5c58e45717 100644
--- a/Makefile.in
+++ b/Makefile.in
@@ -738,7 +738,6 @@ install-etc:
 	client_name=`echo emacsclient | sed '$(TRANSFORM)'`${EXEEXT}; \
 	sed -e "/^Exec=emacsclient/ s|emacsclient|${bindir}/$${client_name}|" \
 	  -e "/^Icon=emacs/ s/emacs/${EMACS_NAME}/" \
-	  $(USE_STARTUP_NOTIFICATION_SED_CMD) \
 	  ${srcdir}/etc/emacsclient.desktop > $${tmp}; \
 	${INSTALL_DATA} $${tmp} "$(DESTDIR)${desktopdir}/$${client_name}.desktop"; \
 	rm -f $${tmp}
diff --git a/etc/emacsclient.desktop b/etc/emacsclient.desktop
index cd45463093..c3cacb9029 100644
--- a/etc/emacsclient.desktop
+++ b/etc/emacsclient.desktop
@@ -8,7 +8,6 @@ Icon=emacs
 Type=Application
 Terminal=false
 Categories=Development;TextEditor;
-StartupNotify=true
 StartupWMClass=Emacs
 Keywords=Text;Editor;
 Actions=new-window;new-instance;
-- 
2.31.1


      parent reply	other threads:[~2021-07-10 12:41 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-10 11:43 bug#49504: Server support for Freedesktop.org startup notification Peter Oliver
2021-07-10 12:37 ` Eli Zaretskii
2021-07-10 12:56   ` Peter Oliver
2021-07-10 14:30     ` Eli Zaretskii
     [not found] ` <handler.49504.B.16259174312311.ack@debbugs.gnu.org>
2021-07-10 12:41   ` Peter Oliver [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d0e8ff43-2b7b-1751-a4aa-204253762741@froglet.home.mavit.org.uk \
    --to=p.d.oliver@mavit.org.uk \
    --cc=49504@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).