* bug#65102: 30.0.50; `byte-recompile-directory' ignores every file
@ 2023-08-05 13:16 Wing Hei Chan
2023-08-06 4:08 ` Michael Heerdegen
2023-08-06 4:32 ` Jim Porter
0 siblings, 2 replies; 3+ messages in thread
From: Wing Hei Chan @ 2023-08-05 13:16 UTC (permalink / raw)
To: 65102
The `ignore-files-regexp' in `byte-recompile-directory' is bound to the
result of (mapconcat #'identity byte-compile-ignore-files "\\|"),
which is simply an empty string when `byte-compile-ignore-files' is
empty. In turn, this causes every file to be ignored, since
`string-match-p' matches every string when given an empty regexp.
^ permalink raw reply [flat|nested] 3+ messages in thread
* bug#65102: 30.0.50; `byte-recompile-directory' ignores every file
2023-08-05 13:16 bug#65102: 30.0.50; `byte-recompile-directory' ignores every file Wing Hei Chan
@ 2023-08-06 4:08 ` Michael Heerdegen
2023-08-06 4:32 ` Jim Porter
1 sibling, 0 replies; 3+ messages in thread
From: Michael Heerdegen @ 2023-08-06 4:08 UTC (permalink / raw)
To: Wing Hei Chan; +Cc: 65102
Wing Hei Chan <whmunkchan@outlook.com> writes:
> The `ignore-files-regexp' in `byte-recompile-directory' is bound to the
> result of (mapconcat #'identity byte-compile-ignore-files "\\|"),
> which is simply an empty string when `byte-compile-ignore-files' is
> empty. In turn, this causes every file to be ignored, since
> `string-match-p' matches every string when given an empty regexp.
Indeed (to reproduce one has to make sure that one tries a call where
files are actually expected to be compiled, and even in this case
nothing is done - thanks for finding this!).
We probably should use regexp-unmatchable instead of an empty string
when the option is nil.
Do we also need to wrap the regexps into shy groups, or something else?
Thx,
Michael.
^ permalink raw reply [flat|nested] 3+ messages in thread
* bug#65102: 30.0.50; `byte-recompile-directory' ignores every file
2023-08-05 13:16 bug#65102: 30.0.50; `byte-recompile-directory' ignores every file Wing Hei Chan
2023-08-06 4:08 ` Michael Heerdegen
@ 2023-08-06 4:32 ` Jim Porter
1 sibling, 0 replies; 3+ messages in thread
From: Jim Porter @ 2023-08-06 4:32 UTC (permalink / raw)
To: Wing Hei Chan, 65102-done
On 8/5/2023 6:16 AM, Wing Hei Chan wrote:
> The `ignore-files-regexp' in `byte-recompile-directory' is bound to the
> result of (mapconcat #'identity byte-compile-ignore-files "\\|"),
> which is simply an empty string when `byte-compile-ignore-files' is
> empty. In turn, this causes every file to be ignored, since
> `string-match-p' matches every string when given an empty regexp.
This should be fixed by commit 1e8322bb26e, now merged to both master
and the release branch. (I had to read up on how gitmerge.el works, so
hopefully I did the merge properly.)
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-08-06 4:32 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-08-05 13:16 bug#65102: 30.0.50; `byte-recompile-directory' ignores every file Wing Hei Chan
2023-08-06 4:08 ` Michael Heerdegen
2023-08-06 4:32 ` Jim Porter
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).