From: Randy Taylor <dev@rjt.dev>
To: Dmitry Gutov <dgutov@yandex.ru>
Cc: eliz@gnu.org, "Jostein Kjønigsen" <jostein@secure.kjonigsen.net>,
"Yuan Fu" <casouri@gmail.com>,
61302@debbugs.gnu.org
Subject: bug#61302: 29.0.60; rust-ts-mode does not show function-invocation on field-properties
Date: Sat, 18 Feb 2023 20:42:56 +0000 [thread overview]
Message-ID: <c7RGz7a_0mnajr9swyCk0VwEW-SAyZpv6pPc6Wu94u4cOL_6uWSr0UAGBsbo6nFDRx5AaTj7KdES-iOWrd84j4dJl2O38roDuwT6zZa-MUM=@rjt.dev> (raw)
In-Reply-To: <a03ad6c5-b323-83b9-56ff-ccfe4ee89d9d@yandex.ru>
On Friday, February 17th, 2023 at 22:27, Dmitry Gutov <dgutov@yandex.ru> wrote:
>On 16/02/2023 03:53, Dmitry Gutov wrote:
>> But the new one will need to check that the parent is
>> 'scoped_identifier', and the grandparent is not a 'call_expression'
>> node, or 'use_as_clause', or 'use_declaration', etc, and the name itself
>> is lowercase -- when so, skip highlighting. And highlight with one of
>> the two faces when otherwise.
>>
>> Shouldn't be too hard to do, but I'm wary about the additional cost at
>> runtime.
>
>So, this seems to work.
>
>At the cost of some performance overhead due to :pred in the 'variable'
>query (the rest of the changes don't seem to affect the runtime -- guess
>the Lisp calls were balanced out by fewer queries).
Thanks, I think this is actually a lot cleaner than the gazillion queries we had.
It looks good barring a few issues I've noticed.
use a::b::{self as ab, A as abc};
A should be highlighted as a type.
If abc is Abc, Abc should be highlighted as a type.
use std::Fs as Self_fs;
Self_fs should be highlighted as a type.
I only quickly tested, but re-adding these queries:
```
((use_as_clause alias: (identifier) @font-lock-type-face)
(:match "^[A-Z]" @font-lock-type-face))
((use_as_clause path: (identifier) @font-lock-type-face)
(:match "^[A-Z]" @font-lock-type-face))
```
fixes it. Otherwise, I haven't noticed anything else amiss for the types feature.
The variable feature is highlighting some things incorrectly (it was before too, but I think it's a little worse now).
Adding these to rust-ts-mode--variable-p takes care of the issues that I see.
```
((equal "extern_crate_declaration" parent-type)
nil)
((equal "lifetime" parent-type)
nil)
((equal "scoped_type_identifier" parent-type)
nil)
((equal "use_as_clause" parent-type)
nil)
((equal "use_list" parent-type)
nil)
```
next prev parent reply other threads:[~2023-02-18 20:42 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-05 20:15 bug#61302: 29.0.60; rust-ts-mode does not show function-invocation on field-properties Jostein Kjønigsen
2023-02-05 21:30 ` Randy Taylor
2023-02-05 21:52 ` Jostein Kjønigsen
2023-02-05 21:59 ` Jostein Kjønigsen
2023-02-06 1:50 ` Randy Taylor
2023-02-06 2:45 ` Dmitry Gutov
2023-02-06 2:57 ` Randy Taylor
2023-02-07 14:26 ` Randy Taylor
2023-02-07 18:16 ` Dmitry Gutov
2023-02-07 18:25 ` Dmitry Gutov
2023-02-08 3:38 ` Randy Taylor
2023-02-08 15:44 ` Dmitry Gutov
2023-02-09 3:38 ` Randy Taylor
2023-02-09 21:19 ` Dmitry Gutov
2023-02-10 3:44 ` Randy Taylor
[not found] ` <33cec9a6-7e69-2eb3-a8a6-58ce23a5c185@yandex.ru>
2023-02-12 2:48 ` Randy Taylor
2023-02-13 3:37 ` Dmitry Gutov
2023-02-14 3:25 ` Randy Taylor
2023-02-14 11:42 ` Jostein Kjønigsen
2023-02-14 12:39 ` Randy Taylor
2023-02-14 14:28 ` Jostein Kjønigsen
2023-02-14 22:14 ` Dmitry Gutov
2023-02-15 2:07 ` Randy Taylor
2023-02-16 1:53 ` Dmitry Gutov
2023-02-18 3:27 ` Dmitry Gutov
2023-02-18 20:42 ` Randy Taylor [this message]
2023-02-18 21:45 ` Dmitry Gutov
2023-02-18 23:31 ` Randy Taylor
2023-02-19 0:13 ` Dmitry Gutov
2023-02-19 0:50 ` Randy Taylor
2023-02-19 17:23 ` Dmitry Gutov
2023-02-18 20:59 ` Dmitry Gutov
2023-02-13 10:17 ` Jostein Kjønigsen
2023-02-13 14:39 ` Randy Taylor
2023-02-13 15:04 ` Jostein Kjønigsen
2023-02-13 18:19 ` Randy Taylor
2023-02-13 19:57 ` Dmitry Gutov
2023-02-13 20:49 ` Dmitry Gutov
2023-02-13 19:59 ` Dmitry Gutov
2023-02-05 21:56 ` Dmitry Gutov
2023-02-06 2:06 ` Randy Taylor
2023-02-06 2:16 ` Dmitry Gutov
2023-02-05 21:44 ` Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='c7RGz7a_0mnajr9swyCk0VwEW-SAyZpv6pPc6Wu94u4cOL_6uWSr0UAGBsbo6nFDRx5AaTj7KdES-iOWrd84j4dJl2O38roDuwT6zZa-MUM=@rjt.dev' \
--to=dev@rjt.dev \
--cc=61302@debbugs.gnu.org \
--cc=casouri@gmail.com \
--cc=dgutov@yandex.ru \
--cc=eliz@gnu.org \
--cc=jostein@secure.kjonigsen.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).