From: Dmitry Gutov <dgutov@yandex.ru>
To: "Randy Taylor" <dev@rjt.dev>,
"Jostein Kjønigsen" <jostein@secure.kjonigsen.net>
Cc: eliz@gnu.org, 61302@debbugs.gnu.org
Subject: bug#61302: 29.0.60; rust-ts-mode does not show function-invocation on field-properties
Date: Wed, 15 Feb 2023 00:14:22 +0200 [thread overview]
Message-ID: <6b75a99f-05fd-cde9-e9fe-7191f12d72e1@yandex.ru> (raw)
In-Reply-To: <IiE-QEBO2O59zTchL4c3g7pYsxZuNHYmIwOMjWh0snCwVP19UcS-yV1o2LzXUbm7YS6jhlDaxP6iXVp-mKBU19GIwFqNYJCvamuLiLYq3pI=@rjt.dev>
[-- Attachment #1: Type: text/plain, Size: 1648 bytes --]
On 14/02/2023 14:39, Randy Taylor wrote:
> On Tuesday, February 14th, 2023 at 06:42, Jostein Kjønigsen
> <jostein@secure.kjonigsen.net> wrote:
>>Haven given the latest patch a try on a less macro-ridden codebase I have to
> say it looks a lot better. In general I would say for this other
> code-base it looks favourable to rust-mode.
>>
>>If there's one thing which still seems to be done better in rust-mode
> (not nitpicking the variable highlighting), it would be fully namespaces
> function calls within classes.
>>
>>Consider the following code:
>>
>>extern crate claxon;
>>let result = claxon::FlacReader::open(path);
>>
>>While rust-ts-mode correctly identifies that open() is a function-call,
> rust-mode correctly identified FlacReader as a class.
>
> Thanks for testing. I've attached a patch fixing this.
>
> I had deleted a query I thought was now covered :). I look forward to
> the day we have highlight tests!
Thank you, looks almost perfect (see below), I've pushed that to emacs-29.
Highlighting tests are a pain to write, but the initiative is always
welcome. ;-) In the meantime, at least tree-sitter validates the
queries, which lowers the odds of typos in font-lock rules.
Speaking of a problem, the solution with applying the explicit 'default'
face doesn't seem ideal. Aside from the redundancy in the resulting
buffer structure (with very little practical downside), it also makes
the 'vc-diff' buffers look like this on the attached screenshots (the
'default' face's background overrides the greens and reds).
I couldn't find a quick solution to this problem, so I pushed the
existing code for now.
[-- Attachment #2: Screenshot from 2023-02-14 23-42-25.png --]
[-- Type: image/png, Size: 74181 bytes --]
[-- Attachment #3: Screenshot from 2023-02-14 23-42-40.png --]
[-- Type: image/png, Size: 76353 bytes --]
next prev parent reply other threads:[~2023-02-14 22:14 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-05 20:15 bug#61302: 29.0.60; rust-ts-mode does not show function-invocation on field-properties Jostein Kjønigsen
2023-02-05 21:30 ` Randy Taylor
2023-02-05 21:52 ` Jostein Kjønigsen
2023-02-05 21:59 ` Jostein Kjønigsen
2023-02-06 1:50 ` Randy Taylor
2023-02-06 2:45 ` Dmitry Gutov
2023-02-06 2:57 ` Randy Taylor
2023-02-07 14:26 ` Randy Taylor
2023-02-07 18:16 ` Dmitry Gutov
2023-02-07 18:25 ` Dmitry Gutov
2023-02-08 3:38 ` Randy Taylor
2023-02-08 15:44 ` Dmitry Gutov
2023-02-09 3:38 ` Randy Taylor
2023-02-09 21:19 ` Dmitry Gutov
2023-02-10 3:44 ` Randy Taylor
[not found] ` <33cec9a6-7e69-2eb3-a8a6-58ce23a5c185@yandex.ru>
2023-02-12 2:48 ` Randy Taylor
2023-02-13 3:37 ` Dmitry Gutov
2023-02-14 3:25 ` Randy Taylor
2023-02-14 11:42 ` Jostein Kjønigsen
2023-02-14 12:39 ` Randy Taylor
2023-02-14 14:28 ` Jostein Kjønigsen
2023-02-14 22:14 ` Dmitry Gutov [this message]
2023-02-15 2:07 ` Randy Taylor
2023-02-16 1:53 ` Dmitry Gutov
2023-02-18 3:27 ` Dmitry Gutov
2023-02-18 20:42 ` Randy Taylor
2023-02-18 21:45 ` Dmitry Gutov
2023-02-18 23:31 ` Randy Taylor
2023-02-19 0:13 ` Dmitry Gutov
2023-02-19 0:50 ` Randy Taylor
2023-02-19 17:23 ` Dmitry Gutov
2023-02-18 20:59 ` Dmitry Gutov
2023-02-13 10:17 ` Jostein Kjønigsen
2023-02-13 14:39 ` Randy Taylor
2023-02-13 15:04 ` Jostein Kjønigsen
2023-02-13 18:19 ` Randy Taylor
2023-02-13 19:57 ` Dmitry Gutov
2023-02-13 20:49 ` Dmitry Gutov
2023-02-13 19:59 ` Dmitry Gutov
2023-02-05 21:56 ` Dmitry Gutov
2023-02-06 2:06 ` Randy Taylor
2023-02-06 2:16 ` Dmitry Gutov
2023-02-05 21:44 ` Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6b75a99f-05fd-cde9-e9fe-7191f12d72e1@yandex.ru \
--to=dgutov@yandex.ru \
--cc=61302@debbugs.gnu.org \
--cc=dev@rjt.dev \
--cc=eliz@gnu.org \
--cc=jostein@secure.kjonigsen.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).