From: Mauro Aranda <maurooaranda@gmail.com>
To: Juri Linkov <juri@linkov.net>
Cc: 64759@debbugs.gnu.org, Eli Zaretskii <eliz@gnu.org>
Subject: bug#64759: Broken faces
Date: Fri, 21 Jul 2023 07:48:30 -0300 [thread overview]
Message-ID: <c68de499-1a86-3cf6-6224-3c97c554c676@gmail.com> (raw)
In-Reply-To: <86bkg53cau.fsf@mail.linkov.net>
Juri Linkov <juri@linkov.net> writes:
> It seems adding non-empty definitions in bug#64655
> were intended to workaround a bug in cus-edit.el,
> not to fix it.
>
> Maybe Mauro could help to fix it (Cc'ed)
> without requiring non-nil definitions
> that anyway can not be fixed outside of
> the Emacs source tree, i.e. in numerous
> user init files and external packages.
I don't think it is a bug in Custom. Custom will allow the user to edit
the face and set/save or whatever, even if it's definition is
(defface foo nil "...")
But it seems to me that it's better to define it like this:
(defface foo '((t nil)) "...")
so that the face gets a face-defface-spec property.
So maybe the definition for display-time-date-and-time should be changed
to:
(defface display-time-date-and-time
'((t nil))
"Face for `display-time-format'."
:group 'mode-line-faces
:version "30.1")
instead that making it inherit from mode-line?
next prev parent reply other threads:[~2023-07-21 10:48 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-21 6:37 bug#64759: Broken faces Juri Linkov
2023-07-21 7:50 ` Robert Pluim
2023-07-21 8:13 ` Juri Linkov
2023-07-21 10:56 ` Eli Zaretskii
2023-07-21 7:51 ` Eli Zaretskii
2023-07-21 8:13 ` Juri Linkov
2023-07-21 10:48 ` Mauro Aranda [this message]
2023-07-21 16:21 ` Juri Linkov
2023-07-21 16:40 ` Eli Zaretskii
2023-07-21 17:51 ` Juri Linkov
2023-07-21 18:35 ` Eli Zaretskii
2023-07-21 18:49 ` Juri Linkov
2023-07-21 18:55 ` Eli Zaretskii
2023-07-24 17:35 ` Juri Linkov
2023-07-24 18:21 ` Eli Zaretskii
2023-07-25 17:04 ` Juri Linkov
2023-07-25 17:43 ` Eli Zaretskii
2023-07-28 17:30 ` Juri Linkov
2023-07-28 18:49 ` Eli Zaretskii
2023-07-31 17:42 ` Juri Linkov
2023-07-31 18:31 ` Eli Zaretskii
2023-07-31 20:37 ` Mauro Aranda
2023-07-21 10:53 ` Eli Zaretskii
2023-07-21 10:54 ` Eli Zaretskii
2023-07-21 16:20 ` Juri Linkov
2023-07-21 16:39 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c68de499-1a86-3cf6-6224-3c97c554c676@gmail.com \
--to=maurooaranda@gmail.com \
--cc=64759@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=juri@linkov.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).