From: Juri Linkov <juri@linkov.net>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 64759@debbugs.gnu.org, maurooaranda@gmail.com
Subject: bug#64759: Broken faces
Date: Mon, 31 Jul 2023 20:42:22 +0300 [thread overview]
Message-ID: <863514asg1.fsf@mail.linkov.net> (raw)
In-Reply-To: <83wmyjj2gi.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 28 Jul 2023 21:49:49 +0300")
>> 1. M-x make-empty-face RET foo RET
>> 2. M-x customize-face RET foo RET
>>
>> Then output is:
>>
>> Hide Foo face: [sample]
>> State : NO CUSTOMIZATION DATA; not intended to be customized.
Please note that the problem is still unfixed for
"NO CUSTOMIZATION DATA".
>> nil
>> -- Empty face --
>
> We are mis-communicating. My point is that we need to explain in the
> documentation the effect of such a defface when the face is realized
> and displayed. Lisp programmers need to understand that to be able to
> use this correctly and predictably.
For example, in *scratch* eval:
(put-text-property (point-min) (point-max)
'font-lock-face (make-empty-face 'foo))
Then 'C-u C-x =' shows:
There are text properties here:
font-lock-face foo
Then clicking on 'foo' shows:
Face: foo (sample) (customize this face)
Documentation:
Not documented as a face.
Family: unspecified
Foundry: unspecified
Width: unspecified
Height: unspecified
Weight: unspecified
Slant: unspecified
Foreground: unspecified
DistantForeground: unspecified
Background: unspecified
Underline: unspecified
Overline: unspecified
Strike-through: unspecified
Box: unspecified
Inverse: unspecified
Stipple: unspecified
Font: unspecified
Fontset: unspecified
Extend: unspecified
Inherit: unspecified
That's all that Lisp programmers need to know: that in an empty face
all attributes are unspecified.
>> > Only if "no better face to inherit from is available" in all of those
>> > cases. Which I'm not sure is true. If you are sure, please tell why
>> > the faces I put there are not better ideas.
>>
>> Because they will cause the same problem as with display-time-date-and-time,
>> except that other faces are used less often, so it will take time until users
>> will notice these problems.
>
> display-time-date-and-time is used on the mode line, where the colors
> are different. The other faces are for buffer text, so the problems
> with display-time-date-and-time don't necessarily apply.
It's possible that these faces are applied over other faces
that will break the default theme.
next prev parent reply other threads:[~2023-07-31 17:42 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-21 6:37 bug#64759: Broken faces Juri Linkov
2023-07-21 7:50 ` Robert Pluim
2023-07-21 8:13 ` Juri Linkov
2023-07-21 10:56 ` Eli Zaretskii
2023-07-21 7:51 ` Eli Zaretskii
2023-07-21 8:13 ` Juri Linkov
2023-07-21 10:48 ` Mauro Aranda
2023-07-21 16:21 ` Juri Linkov
2023-07-21 16:40 ` Eli Zaretskii
2023-07-21 17:51 ` Juri Linkov
2023-07-21 18:35 ` Eli Zaretskii
2023-07-21 18:49 ` Juri Linkov
2023-07-21 18:55 ` Eli Zaretskii
2023-07-24 17:35 ` Juri Linkov
2023-07-24 18:21 ` Eli Zaretskii
2023-07-25 17:04 ` Juri Linkov
2023-07-25 17:43 ` Eli Zaretskii
2023-07-28 17:30 ` Juri Linkov
2023-07-28 18:49 ` Eli Zaretskii
2023-07-31 17:42 ` Juri Linkov [this message]
2023-07-31 18:31 ` Eli Zaretskii
2023-07-31 20:37 ` Mauro Aranda
2023-07-21 10:53 ` Eli Zaretskii
2023-07-21 10:54 ` Eli Zaretskii
2023-07-21 16:20 ` Juri Linkov
2023-07-21 16:39 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=863514asg1.fsf@mail.linkov.net \
--to=juri@linkov.net \
--cc=64759@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=maurooaranda@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).