bug#21006: 25.0.50; xref-quit doesn't restore changes in window scrolling position

bug#21006: 25.0.50; xref-quit doesn't restore changes in window scrolling position

[Dmitry Gutov]

1. Open lisp/progmodes/elisp-mode.el.

2. M-x xref-find-regexp, type 'defun elisp-[a-z]' (without quotes) when
prompted, press RET.

3. In the xref buffer, press `n' a couple of times, see the window
displaying elisp-mode.el scroll to show the definitions.

4. Press `q', see the previous window configuration restored, but the
scrolling position of the elisp-mode.el window remains changed.

I wonder if we can do anything about that.

While there's nothing surprising in this behavior given the
implementation, the user did lose their position in the buffer, train of
thought, etc.

bug#21006: 25.0.50; xref-quit doesn't restore changes in window scrolling position

[Lars Ingebrigtsen]

Dmitry Gutov <dgutov@yandex.ru> writes:

> 1. Open lisp/progmodes/elisp-mode.el.
>
> 2. M-x xref-find-regexp, type 'defun elisp-[a-z]' (without quotes) when
> prompted, press RET.

This function no longer exists, so the recipe no longer works.

Is this problem still present in the current Emacs version?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#21006: 25.0.50; xref-quit doesn't restore changes in window scrolling position

[Dmitry Gutov]

On 03.12.2020 13:30, Lars Ingebrigtsen wrote:
> This function no longer exists, so the recipe no longer works.
> 
> Is this problem still present in the current Emacs version?

Yes, sure. You can repeat the scenario with 'M-x project-find-regexp'.

The crux is doesn't restore the previous window scroll positions.

This especially cut against the mental model of the older version of the 
UI which presented locations in a more "transient" fashion. But the 
model has changed, and there haven't been any complaints like this 
recently, so let's close it.

Thanks.

bug#21006: 25.0.50; xref-quit doesn't restore changes in window scrolling position

[martin rudalics]

 > The crux is doesn't restore the previous window scroll positions.

What are the "previous window scroll positions"?  Note that

   As a special exception, the window configuration does not record the
   value of point in the selected window for the current buffer.

(section 28.26 of the Elisp manual) so if a caller wants that restored,
it has to do it separately.

martin

bug#21006: 25.0.50; xref-quit doesn't restore changes in window scrolling position

[Dmitry Gutov]

On 03.12.2020 17:44, martin rudalics wrote:
>  > The crux is doesn't restore the previous window scroll positions.
> 
> What are the "previous window scroll positions"?  Note that
> 
>    As a special exception, the window configuration does not record the
>    value of point in the selected window for the current buffer.
> 
> (section 28.26 of the Elisp manual) so if a caller wants that restored,
> it has to do it separately.

That's it.

I wasn't saying it is necessarily a bug in quit-window. Just something 
that would have to be implemented in xref, to have a more consistent 
experience (the bug was for a "future me" or somebody else who had the 
time to look into it).

Not necessary anymore, anyway.