From: Phil Sainty <psainty@orcon.net.nz>
To: 51711@debbugs.gnu.org
Cc: Dmitry Gutov <dgutov@yandex.ru>
Subject: bug#51711: 28.0.60; rgrep fails to pass the search directory to rgrep-default-command
Date: Tue, 09 Nov 2021 23:02:43 +1300 [thread overview]
Message-ID: <c017062a8164a018eeafb47e81edbeea@webmail.orcon.net.nz> (raw)
This was intentionally changed in commit c6ee95ddeef:
https://git.savannah.gnu.org/cgit/emacs.git/commit?id=c6ee95ddeefc17410e15090539d0cb220ab6947c
(setq dir (file-name-as-directory (expand-file-name dir)))
- (let ((command (rgrep-default-command regexp files dir)))
+ (let ((command (rgrep-default-command regexp files nil)))
It's not clear to me why this was done, but rgrep-default-command
cannot produce the correct output if it isn't given the search
directory. In particular, rgrep-find-ignored-directories and
rgrep-find-ignored-files no longer work as expected, if the
directory is not passed, for grep-find-ignored-directories and
grep-find-ignored-files values using the cons cell format, as
the functions specified need to know the search directory.
https://debbugs.gnu.org/cgi/bugreport.cgi?bug=20719#22 may be the
justification ("it makes the last argument to rgrep-default-command
look superfluous."), but that's definitely not true.
I don't have my head around the other changes made for bug#20719
and so it's not clear to me whether fixing this is as simple as
reverting that one line, or if doing so will cause some other
regression.
CCing Dmitry. Can you recall specifically why that line was changed?
-Phil
In GNU Emacs 28.0.60 (build 1, x86_64-pc-linux-gnu, X toolkit, cairo
version 1.15.10, Xaw scroll bars)
of 2021-10-07 built on phil-lp
Repository revision: f7e6c199bf5b915e000bad964f3be2323d07647e
Repository branch: emacs-28
Windowing system distributor 'The X.Org Foundation', version
11.0.12008000
System Description: Ubuntu 18.04.6 LTS
next reply other threads:[~2021-11-09 10:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-09 10:02 Phil Sainty [this message]
2021-11-11 0:17 ` bug#51711: 28.0.60; rgrep fails to pass the search directory to rgrep-default-command Dmitry Gutov
2021-11-11 1:48 ` Phil Sainty
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c017062a8164a018eeafb47e81edbeea@webmail.orcon.net.nz \
--to=psainty@orcon.net.nz \
--cc=51711@debbugs.gnu.org \
--cc=dgutov@yandex.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).