From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Phil Sainty Newsgroups: gmane.emacs.bugs Subject: bug#51711: 28.0.60; rgrep fails to pass the search directory to rgrep-default-command Date: Tue, 09 Nov 2021 23:02:43 +1300 Message-ID: Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="39694"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Orcon Webmail Cc: Dmitry Gutov To: 51711@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Nov 09 11:03:09 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mkNy9-000A6b-FN for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 09 Nov 2021 11:03:09 +0100 Original-Received: from localhost ([::1]:43976 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mkNy8-0006dq-7M for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 09 Nov 2021 05:03:08 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:53042) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mkNy2-0006dR-O8 for bug-gnu-emacs@gnu.org; Tue, 09 Nov 2021 05:03:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:49329) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mkNy2-0001ZA-Er for bug-gnu-emacs@gnu.org; Tue, 09 Nov 2021 05:03:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mkNy2-0000Gd-5h for bug-gnu-emacs@gnu.org; Tue, 09 Nov 2021 05:03:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Phil Sainty Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 09 Nov 2021 10:03:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 51711 X-GNU-PR-Package: emacs X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.16364521801016 (code B ref -1); Tue, 09 Nov 2021 10:03:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 9 Nov 2021 10:03:00 +0000 Original-Received: from localhost ([127.0.0.1]:60875 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mkNy0-0000GK-3S for submit@debbugs.gnu.org; Tue, 09 Nov 2021 05:03:00 -0500 Original-Received: from lists.gnu.org ([209.51.188.17]:45634) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mkNxv-0000G8-56 for submit@debbugs.gnu.org; Tue, 09 Nov 2021 05:02:57 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:52994) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mkNxu-0006dH-Vz for bug-gnu-emacs@gnu.org; Tue, 09 Nov 2021 05:02:55 -0500 Original-Received: from smtp-2.orcon.net.nz ([60.234.4.43]:37135) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mkNxt-0001E4-Cl for bug-gnu-emacs@gnu.org; Tue, 09 Nov 2021 05:02:54 -0500 Original-Received: from [10.253.37.70] (port=64610 helo=webmail.orcon.net.nz) by smtp-2.orcon.net.nz with esmtpa (Exim 4.90_1) (envelope-from ) id 1mkNxj-0005Ab-F8; Tue, 09 Nov 2021 23:02:44 +1300 Original-Received: from ip-115-69-175-77.kinect.net.nz ([115.69.175.77]) via [10.253.37.253] by webmail.orcon.net.nz with HTTP (HTTP/1.1 POST); Tue, 09 Nov 2021 23:02:43 +1300 X-Sender: psainty@orcon.net.nz X-GeoIP: -- Received-SPF: pass client-ip=60.234.4.43; envelope-from=psainty@orcon.net.nz; helo=smtp-2.orcon.net.nz X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:219431 Archived-At: This was intentionally changed in commit c6ee95ddeef: https://git.savannah.gnu.org/cgit/emacs.git/commit?id=c6ee95ddeefc17410e15090539d0cb220ab6947c (setq dir (file-name-as-directory (expand-file-name dir))) - (let ((command (rgrep-default-command regexp files dir))) + (let ((command (rgrep-default-command regexp files nil))) It's not clear to me why this was done, but rgrep-default-command cannot produce the correct output if it isn't given the search directory. In particular, rgrep-find-ignored-directories and rgrep-find-ignored-files no longer work as expected, if the directory is not passed, for grep-find-ignored-directories and grep-find-ignored-files values using the cons cell format, as the functions specified need to know the search directory. https://debbugs.gnu.org/cgi/bugreport.cgi?bug=20719#22 may be the justification ("it makes the last argument to rgrep-default-command look superfluous."), but that's definitely not true. I don't have my head around the other changes made for bug#20719 and so it's not clear to me whether fixing this is as simple as reverting that one line, or if doing so will cause some other regression. CCing Dmitry. Can you recall specifically why that line was changed? -Phil In GNU Emacs 28.0.60 (build 1, x86_64-pc-linux-gnu, X toolkit, cairo version 1.15.10, Xaw scroll bars) of 2021-10-07 built on phil-lp Repository revision: f7e6c199bf5b915e000bad964f3be2323d07647e Repository branch: emacs-28 Windowing system distributor 'The X.Org Foundation', version 11.0.12008000 System Description: Ubuntu 18.04.6 LTS