bug#14931: 24.3; marking extensions with dired-x

bug#14931: 24.3; marking extensions with dired-x

[Dieter Wilhelm, H.]

This bug report will be sent to the Bug-GNU-Emacs mailing list
and the GNU bug tracker at debbugs.gnu.org.  Please check that
the From: line contains a valid email address.  After a delay of up
to one day, you should receive an acknowledgment at that address.

Please write in English if possible, as the Emacs maintainers
usually do not have translators for other languages.

Please describe exactly what actions triggered the bug, and
the precise symptoms of the bug.  If you can, give a recipe
starting from `emacs -Q':

Hi,

dired-x does not mark lists of extension as advertised, please have a
look at the following diff output.

Thank you for dired

      Dieter

diff -c /appl/emacs-24.3/lisp/dired-x.el\~ /appl/emacs-24.3/lisp/dired-x.el
*** /appl/emacs-24.3/lisp/dired-x.el~    2013-01-01 21:37:17.000000000 +0100
--- /appl/emacs-24.3/lisp/dired-x.el    2013-07-22 12:13:52.836582859 +0200
***************
*** 335,344 ****
    ;; EXTENSION may also be a list of extensions instead of a single one.
    ;; Optional MARKER-CHAR is marker to use.
    (interactive "sMarking extension: \nP")
!   (or (listp extension)
!       (setq extension (list extension)))
    (dired-mark-files-regexp
!    (concat ".";; don't match names with nothing but an extension
             "\\("
             (mapconcat 'regexp-quote extension "\\|")
             "\\)$")
--- 335,343 ----
    ;; EXTENSION may also be a list of extensions instead of a single one.
    ;; Optional MARKER-CHAR is marker to use.
    (interactive "sMarking extension: \nP")
!   (setq extension (split-string extension))
    (dired-mark-files-regexp
!    (concat "\\.";; don't match names with nothing but an extension
             "\\("
             (mapconcat 'regexp-quote extension "\\|")
             "\\)$")

Diff finished.  Mon Jul 22 12:13:54 2013


If Emacs crashed, and you have the Emacs process in the gdb debugger,
please include the output from the following gdb commands:
    `bt full' and `xbacktrace'.
For information about debugging Emacs, please read the file
/appl/emacs-24.3/etc/DEBUG.


In GNU Emacs 24.3.1 (x86_64-unknown-linux-gnu, GTK+ Version 2.18.9)
 of 2013-03-19 on sbav106x.vs.de.conti.de
Windowing system distributor `Red Hat, Inc.', version 11.0.11006000
System Description:    Red Hat Enterprise Linux Server release 6.3 (Santiago)

Important settings:
  value of $LANG: en_GB.utf8
  locale-coding-system: utf-8-unix
  default enable-multibyte-characters: t

Major mode: Lisp Interaction

Minor modes in effect:
  tooltip-mode: t
  mouse-wheel-mode: t
  tool-bar-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  line-number-mode: t
  transient-mark-mode: t

Recent input:
<help-echo> <help-echo> <help-echo> <help-echo> <help-echo>
<help-echo> <help-echo> <help-echo> <help-echo> <help-echo>
<help-echo> <help-echo> <help-echo> <help-echo> <help-echo>
<help-echo> <help-echo> <help-echo> <help-echo> <help-echo>
<help-echo> <help-echo> <help-echo> <help-echo> <help-echo>
<help-echo> <help-echo> <help-echo> <menu-bar> <help-menu>
<send-emacs-bug-report>

Recent messages:
For information about GNU Emacs and the GNU system, type C-h C-a.

Load-path shadows:
None found.

Features:
(shadow sort gnus-util mail-extr emacsbug message format-spec rfc822 mml
easymenu mml-sec mm-decode mm-bodies mm-encode mail-parse rfc2231
mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums
mm-util mail-prsvr mail-utils time-date tooltip ediff-hook vc-hooks
lisp-float-type mwheel x-win x-dnd tool-bar dnd fontset image regexp-opt
fringe tabulated-list newcomment lisp-mode register page menu-bar
rfn-eshadow timer select scroll-bar mouse jit-lock font-lock syntax
facemenu font-core frame cham georgian utf-8-lang misc-lang vietnamese
tibetan thai tai-viet lao korean japanese hebrew greek romanian slovak
czech european ethiopic indian cyrillic chinese case-table epa-hook
jka-cmpr-hook help simple abbrev minibuffer loaddefs button faces
cus-face macroexp files text-properties overlay sha1 md5 base64 format
env code-pages mule custom widget hashtable-print-readable backquote
make-network-process dynamic-setting font-render-setting move-toolbar
gtk x-toolkit x multi-tty emacs)

--
    Best wishes

    H. Dieter Wilhelm
    Schwalbach, Germany

--
Best wishes

    H. Dieter Wilhelm

Darmstadt
Germany

bug#14931: 24.3; marking extensions with dired-x

[Glenn Morris]

"Dieter Wilhelm, H." wrote:

> dired-x does not mark lists of extension as advertised, please have a
> look at the following diff output.

It seems to work for me, and at first sight your patch does not look
right. I tried:

emacs-24.3 -Q -l dired-x
C-x d /path/to/lisp
M-: (dired-mark-extension '(".el" ".elc"))

> *** /appl/emacs-24.3/lisp/dired-x.el~    2013-01-01 21:37:17.000000000 +0100
> --- /appl/emacs-24.3/lisp/dired-x.el    2013-07-22 12:13:52.836582859 +0200
> ***************
> *** 335,344 ****
>     ;; EXTENSION may also be a list of extensions instead of a single one.
>     ;; Optional MARKER-CHAR is marker to use.
>     (interactive "sMarking extension: \nP")
> !   (or (listp extension)
> !       (setq extension (list extension)))
>     (dired-mark-files-regexp
> !    (concat ".";; don't match names with nothing but an extension
>              "\\("
>              (mapconcat 'regexp-quote extension "\\|")
>              "\\)$")
> --- 335,343 ----
>     ;; EXTENSION may also be a list of extensions instead of a single one.
>     ;; Optional MARKER-CHAR is marker to use.
>     (interactive "sMarking extension: \nP")
> !   (setq extension (split-string extension))
>     (dired-mark-files-regexp
> !    (concat "\\.";; don't match names with nothing but an extension
>              "\\("
>              (mapconcat 'regexp-quote extension "\\|")
>              "\\)$")

bug#14931: 24.3; marking extensions with dired-x

[Glenn Morris]

Please keep the debbugs address cc'd.
Resending your comments so they are more visible.


Date: Wed, 24 Jul 2013 11:03:16 +0200
From: "Dieter Wilhelm, H." <dieter@duenenhof-wilhelm.de>

2013/7/24 Glenn Morris <rgm@gnu.org>:

Hi Glenn, thank you for your reply.

>> dired-x does not mark lists of extension as advertised, please have a
>> look at the following diff output.

> It seems to work for me, and at first sight your patch does not look
> right. I tried:
> emacs-24.3 -Q -l dired-x
> C-x d /path/to/lisp
> M-: (dired-mark-extension '(".el" ".elc"))

Sorry, I did only consider the interactive approach with 'C-* .'!
Since I think this is more relevant/frequent to the dired usage as the
purely programatical one. Idealy one would combine both! :-)

With my diff a simple sequence in the mini-buffer like 'png jpg' is
working, though not with the original code...

Thanks for your attention

   Dieter

bug#14931: 24.3; marking extensions with dired-x

[Dieter Wilhelm, H.]

2013/7/24 Glenn Morris <rgm@gnu.org>:
>
> Please keep the debbugs address cc'd.
> Resending your comments so they are more visible.

I see and I'll take care.  I noticed also a minor typo of mine below...

> Date: Wed, 24 Jul 2013 11:03:16 +0200
> From: "Dieter Wilhelm, H." <dieter@duenenhof-wilhelm.de>
>
> 2013/7/24 Glenn Morris <rgm@gnu.org>:
>
> Hi Glenn, thank you for your reply.
>
>>> dired-x does not mark lists of extension as advertised, please have a
>>> look at the following diff output.
>
>> It seems to work for me, and at first sight your patch does not look
>> right. I tried:
>> emacs-24.3 -Q -l dired-x
>> C-x d /path/to/lisp
>> M-: (dired-mark-extension '(".el" ".elc"))
>
> Sorry, I did only consider the interactive approach with 'C-* .'!

I meant '* .' not 'C-* .' of course...

--

  Dieter

> Since I think this is more relevant/frequent to the dired usage as the
> purely programatical one. Idealy one would combine both! :-)
>
> With my diff a simple sequence in the mini-buffer like 'png jpg' is
> working, though not with the original code...
>
> Thanks for your attention
>
>    Dieter

bug#14931: 24.3; marking extensions with dired-x

[Glenn Morris]

"Dieter Wilhelm, H." wrote:

>> Sorry, I did only consider the interactive approach with 'C-* .'!
>
> I meant '* .' not 'C-* .' of course...

(Why can't you just call it twice?)

>> Since I think this is more relevant/frequent to the dired usage as the
>> purely programatical one. Idealy one would combine both! :-)

In that case, you are asking for a new feature. Up to now, the only
documentation (besides a comment in the source) of this "takes a list"
option is in the dired-x manual, which says:

    When called from Lisp, EXTENSION may also be a list of extensions
 
>> With my diff a simple sequence in the mini-buffer like 'png jpg' is
>> working, though not with the original code...

Firstly, note the documentation says:

  A `.' is *not* automatically prepended to the string entered.

Secondly, what if someone wants to mark extensions with spaces, eg files
named "*.my extension"?

bug#14931: 24.3; marking extensions with dired-x

[Dieter Wilhelm, H.]

2013/7/24 Glenn Morris <rgm@gnu.org>:
> "Dieter Wilhelm, H." wrote:
>
>>> Sorry, I did only consider the interactive approach with 'C-* .'!
>>
>> I meant '* .' not 'C-* .' of course...
>
> (Why can't you just call it twice?)

I did this first but instinctively guessed that there must be another
way of selecting multiple extensions.  Then I misread the
documentation in my sense concluding that it should be possible to do
this also interactively and therefore assumed a bug.

With my half-baked but working solution I got then too carried away,
thank you for your explanations and please close this "bug" report.

>>> Since I think this is more relevant/frequent to the dired usage as the
>>> purely programatical one. Idealy one would combine both! :-)
>
> In that case, you are asking for a new feature. Up to now, the only

You're right, this would be a new feature and I don't want to burden
somebody to implement this only minor improvement in all its
generality.
Maybe I'll improve my change at one stage in the future and'll submit it again.

--
Thank you for your patience

   Dieter

> documentation (besides a comment in the source) of this "takes a list"
> option is in the dired-x manual, which says:
>
>     When called from Lisp, EXTENSION may also be a list of extensions
>
>>> With my diff a simple sequence in the mini-buffer like 'png jpg' is
>>> working, though not with the original code...
>
> Firstly, note the documentation says:
>
>   A `.' is *not* automatically prepended to the string entered.
>
> Secondly, what if someone wants to mark extensions with spaces, eg files
> named "*.my extension"?

bug#14931: 24.3; marking extensions with dired-x

[Lars Ingebrigtsen]

"Dieter Wilhelm, H." <dieter@duenenhof-wilhelm.de> writes:

> With my half-baked but working solution I got then too carried away,
> thank you for your explanations and please close this "bug" report.

There didn't seem to be much enthusiasm for this feature request, but
the bug report was left open, so I'm closing it now.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no