From: Paul Eggert <eggert@cs.ucla.edu>
To: "Mattias Engdegård" <mattiase@acm.org>
Cc: 37659@debbugs.gnu.org
Subject: bug#37659: Mattias Engdegård <mattiase <at> acm.org>
Date: Fri, 11 Oct 2019 16:07:25 -0700 [thread overview]
Message-ID: <bfbec61a-873c-21be-f9eb-c26c0ad5f395@cs.ucla.edu> (raw)
In-Reply-To: <EEEF0800-40AC-4121-A55C-6B0C3804D566@acm.org>
Thanks for the proposed patch. Two thoughts:
1. Instead of the symbol 'unordered-or' (which is remarkably hard to
read), I suggest using the ASCII letter 'V'. This ASCIIfies the Unicode
symbol U+2228 LOGICAL OR (∨). If you prefer, you could make the Unicode
symbol an alias for 'V', or use lower-case ASCII 'v', or whatever. The
point is that '(unordered-or A B)' is too hard to read with all those
'or's in there.
2. Re this patch:
> - ((or 'anychar 'anything) (rx--translate-form '(or nonl "\n")))
> + ((or 'anychar 'anything) (cons (list "[^z-a]") t))
Is there a reason this uses (cons (list "[^z-a]") t) rather than
'(("[^z-a]") . t) ? I realize neighboring code does something similar,
but it's not clear to me why it's important to construct new objects
here instead of using literals.
next prev parent reply other threads:[~2019-10-11 23:07 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-08 9:36 bug#37659: rx additions: anychar, unmatchable, unordered-or Mattias Engdegård
2019-10-09 8:59 ` Mattias Engdegård
2019-10-11 23:07 ` Paul Eggert [this message]
2019-10-12 10:47 ` bug#37659: Mattias Engdegård <mattiase <at> acm.org> Mattias Engdegård
2019-10-13 16:52 ` Paul Eggert
2019-10-13 19:48 ` Mattias Engdegård
2019-10-22 15:14 ` bug#37659: rx additions: anychar, unmatchable, unordered-or Mattias Engdegård
2019-10-22 15:27 ` Robert Pluim
2019-10-22 17:33 ` Paul Eggert
2019-10-23 9:15 ` Mattias Engdegård
2019-10-23 23:14 ` Paul Eggert
2019-10-24 1:56 ` Drew Adams
2019-10-24 9:09 ` Mattias Engdegård
2019-10-24 14:24 ` Drew Adams
2019-10-24 9:17 ` Phil Sainty
2019-10-24 14:32 ` Drew Adams
2019-10-24 8:58 ` Mattias Engdegård
2019-10-27 11:53 ` Mattias Engdegård
2020-02-11 12:57 ` Mattias Engdegård
2020-02-11 15:43 ` Eli Zaretskii
2020-02-11 19:17 ` Mattias Engdegård
2020-02-12 0:52 ` Paul Eggert
2020-02-12 11:22 ` Mattias Engdegård
2020-02-13 18:38 ` Mattias Engdegård
2020-02-13 18:50 ` Paul Eggert
2020-02-13 19:16 ` Mattias Engdegård
2020-02-13 19:30 ` Eli Zaretskii
2020-02-13 22:23 ` Mattias Engdegård
2020-02-14 7:45 ` Eli Zaretskii
2020-02-14 16:15 ` Paul Eggert
2020-02-14 20:49 ` Mattias Engdegård
2020-03-01 10:09 ` Mattias Engdegård
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bfbec61a-873c-21be-f9eb-c26c0ad5f395@cs.ucla.edu \
--to=eggert@cs.ucla.edu \
--cc=37659@debbugs.gnu.org \
--cc=mattiase@acm.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).