From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.bugs Subject: bug#37659: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= acm.org> Date: Fri, 11 Oct 2019 16:07:25 -0700 Organization: UCLA Computer Science Department Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="261900"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.0 Cc: 37659@debbugs.gnu.org To: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Oct 12 01:08:11 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iJ415-00161m-Kq for geb-bug-gnu-emacs@m.gmane.org; Sat, 12 Oct 2019 01:08:11 +0200 Original-Received: from localhost ([::1]:57766 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iJ414-0007sT-GC for geb-bug-gnu-emacs@m.gmane.org; Fri, 11 Oct 2019 19:08:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:37470) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iJ40x-0007sJ-IT for bug-gnu-emacs@gnu.org; Fri, 11 Oct 2019 19:08:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iJ40w-0007Yq-KI for bug-gnu-emacs@gnu.org; Fri, 11 Oct 2019 19:08:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:51676) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iJ40w-0007YY-Gl for bug-gnu-emacs@gnu.org; Fri, 11 Oct 2019 19:08:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iJ40w-0005p6-84 for bug-gnu-emacs@gnu.org; Fri, 11 Oct 2019 19:08:02 -0400 X-Loop: help-debbugs@gnu.org In-Reply-To: Resent-From: Paul Eggert Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 11 Oct 2019 23:08:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 37659 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 37659-submit@debbugs.gnu.org id=B37659.157083525622341 (code B ref 37659); Fri, 11 Oct 2019 23:08:02 +0000 Original-Received: (at 37659) by debbugs.gnu.org; 11 Oct 2019 23:07:36 +0000 Original-Received: from localhost ([127.0.0.1]:60497 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iJ40V-0005oH-LU for submit@debbugs.gnu.org; Fri, 11 Oct 2019 19:07:35 -0400 Original-Received: from zimbra.cs.ucla.edu ([131.179.128.68]:41326) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iJ40T-0005o0-6l for 37659@debbugs.gnu.org; Fri, 11 Oct 2019 19:07:34 -0400 Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id DB625160661; Fri, 11 Oct 2019 16:07:26 -0700 (PDT) Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id Cyai6ERHVWge; Fri, 11 Oct 2019 16:07:26 -0700 (PDT) Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 3F595160662; Fri, 11 Oct 2019 16:07:26 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id ts_AVZHn4j4n; Fri, 11 Oct 2019 16:07:26 -0700 (PDT) Original-Received: from Penguin.CS.UCLA.EDU (Penguin.CS.UCLA.EDU [131.179.64.200]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 2535F160661; Fri, 11 Oct 2019 16:07:26 -0700 (PDT) Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:169015 Archived-At: Thanks for the proposed patch. Two thoughts: 1. Instead of the symbol 'unordered-or' (which is remarkably hard to=20 read), I suggest using the ASCII letter 'V'. This ASCIIfies the Unicode=20 symbol U+2228 LOGICAL OR (=E2=88=A8). If you prefer, you could make the U= nicode=20 symbol an alias for 'V', or use lower-case ASCII 'v', or whatever. The=20 point is that '(unordered-or A B)' is too hard to read with all those=20 'or's in there. 2. Re this patch: > - ((or 'anychar 'anything) (rx--translate-form '(or nonl "\n"))= ) > + ((or 'anychar 'anything) (cons (list "[^z-a]") t)) Is there a reason this uses (cons (list "[^z-a]") t) rather than=20 '(("[^z-a]") . t) ? I realize neighboring code does something similar,=20 but it's not clear to me why it's important to construct new objects=20 here instead of using literals.