unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Mauro Aranda <maurooaranda@gmail.com>
To: Stefan Kangas <stefankangas@gmail.com>, 42887@debbugs.gnu.org
Cc: luangruo@yahoo.com, Eli Zaretskii <eliz@gnu.org>,
	Lars Ingebrigtsen <larsi@gnus.org>,
	tsuucat@icloud.com
Subject: bug#42887: 28.0.50; Customize Group doesn't show/hide option on repeated clicking
Date: Mon, 11 Sep 2023 16:20:53 -0300	[thread overview]
Message-ID: <be020012-df5d-f17c-dc71-f8e92f01d3e6@gmail.com> (raw)
In-Reply-To: <CADwFkmkXJ9CB27xJoy8gRFTK9P6EfmBRor9PZYxG1oojS=SiFw@mail.gmail.com>

On 11/9/23 15:01, Stefan Kangas wrote:
 > Mauro Aranda <maurooaranda@gmail.com> writes:
 >
 >> I don't know why I couldn't reproduce it three years ago, but I managed
 >> to do that now, I think.
 >>
 >> Could you please check if the following change to
 >> widget-button-release-event-p fixes this for you?
 >>
 >> (defun widget-button-release-event-p (event)
 >>    "Non-nil if EVENT is a mouse-button-release event object."
 >>    (and (eventp event)
 >>         (memq (event-basic-type event) '(mouse-1 mouse-2 mouse-3))
 >>         (seq-some (lambda (el)
 >>                     (memq el '(click drag triple double)))
 >>                   (event-modifiers event))))
 >>
 >>
 >> Please do try it with mouse-1 and mouse-2 if you can.
 >>
 >> (I know that the mark gets set with repeating clicks with mouse-1,
 >> and there's a signal with mouse-2, but I'm focusing on whether this
 >> changes fixes the detection of repeated clicks)
 >
 > Thanks.
 >
 > I don't currently have convenient access to the machine where I can
 > reproduce this, and it will be at least another couple of weeks until I
 > do.  Apologies in advance if it takes a while before I can review this.

OK, no problem, of course.  There are other bugs to focus in the
meantime :-).

 > If someone else can reproduce and this patch fixes it for them, that
 > works too.

I see I failed to CC people that participated in this report. Sorry,
doing that now.  For reproducing, the recipe given by Stefan is pretty
good, but I would like to add that in my experience is better to make
the repeated clicks as if you wanted to double click, but maybe not so
fast.

Try to not move the mouse, and if the option doesn't toggle, wait.
There might be something in the echo area like:
double-down-mouse-1 double-mouse-1-






      reply	other threads:[~2023-09-11 19:20 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-16 14:02 bug#42887: 28.0.50; Customize Group doesn't show/hide option on repeated clicking Stefan Kangas
2020-08-16 14:51 ` Eli Zaretskii
2020-08-17 18:25   ` Stefan Kangas
2020-09-05 12:53 ` Mauro Aranda
2020-11-13 23:20   ` Stefan Kangas
2020-11-17 11:25     ` Mauro Aranda
2020-11-17 11:48       ` Stefan Kangas
2020-11-17 12:07         ` Mauro Aranda
2020-11-14  4:27 ` tsuucat via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-02-07  1:15 ` Lars Ingebrigtsen
2022-02-07  3:19   ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-02-07  3:42     ` Lars Ingebrigtsen
2022-05-26  5:50   ` Stefan Kangas
2022-05-26 11:03     ` Lars Ingebrigtsen
2023-09-11 13:34 ` Mauro Aranda
2023-09-11 18:01   ` Stefan Kangas
2023-09-11 19:20     ` Mauro Aranda [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=be020012-df5d-f17c-dc71-f8e92f01d3e6@gmail.com \
    --to=maurooaranda@gmail.com \
    --cc=42887@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    --cc=larsi@gnus.org \
    --cc=luangruo@yahoo.com \
    --cc=stefankangas@gmail.com \
    --cc=tsuucat@icloud.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).