From: Mauro Aranda <maurooaranda@gmail.com>
To: Stefan Kangas <stefan@marxist.se>
Cc: 42887@debbugs.gnu.org
Subject: bug#42887: 28.0.50; Customize Group doesn't show/hide option on repeated clicking
Date: Tue, 17 Nov 2020 09:07:28 -0300 [thread overview]
Message-ID: <CABczVwekFKMLt1z5WUbCpx=G08OCnKxRSQkH7ggXohO4q-+FVA@mail.gmail.com> (raw)
In-Reply-To: <CADwFkmntsyEC1qvBEsJwwTJJ8PfG8GzKT=jp1cFzgT6FV1msjg@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1972 bytes --]
Stefan Kangas <stefan@marxist.se> writes:
> Mauro Aranda <maurooaranda@gmail.com> writes:
>
>> Stefan Kangas <stefan@marxist.se> writes:
>>
>>> Mauro Aranda <maurooaranda@gmail.com> writes:
>>>
>>>> Only when I click "too fast" the option doesn't expand,
>>>
>>> That's different from what I'm seeing. I can wait several seconds
>>> between clicks, and as long as I don't move the mouse cursor the option
>>> won't expand.
>>
>> I think I misunderstood your recipe. Does an option that starts as
hidden
>> never expand for you in the recipe?
>
> No, it does expand on the first click.
>
> It will not expand on repeated clicks unless I move the mouse cursor
> between clicks. The delay does not matter (except if I click too fast I
> see double-click events).
Then I definitely can't reproduce this. Does it happen with mouse-1 and
mouse-2? I think you didn't mention that in your recipe.
> So I had a quick look, and the defun `custom-toggle-hide-variable' is
> called on the first click. The option then correctly expands.
>
> But that function is not called on subsequent clicks. After moving the
> mouse cursor and clicking, it seems to register again and
> `custom-toggle-hide-variable' is called.
custom-toggle-hide-variable is the :action function for the widget you
are clicking. It should be called if
widget-button--check-and-call-button detects a mouse-1 or mouse-2 event
at that widget. AFAIK, there are 2 reasons why it doesn't
call the :action function: either it gets a mouse-1 event and then a
mouse-movement event, returning t, or it doesn't think the button where
the mouse click ended is the same button where the mouse click started.
I.e., this evaluates to nil:
(and pos (eq (get-char-property pos 'button) button))
In this case, widget-button--check-and-call-button will return nil.
I suspect the former happens and not the latter, but I can't be sure.
Maybe you can test what's the return value of
widget-button--check-and-call-button.
[-- Attachment #2: Type: text/html, Size: 2534 bytes --]
next prev parent reply other threads:[~2020-11-17 12:07 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-16 14:02 bug#42887: 28.0.50; Customize Group doesn't show/hide option on repeated clicking Stefan Kangas
2020-08-16 14:51 ` Eli Zaretskii
2020-08-17 18:25 ` Stefan Kangas
2020-09-05 12:53 ` Mauro Aranda
2020-11-13 23:20 ` Stefan Kangas
2020-11-17 11:25 ` Mauro Aranda
2020-11-17 11:48 ` Stefan Kangas
2020-11-17 12:07 ` Mauro Aranda [this message]
2020-11-14 4:27 ` tsuucat via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-02-07 1:15 ` Lars Ingebrigtsen
2022-02-07 3:19 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-02-07 3:42 ` Lars Ingebrigtsen
2022-05-26 5:50 ` Stefan Kangas
2022-05-26 11:03 ` Lars Ingebrigtsen
2023-09-11 13:34 ` Mauro Aranda
2023-09-11 18:01 ` Stefan Kangas
2023-09-11 19:20 ` Mauro Aranda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CABczVwekFKMLt1z5WUbCpx=G08OCnKxRSQkH7ggXohO4q-+FVA@mail.gmail.com' \
--to=maurooaranda@gmail.com \
--cc=42887@debbugs.gnu.org \
--cc=stefan@marxist.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).