unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
* bug#38397: 27.0.50; [PATCH] vc-hg: log incoming/outgoing must call vc-setup-buffer
@ 2019-11-27  7:04 Andrii Kolomoiets
  2019-11-27 12:17 ` Dmitry Gutov
  0 siblings, 1 reply; 2+ messages in thread
From: Andrii Kolomoiets @ 2019-11-27  7:04 UTC (permalink / raw)
  To: 38397

1. emacs -Q
2. 'C-x v d' and open hg repository directory
3. 'I' to open incoming log
4. 'g' to revert *vc-incoming* buffer

Output is added to buffer content instead of replacing it.
Same with outgoing log.

vc-hg-log-incoming and vc-hg-log-outgoing must call vc-setup-buffer

* lisp/vc/vc-hg.el (vc-hg-log-incoming, vc-hg-log-outgoing): Call
  vc-setup-buffer.

diff --git a/lisp/vc/vc-hg.el b/lisp/vc/vc-hg.el
index 17d38fa400..5ff1a6204b 100644
--- a/lisp/vc/vc-hg.el
+++ b/lisp/vc/vc-hg.el
@@ -1378,10 +1378,12 @@ vc-hg-dir-extra-headers
      )))

(defun vc-hg-log-incoming (buffer remote-location)
+  (vc-setup-buffer buffer)
   (vc-hg-command buffer 1 nil "incoming" "-n" (unless (string= remote-location "")
                                                remote-location)))

(defun vc-hg-log-outgoing (buffer remote-location)
+  (vc-setup-buffer buffer)
   (vc-hg-command buffer 1 nil "outgoing" "-n" (unless (string= remote-location "")
                                                remote-location)))




^ permalink raw reply related	[flat|nested] 2+ messages in thread

* bug#38397: 27.0.50; [PATCH] vc-hg: log incoming/outgoing must call vc-setup-buffer
  2019-11-27  7:04 bug#38397: 27.0.50; [PATCH] vc-hg: log incoming/outgoing must call vc-setup-buffer Andrii Kolomoiets
@ 2019-11-27 12:17 ` Dmitry Gutov
  0 siblings, 0 replies; 2+ messages in thread
From: Dmitry Gutov @ 2019-11-27 12:17 UTC (permalink / raw)
  To: Andrii Kolomoiets, 38397-done

On 27.11.2019 9:04, Andrii Kolomoiets wrote:
> 1. emacs -Q
> 2. 'C-x v d' and open hg repository directory
> 3. 'I' to open incoming log
> 4. 'g' to revert *vc-incoming* buffer
> 
> Output is added to buffer content instead of replacing it.
> Same with outgoing log.
> 
> vc-hg-log-incoming and vc-hg-log-outgoing must call vc-setup-buffer
> 
> * lisp/vc/vc-hg.el (vc-hg-log-incoming, vc-hg-log-outgoing): Call
>    vc-setup-buffer.

Thanks, installed (e7b4c248a6). But please send patches as attachments. 
I had to make all the changes my hand this time.

Also see the changes in the commit message.





^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-11-27 12:17 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-27  7:04 bug#38397: 27.0.50; [PATCH] vc-hg: log incoming/outgoing must call vc-setup-buffer Andrii Kolomoiets
2019-11-27 12:17 ` Dmitry Gutov

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).