From: martin rudalics <rudalics@gmx.at>
To: Eli Zaretskii <eliz@gnu.org>
Cc: acm@muc.de, 51590@debbugs.gnu.org, juri@linkov.net
Subject: bug#51590: follow-mode is broken with header-line and tab-line
Date: Tue, 9 Nov 2021 11:14:07 +0100 [thread overview]
Message-ID: <bbd5bd83-940e-7dbd-2ede-d8b0104ae7ea@gmx.at> (raw)
In-Reply-To: <834k8m7adu.fsf@gnu.org>
>> But
>>
>> (posn-area (posn-at-x-y 0 (window-body-height nil t)))
>>
>> gives me 'mode-line' here which is wrong since, according to your new
>> definition, the mode line is _not_ part of the text area.
>
> "Wrong" why, because the doc string of window-body-height mentions the
> text area? Or for some other reason?
If you had answered my question
How would your book describe the text area? A T-shaped area comprising
the window's body, its header and tab line? What would be the width of
that area? Why would it exclude the mode line?
I would be able to tell. A definition like
The @dfn{text area} of the window includes
the header line and the tab line, if they are present in the window.
does _not_ define what the text area is.
> And, btw, why do you use (window-body-height nil t) instead of
> (1- (window-body-height nil t)) ? The last pixel of the window's body
> has Y coordinate (1- (window-body-height nil t)), no?
Right. I wanted to be below the body.
>> And with a bottom divider
>>
>> (posn-area (posn-at-x-y 0 (1- (window-pixel-height))))
>>
>> gets me 'bottom-divider'.
>
> And that is wrong why?
See above.
>> So I'd suggest to revert your changes wrt the text area.
>
> I wrote in another message what I'd like to do with "text area" in doc
> strings. Given that they will disappear from the doc strings, what
> other problems do you see?
That the manual still defines the "text area" and now even in a form
that lets me only guess what it is.
>> (posn-area (posn-at-x-y (1- (window-pixel-width)) 0))
>>
>> currently gives 'nil' regardless of whether it's done with a header or
>> tab line
>
> Isn't that because window-pixel-width includes the fringes?
The header line doesn't have any fringes.
>> and
>>
>> (posn-area (posn-at-x-y
>> (1- (window-pixel-width))
>> (1- (window-pixel-height))))
>>
>> gives 'nil' on the mode line. Only when I remove _both_ fringes and the
>> vertical scroll bar I get the expected results. This _is_ a bug and we
>> should fix it.
>
> I don't think it's a bug, because window-pixel-height includes the
> fringes, according to its doc string. Try
>
> (posn-area (posn-at-x-y
> (- (window-pixel-width) 9)
> (1- (window-pixel-height))))
The mode line doesn't have any fringes either.
martin
next prev parent reply other threads:[~2021-11-09 10:14 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-03 18:24 bug#51590: Tab-line breaks windows of follow-mode Juri Linkov
2021-11-03 18:35 ` Eli Zaretskii
2021-11-04 17:29 ` bug#51590: follow-mode is broken with header-line and tab-line Juri Linkov
2021-11-04 18:46 ` Eli Zaretskii
2021-11-04 19:06 ` Alan Mackenzie
2021-11-05 21:45 ` Alan Mackenzie
2021-11-06 7:00 ` Eli Zaretskii
2021-11-06 11:50 ` Alan Mackenzie
2021-11-06 12:12 ` Eli Zaretskii
2021-11-06 18:31 ` martin rudalics
2021-11-06 18:40 ` Eli Zaretskii
2021-11-08 15:36 ` martin rudalics
2021-11-08 17:32 ` martin rudalics
2021-11-08 18:47 ` Eli Zaretskii
2021-11-09 10:14 ` martin rudalics [this message]
2021-11-06 18:44 ` martin rudalics
2021-11-08 17:59 ` Alan Mackenzie
2021-11-08 18:23 ` Eli Zaretskii
2021-11-09 10:12 ` martin rudalics
2021-11-09 10:10 ` martin rudalics
2021-11-04 18:52 ` martin rudalics
2021-11-07 12:48 ` Alan Mackenzie
2021-11-07 13:14 ` Eli Zaretskii
2021-11-07 14:28 ` Alan Mackenzie
2021-11-07 17:46 ` Juri Linkov
2021-11-07 19:44 ` Alan Mackenzie
2021-11-07 19:56 ` Juri Linkov
2021-11-08 7:13 ` Alan Mackenzie
2021-11-05 7:42 ` Stefan Kangas
2021-11-05 8:55 ` Juri Linkov
2021-11-05 10:15 ` Stefan Kangas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bbd5bd83-940e-7dbd-2ede-d8b0104ae7ea@gmx.at \
--to=rudalics@gmx.at \
--cc=51590@debbugs.gnu.org \
--cc=acm@muc.de \
--cc=eliz@gnu.org \
--cc=juri@linkov.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).