unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: martin rudalics <rudalics@gmx.at>
To: Eli Zaretskii <eliz@gnu.org>, Alan Mackenzie <acm@muc.de>
Cc: 51590@debbugs.gnu.org, juri@linkov.net
Subject: bug#51590: follow-mode is broken with header-line and tab-line
Date: Tue, 9 Nov 2021 11:12:18 +0100	[thread overview]
Message-ID: <789ce592-f432-c92c-9e3c-bb1eace601ad@gmx.at> (raw)
In-Reply-To: <837ddi7bhm.fsf@gnu.org>

 > I would like to stop using "text area" in the doc strings and the user
 > manual.

OK.  But can we do that on the development branch please?  I recently
spent some time rewriting the window chapter in the Elisp manual and
just do not feel confident enough to install the necessary changes in a
safe manner on the release branch soon.

 > It is a confusing term, more so for me, because it has a very
 > specific meaning in the display code.

While a comment like

/* Return the window-relative coordinate of the right edge of display
    area AREA of window W.  ANY_AREA means return the right edge of the
    whole window, to the left of the right fringe of W.  */

may look entirely clear to you, it doesn't to me.  So maybe we could try
to first say what

- a "display area" of a window is and where its "right edge" is located,

- what a "window-relative coordinate" is,

- what the "right edge of the whole window" is, and

- what "left of the right fringe of W" stands for in the presence of
   fringes in and outside of margins or a scroll bar on the left.

Next we could try fixing things like

     int text_area_x, text_area_y, text_area_width, text_area_height;

     window_box (w, TEXT_AREA, &text_area_x, &text_area_y, &text_area_width,
		&text_area_height);

in frame.c and

   int text_area_x, text_area_y, text_area_width, text_area_height;

   window_box (s->w, TEXT_AREA, &text_area_x, &text_area_y,
               &text_area_width, &text_area_height);

in xwidget.c if we want to say that the box size of a window is not the
same as the size of its text area (deduced from you earlier comment).

 > So from my POV, the ideal solution is to go through all of those
 > places and replace "text area" with "window body" (and if the latter
 > is already there, just delete the former).

Agreed.  But after the release, pretty please.

martin





  reply	other threads:[~2021-11-09 10:12 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-03 18:24 bug#51590: Tab-line breaks windows of follow-mode Juri Linkov
2021-11-03 18:35 ` Eli Zaretskii
2021-11-04 17:29   ` bug#51590: follow-mode is broken with header-line and tab-line Juri Linkov
2021-11-04 18:46     ` Eli Zaretskii
2021-11-04 19:06       ` Alan Mackenzie
2021-11-05 21:45       ` Alan Mackenzie
2021-11-06  7:00         ` Eli Zaretskii
2021-11-06 11:50           ` Alan Mackenzie
2021-11-06 12:12             ` Eli Zaretskii
2021-11-06 18:31               ` martin rudalics
2021-11-06 18:40                 ` Eli Zaretskii
2021-11-08 15:36                   ` martin rudalics
2021-11-08 17:32                     ` martin rudalics
2021-11-08 18:47                     ` Eli Zaretskii
2021-11-09 10:14                       ` martin rudalics
2021-11-06 18:44                 ` martin rudalics
2021-11-08 17:59               ` Alan Mackenzie
2021-11-08 18:23                 ` Eli Zaretskii
2021-11-09 10:12                   ` martin rudalics [this message]
2021-11-09 10:10                 ` martin rudalics
2021-11-04 18:52     ` martin rudalics
2021-11-07 12:48     ` Alan Mackenzie
2021-11-07 13:14       ` Eli Zaretskii
2021-11-07 14:28         ` Alan Mackenzie
2021-11-07 17:46       ` Juri Linkov
2021-11-07 19:44         ` Alan Mackenzie
2021-11-07 19:56           ` Juri Linkov
2021-11-08  7:13             ` Alan Mackenzie
2021-11-05  7:42 ` Stefan Kangas
2021-11-05  8:55   ` Juri Linkov
2021-11-05 10:15     ` Stefan Kangas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=789ce592-f432-c92c-9e3c-bb1eace601ad@gmx.at \
    --to=rudalics@gmx.at \
    --cc=51590@debbugs.gnu.org \
    --cc=acm@muc.de \
    --cc=eliz@gnu.org \
    --cc=juri@linkov.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).