unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: martin rudalics <rudalics@gmx.at>
To: Eli Zaretskii <eliz@gnu.org>,
	"Basil L. Contovounesios" <contovob@tcd.ie>
Cc: 46509@debbugs.gnu.org
Subject: bug#46509: 28.0.50; Unused static function in xfns.c with GTK2
Date: Sun, 14 Feb 2021 18:17:00 +0100	[thread overview]
Message-ID: <b1b47883-79d6-7195-7d7a-fc382344f82e@gmx.at> (raw)
In-Reply-To: <83im6ubppx.fsf@gnu.org>

>> Its definition is conditional on !USE_GTK || !HAVE_GTK3, but its use
>> only on !USE_GTK.  Which one is right?
>
> The !USE_GTK one, I think.

It's a tad more complicated.  You have to do something like the below.

martin

diff --git a/src/xfns.c b/src/xfns.c
index 481ee0e225..82424ae080 100644
--- a/src/xfns.c
+++ b/src/xfns.c
@@ -4663,6 +4663,9 @@ x_get_net_workarea (struct x_display_info *dpyinfo, XRectangle *rect)
    return result;
  }

+#endif /* !defined USE_GTK || !defined HAVE_GTK3 */
+#if !defined USE_GTK
+
  /* Return monitor number where F is "most" or closest to.  */
  static int
  x_get_monitor_for_frame (struct frame *f,






  reply	other threads:[~2021-02-14 17:17 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-14 13:34 bug#46509: 28.0.50; Unused static function in xfns.c with GTK2 Basil L. Contovounesios
2021-02-14 16:04 ` Eli Zaretskii
2021-02-14 17:17   ` martin rudalics [this message]
2021-02-14 17:44     ` Basil L. Contovounesios
2021-02-15  8:15       ` martin rudalics
2021-02-15  9:15         ` Basil L. Contovounesios
2021-02-15 10:05           ` martin rudalics
2021-02-15 10:24             ` Robert Pluim
2021-02-15 11:42               ` Basil L. Contovounesios
2021-02-16  9:29                 ` martin rudalics
2021-02-16 16:51                   ` Basil L. Contovounesios

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b1b47883-79d6-7195-7d7a-fc382344f82e@gmx.at \
    --to=rudalics@gmx.at \
    --cc=46509@debbugs.gnu.org \
    --cc=contovob@tcd.ie \
    --cc=eliz@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).