From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: martin rudalics Newsgroups: gmane.emacs.bugs Subject: bug#46509: 28.0.50; Unused static function in xfns.c with GTK2 Date: Sun, 14 Feb 2021 18:17:00 +0100 Message-ID: References: <87y2fqu616.fsf@tcd.ie> <83im6ubppx.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23392"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 46509@debbugs.gnu.org To: Eli Zaretskii , "Basil L. Contovounesios" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Feb 14 18:19:09 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lBL36-00060m-Lz for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 14 Feb 2021 18:19:08 +0100 Original-Received: from localhost ([::1]:49768 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lBL35-0001xB-Mx for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 14 Feb 2021 12:19:07 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:54278) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lBL22-0001Dr-TE for bug-gnu-emacs@gnu.org; Sun, 14 Feb 2021 12:18:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:53318) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lBL22-0007DX-Ki for bug-gnu-emacs@gnu.org; Sun, 14 Feb 2021 12:18:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lBL22-0007ot-HA for bug-gnu-emacs@gnu.org; Sun, 14 Feb 2021 12:18:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: martin rudalics Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 14 Feb 2021 17:18:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 46509 X-GNU-PR-Package: emacs Original-Received: via spool by 46509-submit@debbugs.gnu.org id=B46509.161332303229998 (code B ref 46509); Sun, 14 Feb 2021 17:18:02 +0000 Original-Received: (at 46509) by debbugs.gnu.org; 14 Feb 2021 17:17:12 +0000 Original-Received: from localhost ([127.0.0.1]:36631 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lBL1D-0007nm-MS for submit@debbugs.gnu.org; Sun, 14 Feb 2021 12:17:11 -0500 Original-Received: from mout.gmx.net ([212.227.17.22]:49309) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lBL1C-0007nZ-Qn for 46509@debbugs.gnu.org; Sun, 14 Feb 2021 12:17:11 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1613323022; bh=X4ZGMb3MSpWpSIWMC+jMG6SnoJLSiDlRH0RqLohPjDI=; h=X-UI-Sender-Class:Subject:To:Cc:References:From:Date:In-Reply-To; b=jVSmYyuF85R7Y+VldBx4rcgWqc1EOKMWNR6ZsEoJywFkNYBT8LK53ONFs3Kvtv+7Y FqQSxsZqocaSTPduQmFLNdoqULlUBgG8yLtvh9sy2w7M4COKb2GoSNgUteDlJ+buZR kx91b+LcOLaeqVj4zNOiK21l8xJVlhKNUQcDdUxo= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Original-Received: from [192.168.1.103] ([46.125.249.43]) by mail.gmx.net (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1Mt757-1lzig30KEL-00tW2l; Sun, 14 Feb 2021 18:17:02 +0100 In-Reply-To: <83im6ubppx.fsf@gnu.org> Content-Language: en-US X-Provags-ID: V03:K1:U5FJjv0ZNaa0yo8VGbqFZNrBmXxe2xrdtjBBEXM2wZYACX0I/v8 NohkXL3SXNeNkXjPHQiqQ4MeCr68uOvXUowR0hbAFKWgq0RZjjzVl1dAvti1JulrRlbVY/C nV7griibi3E7vbHUBEKiZ9ENbuKRad6EUvIEHyJgcKOSQF89TZ9GxitZouJWmTXsyNiWGsR R6TDoFy6VIwfUE7rKXcIA== X-UI-Out-Filterresults: notjunk:1;V03:K0:ebtsHiNpFcc=:BXE80GqWkwde8rlXhSNFb5 g3lSB/rsK+6MtnQ/b90bFt1bqm4IT7JnkO/G7+sSkxGG/B3jcbXcAzg8sO5scr1TTTCAhm/n9 JO/o90Ekt+kCIdyYpv19cs6icXRlCD72eMe/b5LAbCOWOddnnj7HZrwIJJh7wJfjqt6HddgtP PRP70+XPHrQP65DFN+Od/5IWM6EquTXlwHVmoBXqw5cOYGU+FFJVMK7BccEiMTHg0UWyNiBfT Rk8Q8FUEuCZPVyD9/qQCldlvdngfikUVn5emsqsL0W0JTQ4tzQjrp137IM5kJDjuK8M+3D/kC ebuA6lb1VbXjBvvAh3PWKO2Ss1q96M6381RLV+B81PDPSCpAueJmec2D4eHIG6/J0uh0Tgbw3 scwjYsqOFtF/xvCDcZAM4izvcyoeShTJK8AiGXoT8iu+OcGeUiROaIPuS61EBNLKMbHu67TFD m6p3p/7RSLy57DGhDtfwVM0xl/PfhVRuBEBg96U1JJBo2nypZPFGwidCqL2XxYZQ4UsovYnm/ yxVQrM7vlQqxdwjZAcPDgQT1RtYI7xP/t3fb+Er9jv97O2qaicy1tFNuZerFfhfxFEnwJu9AI FoTqpfeQr30bIsiN9F1tXhIufSu7JW85c1Y7AXFta+8OAcmy179n0o+YCF3LCbDT1OnQuI5D5 llenBMuP+savVy/NZvlyOmMSOr4DThz+QLCy47nCEs5bfaI3c7D52TN4mDiZgDN0zw1qs9JBg CXRtcTNY1FZ+/muzmVRapLLGI0k8qjjCO4pgFERw7txI52XsCjb13FsV4Jfsfjo/Lip2Bs5C X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:200018 Archived-At: >> Its definition is conditional on !USE_GTK || !HAVE_GTK3, but its use >> only on !USE_GTK. Which one is right? > > The !USE_GTK one, I think. It's a tad more complicated. You have to do something like the below. martin diff --git a/src/xfns.c b/src/xfns.c index 481ee0e225..82424ae080 100644 =2D-- a/src/xfns.c +++ b/src/xfns.c @@ -4663,6 +4663,9 @@ x_get_net_workarea (struct x_display_info *dpyinfo, = XRectangle *rect) return result; } +#endif /* !defined USE_GTK || !defined HAVE_GTK3 */ +#if !defined USE_GTK + /* Return monitor number where F is "most" or closest to. */ static int x_get_monitor_for_frame (struct frame *f,