bug#4589: 23.1; ERC reconnection -vs- /disconnect

bug#4589: 23.1; ERC reconnection -vs- /disconnect

[Tom Tromey]

Please write in English if possible, because the Emacs maintainers
usually do not have translators to read other languages for them.

Your bug report will be posted to the bug-gnu-emacs@gnu.org mailing list,
and to the gnu.emacs.bug news group.

Please describe exactly what actions triggered the bug
and the precise symptoms of the bug:


One irc server I use went down and was unavailable.
ERC kept trying to reconnect to it -- which is nice, ordinarily I want
this.
However, in this case, I wanted to prevent ERC from trying to reconnect.

So, I went to the server buffer and typed /disconnect.
This did not work, instead ERC gave me an error message
(which I no longer have but the gist was that there was no connection).

I think /disconnect should work to prevent reconnection in this
situation.
Instead, the only solution I found was to kill the server buffer.


If Emacs crashed, and you have the Emacs process in the gdb debugger,
please include the output from the following gdb commands:
    `bt full' and `xbacktrace'.
If you would like to further debug the crash, please read the file
/usr/share/emacs/23.1/etc/DEBUG for instructions.


In GNU Emacs 23.1.1 (i386-redhat-linux-gnu, GTK+ Version 2.16.5)
 of 2009-08-26 on x86-2.fedora.phx.redhat.com
Windowing system distributor `The X.Org Foundation', version 11.0.10601901
configured using `configure  '--build=i386-redhat-linux-gnu' '--host=i386-redhat-linux-gnu' '--target=i586-redhat-linux-gnu' '--program-prefix=' '--prefix=/usr' '--exec-prefix=/usr' '--bindir=/usr/bin' '--sbindir=/usr/sbin' '--sysconfdir=/etc' '--datadir=/usr/share' '--includedir=/usr/include' '--libdir=/usr/lib' '--libexecdir=/usr/libexec' '--localstatedir=/var' '--sharedstatedir=/var/lib' '--mandir=/usr/share/man' '--infodir=/usr/share/info' '--with-dbus' '--with-gif' '--with-jpeg' '--with-png' '--with-rsvg' '--with-tiff' '--with-xft' '--with-xpm' '--with-x-toolkit=gtk' 'build_alias=i386-redhat-linux-gnu' 'host_alias=i386-redhat-linux-gnu' 'target_alias=i586-redhat-linux-gnu' 'CFLAGS=-DMAIL_USE_LOCKF -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-bu
 ffer-size=4 -m32 -march=i586 -mtune=generic -fasynchronous-unwind-tables''

Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: en_US.UTF-8
  value of $XMODIFIERS: nil
  locale-coding-system: utf-8-unix
  default-enable-multibyte-characters: t

Major mode: Group

Minor modes in effect:
  erc-list-mode: t
  erc-menu-mode: t
  erc-autojoin-mode: t
  erc-ring-mode: t
  erc-pcomplete-mode: t
  erc-track-mode: t
  erc-track-minor-mode: t
  erc-match-mode: t
  erc-button-mode: t
  erc-fill-mode: t
  erc-stamp-mode: t
  erc-netsplit-mode: t
  erc-spelling-mode: t
  erc-truncate-mode: t
  shell-dirtrack-mode: t
  diff-auto-refine-mode: t
  gnus-undo-mode: t
  erc-status-mode: t
  erc-services-mode: t
  erc-networks-mode: t
  erc-irccontrols-mode: t
  erc-noncommands-mode: t
  erc-move-to-prompt-mode: t
  erc-readonly-mode: t
  tooltip-mode: t
  mouse-wheel-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  global-auto-composition-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  line-number-mode: t
  transient-mark-mode: t

Recent input:
j M-/ <backspace> e c t - g e t M-b <backspace> _ C-e 
M-/ ) , SPC a s SPC t h a t SPC i s SPC m o r e SPC 
c o n s i s t e n t SPC w i t h SPC o u r SPC g e n 
e r a l SPC <M-backspace> <M-backspace> o u r SPC c 
u r r e n t SPC A P I SPC d e c i s i o n s . <return> 
<return> F i n a l l y , SPC C-z o C-x C-f <M-backspace> 
d o c / g d b . t <tab> <return> C-s I n f e r i o 
r T h r e a d C-s C-a C-l C-v C-l C-z o t h i s SPC 
p a t c h SPC n e e d s SPC a n SPC u p d a t e SPC 
t o SPC g d b <M-backspace> d o c / g d b . t e x i 
n f o . <return> W e ' r e SPC C-a C-k I ' m SPC t 
r y i n g SPC t o SPC s C-a C-k C-k C-f C-o t h a n 
k s , C-a C-z o C-x k <return> C-x k <return> C-z o 
C-c C-c E C-z o <f10> <f10> <f10> <f10> M-v M-> d i 
s t r o s SPC a l C-a C-k <f10> <f10> <f10> <switch-frame> 
<switch-frame> C-z n E = C-l M-v M-v M-v C-z o C-z 
o C-l C-z o <f10> C-c b C-z o q s M-x r e p o r t - 
e <tab> <return> b <tab> <return>

Recent messages:
Deleting article 4574 in mail.frysk
Deleting article 4576 in mail.frysk
Deleting article 4578 in mail.frysk
Expiring articles...done
(No changes need to be saved)
Saving /home/tromey/.newsrc.eld...
Saving file /home/tromey/.newsrc.eld...
Wrote /home/tromey/.newsrc.eld
Saving /home/tromey/.newsrc.eld...done
Making completion list...

Tom

bug#4589: 23.1; ERC reconnection -vs- /disconnect

[Vivek Dasmohapatra]

[-- Attachment #1: Type: TEXT/PLAIN, Size: 467 bytes --]

Tags: patch

Note: There is no "/disconnect" command, but:
       "/quit",  "/exit" and "/bye" should all work.

You should also note that the reconnect loop isn't actually supposed
to be infinite, the default config _should_ stop after two tries, but
that is addressed in a separate patch in bug #4048

In any case, regardless of the number of attempts configured, issuing
an explicit quit with this patch applied should put a stop to further
[automatic] attempts.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Type: TEXT/x-diff; name=0001-If-the-user-has-issued-an-explicit-quit-reconnect-p-.patch, Size: 2215 bytes --]

diff --git a/lisp/erc/erc-backend.el b/lisp/erc/erc-backend.el
--- a/lisp/erc/erc-backend.el
+++ b/lisp/erc/erc-backend.el
@@ -579,20 +579,22 @@ Make sure you are in an ERC buffer when running this."
 (defsubst erc-server-reconnect-p (event)
   "Return non-nil if ERC should attempt to reconnect automatically.
 EVENT is the message received from the closed connection process."
-  (or erc-server-reconnecting
-      (and erc-server-auto-reconnect
-           (not erc-server-banned)
-           (not erc-server-error-occurred)
-           ;; make sure we don't infinitely try to reconnect, unless the
-           ;; user wants that
-           (or (eq erc-server-reconnect-attempts t)
-               (and (integerp erc-server-reconnect-attempts)
-                    (< erc-server-reconnect-count
-                       erc-server-reconnect-attempts)))
-           (or erc-server-timed-out
-               (not (string-match "^deleted" event)))
-           ;; open-network-stream-nowait error for connection refused
-           (not (string-match "^failed with code 111" event)))))
+  (and (not erc-server-quitting)   ;; user issued an explicit quit, give up now
+       (or erc-server-reconnecting ;; user issued explicit reconnect
+           ;; otherwise go through the full spectrum of checks:
+           (and erc-server-auto-reconnect
+                (not erc-server-banned)
+                (not erc-server-error-occurred)
+                ;; make sure we don't infinitely try to reconnect, unless the
+                ;; user wants that
+                (or (eq erc-server-reconnect-attempts t)
+                    (and (integerp erc-server-reconnect-attempts)
+                         (< erc-server-reconnect-count
+                            erc-server-reconnect-attempts)))
+                (or erc-server-timed-out
+                    (not (string-match "^deleted" event)))
+                ;; open-network-stream-nowait error for connection refused
+                (not (string-match "^failed with code 111" event))))))
 
 (defun erc-process-sentinel-2 (event buffer)
   "Called when `erc-process-sentinel-1' has detected an unexpected disconnect."

bug#4589: 23.1; ERC reconnection -vs- /disconnect

[Lars Ingebrigtsen]

Vivek Dasmohapatra <vivek@etla.org> writes:

> Note: There is no "/disconnect" command, but:
>       "/quit",  "/exit" and "/bye" should all work.
>
> You should also note that the reconnect loop isn't actually supposed
> to be infinite, the default config _should_ stop after two tries, but
> that is addressed in a separate patch in bug #4048
>
> In any case, regardless of the number of attempts configured, issuing
> an explicit quit with this patch applied should put a stop to further
> [automatic] attempts.

Thanks for the patch; it's applied to the Emacs trunk now.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#4589: 23.1; ERC reconnection -vs- /disconnect

[Chong Yidong]

Hi Michael,

Could you take a look at this bug report?  Thanks.

(There are a few more bug reports for ERC in the bug tracker; if you
have the time, could you please take a look at them too?  Thanks.)


Tom Tromey <tromey@redhat.com> wrote:

> One irc server I use went down and was unavailable.  ERC kept trying
> to reconnect to it -- which is nice, ordinarily I want this.  However,
> in this case, I wanted to prevent ERC from trying to reconnect.
>
> So, I went to the server buffer and typed /disconnect.  This did not
> work, instead ERC gave me an error message (which I no longer have but
> the gist was that there was no connection).
>
> I think /disconnect should work to prevent reconnection in this
> situation.  Instead, the only solution I found was to kill the server
> buffer.

bug#4589: 23.1; ERC reconnection -vs- /disconnect

[Michael Olson]

Forwarding to Giorgos, who will be taking over as ERC maintainer
shortly.   Can you pass on the details of how to access ERC-related
bugs in the Emacs bugtracker?

On Sat, Nov 7, 2009 at 9:40 PM, Chong Yidong <cyd@stupidchicken.com> wrote:
> Hi Michael,
>
> Could you take a look at this bug report?  Thanks.
>
> (There are a few more bug reports for ERC in the bug tracker; if you
> have the time, could you please take a look at them too?  Thanks.)
>
>
> Tom Tromey <tromey@redhat.com> wrote:
>
>> One irc server I use went down and was unavailable.  ERC kept trying
>> to reconnect to it -- which is nice, ordinarily I want this.  However,
>> in this case, I wanted to prevent ERC from trying to reconnect.
>>
>> So, I went to the server buffer and typed /disconnect.  This did not
>> work, instead ERC gave me an error message (which I no longer have but
>> the gist was that there was no connection).
>>
>> I think /disconnect should work to prevent reconnection in this
>> situation.  Instead, the only solution I found was to kill the server
>> buffer.
>
>



-- 
Michael Olson  ||  http://mwolson.org/
Projects: Emacs, Muse, EMMS

bug#4589: 23.1; ERC reconnection -vs- /disconnect

[Chong Yidong]

Michael Olson <mwolson@gnu.org> writes:

> Can you pass on the details of how to access ERC-related bugs in the
> Emacs bugtracker?

You can go to

http://emacsbugs.donarmstrong.com/cgi-bin/pkgreport.cgi?which=pkg&data=erc&archive=no&version=&dist=unstable

bug#4589: 23.1; ERC reconnection -vs- /disconnect

[Giorgos Keramidas]

On Mon, 09 Nov 2009 12:32:02 -0500, Chong Yidong <cyd@stupidchicken.com> wrote:
> Michael Olson <mwolson@gnu.org> writes:
>
>> Can you pass on the details of how to access ERC-related bugs in the
>> Emacs bugtracker?
>
> You can go to
>
> http://emacsbugs.donarmstrong.com/cgi-bin/pkgreport.cgi?which=pkg&data=erc&archive=no&version=&dist=unstable

Thanks!  I see that trimming the 'unstable' bit from the URL reports
more bugs:

  http://emacsbugs.donarmstrong.com/cgi-bin/pkgreport.cgi?which=pkg&data=erc&archive=no

I bookmarked both URIs and will have a look at the open bugs.

My experience with `emacsbugs.donarmstrong.com' is very limited, so if
we also have some sort of HOWTO or mini-guide for the tracker, please
point it me to that and I will read it to get acquainted with how bugs
are handled.

bug#4589: 23.1; ERC reconnection -vs- /disconnect

[Glenn Morris]

Giorgos Keramidas wrote:

> My experience with `emacsbugs.donarmstrong.com' is very limited, so if
> we also have some sort of HOWTO or mini-guide for the tracker, please
> point it me to that and I will read it to get acquainted with how bugs
> are handled.

In Emacs CVS: admin/notes/bugtracker