unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Jim Porter <jporterbugs@gmail.com>
To: Brian Cully <bjc@spork.org>, Eli Zaretskii <eliz@gnu.org>
Cc: 58899@debbugs.gnu.org
Subject: bug#58899: [PATCH v1] Add the "doas" alias to eshell.
Date: Thu, 3 Nov 2022 10:09:44 -0700	[thread overview]
Message-ID: <af90a495-0315-864a-131c-679321524d1e@gmail.com> (raw)
In-Reply-To: <87k04f3kzf.fsf@ditto.jhoto.spork.org>

On 10/31/2022 11:29 AM, Brian Cully via Bug reports for GNU Emacs, the 
Swiss army knife of text editors wrote:
> Fixed.

I took a look at these patches and they all look good to me[1], aside 
from one minor nitpick: could you wrap the new tests at 80 columns? It 
makes the code easier to read for people like me who have several 
80-column windows side-by-side. :)

[1] I haven't applied them locally to test, though.





  reply	other threads:[~2022-11-03 17:09 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-30 16:42 bug#58899: [PATCH v1] Add the "doas" alias to eshell Brian Cully via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-10-30 21:51 ` Jim Porter
2022-10-30 22:06   ` Jim Porter
2022-10-31 12:36     ` Eli Zaretskii
2022-10-31  8:16   ` Michael Albinus
2022-10-31 16:01   ` Brian Cully via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-10-31 18:01     ` Eli Zaretskii
2022-10-31 18:29       ` Brian Cully via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-11-03 17:09         ` Jim Porter [this message]
2022-11-03 20:24           ` Brian Cully via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-11-05 19:10             ` Jim Porter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=af90a495-0315-864a-131c-679321524d1e@gmail.com \
    --to=jporterbugs@gmail.com \
    --cc=58899@debbugs.gnu.org \
    --cc=bjc@spork.org \
    --cc=eliz@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).