From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jim Porter Newsgroups: gmane.emacs.bugs Subject: bug#58899: [PATCH v1] Add the "doas" alias to eshell. Date: Thu, 3 Nov 2022 10:09:44 -0700 Message-ID: References: <87pme92rge.fsf@ditto.jhoto.spork.org> <286825e7-2dc2-9cc7-73a3-1056a249d56f@gmail.com> <87mt9c2d90.fsf@ditto.jhoto.spork.org> <83k04feutc.fsf@gnu.org> <87k04f3kzf.fsf@ditto.jhoto.spork.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26713"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 58899@debbugs.gnu.org To: Brian Cully , Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Nov 03 18:10:39 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oqdjj-0006lV-Cj for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 03 Nov 2022 18:10:39 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oqdjA-0002eN-Da; Thu, 03 Nov 2022 13:10:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oqdj8-0002eA-MJ for bug-gnu-emacs@gnu.org; Thu, 03 Nov 2022 13:10:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oqdj8-0000AK-Df for bug-gnu-emacs@gnu.org; Thu, 03 Nov 2022 13:10:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oqdj8-0006or-5o for bug-gnu-emacs@gnu.org; Thu, 03 Nov 2022 13:10:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Jim Porter Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 03 Nov 2022 17:10:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58899 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 58899-submit@debbugs.gnu.org id=B58899.166749539426195 (code B ref 58899); Thu, 03 Nov 2022 17:10:02 +0000 Original-Received: (at 58899) by debbugs.gnu.org; 3 Nov 2022 17:09:54 +0000 Original-Received: from localhost ([127.0.0.1]:50294 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oqdiz-0006oR-U4 for submit@debbugs.gnu.org; Thu, 03 Nov 2022 13:09:54 -0400 Original-Received: from mail-pj1-f53.google.com ([209.85.216.53]:55107) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oqdiy-0006o9-6T for 58899@debbugs.gnu.org; Thu, 03 Nov 2022 13:09:52 -0400 Original-Received: by mail-pj1-f53.google.com with SMTP id h14so2261859pjv.4 for <58899@debbugs.gnu.org>; Thu, 03 Nov 2022 10:09:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to; bh=LU197V6Jq8b/g2O/Pg/l/xwQJW1OBoj188cVHxZ9ArQ=; b=RJbFNF5ELq/u1qjLoIpOVY/Tm1GjaaepooVaznSg+8WB4pnsU6h+PitakkRuqP4AAH xmQJwfwLNXAaXcB//wpR2+vqpqRLxHPUTfU0ze6AK/G6qCUoc5fEKwZNg9ybstycy62T oOadwM83zQabQNRg/SWU2/+h8TeOtX27DBAmxTB88ROZK85TDkJp8V2Dwx861dg8u59V 2WHgTK3Ubxl8U5OeSwhbXKsQ17S4Xx7hFMxB16bQPeHk629/dMWkZMtjdR5qPIEsEaMD 8NhZELFDY2B1F6r7x7y0zcN5agRTN68zTamVMlRkts4S64EdRPWyOwA/BIGnABop//fM bZpQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=LU197V6Jq8b/g2O/Pg/l/xwQJW1OBoj188cVHxZ9ArQ=; b=S0/q8kDsgCR/Y7EvzgHqz1tigyJZPt1LDZz+BFyGLABOJk473NucwkrDjyDaPRwAjq PRB+tfCFxI2MDx7wn2Y6274fZ6liRlUJpD8+D2V77YKmNMIkP3PNmqmQ1kPJdJs+aqYB 1vfh6M+EtdJmEZPk1DTshqv1MKgFVcBmQOYzC6Km+0AGDSjMA8AmPYSwHlPmKTidE+kg Yyg57JZlimA3YeumZfQPqVtuke1mg4pYccjrODXs2Y40s2FQnYLdzL727dOU/5cCxYoi aCIlAeL8a3ZCCyqJ585Szhd5TSQ9tp7Ftixs6EDdqAZUQc32BxZx+Gk4GHCwDHloM8q0 6ISw== X-Gm-Message-State: ACrzQf3+LrrmxRmmjwWG43ULagbBCBlBSBuhej93ge6Wq2UOVmWqRU7y lqtvRn9eVxCV+vCS7EUlDpATdKCeSN8= X-Google-Smtp-Source: AMsMyM6gtR614xZxmfTVUJ+82AWSZkROQzWy3PzO8B7DQijF5HuDmfSpF9Cp+bDgbzaL2kJwXTiIYg== X-Received: by 2002:a17:903:183:b0:187:4914:1def with SMTP id z3-20020a170903018300b0018749141defmr9226630plg.91.1667495386417; Thu, 03 Nov 2022 10:09:46 -0700 (PDT) Original-Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id z14-20020aa79f8e000000b0056beae3dee2sm1009438pfr.145.2022.11.03.10.09.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 03 Nov 2022 10:09:45 -0700 (PDT) Content-Language: en-US In-Reply-To: <87k04f3kzf.fsf@ditto.jhoto.spork.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: "bug-gnu-emacs" Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:246990 Archived-At: On 10/31/2022 11:29 AM, Brian Cully via Bug reports for GNU Emacs, the Swiss army knife of text editors wrote: > Fixed. I took a look at these patches and they all look good to me[1], aside from one minor nitpick: could you wrap the new tests at 80 columns? It makes the code easier to read for people like me who have several 80-column windows side-by-side. :) [1] I haven't applied them locally to test, though.