From: Dmitry Gutov <dgutov@yandex.ru>
To: Michael Albinus <michael.albinus@gmx.de>
Cc: "Felicián Németh" <felician.nemeth@gmail.com>, 34343@debbugs.gnu.org
Subject: bug#34343: [PATCH] Make project--find-regexp-in-files work with remote files
Date: Tue, 7 Jan 2020 17:34:38 +0300 [thread overview]
Message-ID: <abf600eb-35f5-4870-456f-f4a286617162@yandex.ru> (raw)
In-Reply-To: <87zhezwd9x.fsf@gmx.de>
On 07.01.2020 16:29, Michael Albinus wrote:
> handler would be tramp-file-name-handler, so I don't see how it helps.
See my previous patch. It would only need one comparison, and
file-remote-p wouldn't need to be mentioned.
>> Well, if you like the following piece of code, I guess we could live
>> with that.
>>
>> (setq files (mapcar
>> (if (tramp-tramp-file-p dir)
>> #'tramp-file-local-name
>> #'file-local-name)
>> files)))
>
> That would work. If you are sure that you will handle only Tramp based
> remote files, you could simplify this to
>
> (setq files (mapcar #'tramp-file-local-name files))
Of course I'm not sure. Hence the conditional.
>> By the way, I have no idea what to do about having tramp-tramp-file-p
>> called twice.
>
> Take the tramp-tramp-file-p call out of mapcar, like
>
> (let ((fun (if (tramp-tramp-file-p dir)
> #'tramp-file-local-name #'file-local-name)))
> (setq files (mapcar fun files)))
The above is pretty much equivalent.
Anyway, please never mind. It's just one extra call to
tramp-tramp-file-p. Not twice per each file.
next prev parent reply other threads:[~2020-01-07 14:34 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-06 8:18 bug#34343: [PATCH] Make project--find-regexp-in-files work with remote files Felicián Németh
2019-02-14 1:17 ` Dmitry Gutov
2019-02-15 18:53 ` Felicián Németh
[not found] ` <a54e7498-4ead-dd6f-6a2e-3919ab035b23@yandex.ru>
2019-02-27 9:15 ` Michael Albinus
2019-03-06 7:47 ` Felicián Németh
2019-03-06 14:33 ` Dmitry Gutov
2019-03-06 14:44 ` Dmitry Gutov
2019-03-08 8:28 ` Felicián Németh
2019-12-26 14:04 ` Dmitry Gutov
2019-12-27 8:24 ` Michael Albinus
2019-12-27 14:18 ` Dmitry Gutov
2019-12-27 17:57 ` Michael Albinus
2019-12-28 10:21 ` Michael Albinus
2019-12-28 14:48 ` Dmitry Gutov
2019-12-28 18:56 ` Michael Albinus
2019-12-28 14:46 ` Dmitry Gutov
2019-12-28 18:46 ` Michael Albinus
2019-12-29 0:15 ` Dmitry Gutov
2019-12-29 12:34 ` Michael Albinus
2019-12-29 13:14 ` Dmitry Gutov
2020-01-01 12:29 ` Michael Albinus
2020-01-02 1:22 ` Dmitry Gutov
2020-01-02 10:48 ` Michael Albinus
2020-01-03 0:52 ` Dmitry Gutov
2020-01-03 9:28 ` Michael Albinus
2020-01-06 14:33 ` Dmitry Gutov
2020-01-06 18:48 ` Michael Albinus
2020-01-07 3:23 ` Dmitry Gutov
2020-01-07 9:19 ` Michael Albinus
2020-01-07 13:40 ` Dmitry Gutov
2020-01-07 14:29 ` Michael Albinus
2020-01-07 14:34 ` Dmitry Gutov [this message]
2021-07-22 13:00 ` Lars Ingebrigtsen
2021-07-24 19:42 ` Dmitry Gutov
2021-07-25 6:41 ` Lars Ingebrigtsen
2020-01-03 0:57 ` Dmitry Gutov
2020-01-06 17:29 ` Felician Nemeth
2020-01-07 3:23 ` Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=abf600eb-35f5-4870-456f-f4a286617162@yandex.ru \
--to=dgutov@yandex.ru \
--cc=34343@debbugs.gnu.org \
--cc=felician.nemeth@gmail.com \
--cc=michael.albinus@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).