From: Michael Albinus <michael.albinus@gmx.de>
To: Dmitry Gutov <dgutov@yandex.ru>
Cc: "Felicián Németh" <felician.nemeth@gmail.com>, 34343@debbugs.gnu.org
Subject: bug#34343: [PATCH] Make project--find-regexp-in-files work with remote files
Date: Fri, 27 Dec 2019 18:57:31 +0100 [thread overview]
Message-ID: <87mubdps6s.fsf@gmx.de> (raw)
In-Reply-To: <0ff03b20-20d8-b6c0-c876-3fd525586180@yandex.ru> (Dmitry Gutov's message of "Fri, 27 Dec 2019 17:18:49 +0300")
[-- Attachment #1: Type: text/plain, Size: 1019 bytes --]
Dmitry Gutov <dgutov@yandex.ru> writes:
Hi Dmitry,
>> The patch looks reasonable to me. Since I don't use project-files, I
>> can't say whether this works correctly.
>
> Unless it's a religious position, you can test it with:
>
> M-x project-find-regexp
>
> or
>
> M-x dired-do-find-regexp (also bound to 'A' in Dired)
>
> (the latter since one of my yesterday's commits).
No religious barrier here :-)
> For now, I've done some testing myself. It prepended 'remote-id'
> twice, now fixed.
I've tested with the emacs-27 branch, and it seems to work.
> Things I've noticed:
>
> - (mapcar #'file-local-name files) takes like ~2 seconds when FILES
> only has ~3000 elements. The same code completes instantly on a
> local machine. Shouldn't it be the same?
file-local-name uses internally file-remote-p, which calls
expand-file-name if the connection is already established. Not needed in
case of local names.
Could you pls test the appended patch, whether it improves performance?
Best regards, Michael.
[-- Attachment #2: Type: text/plain, Size: 913 bytes --]
diff --git a/lisp/tramp.el b/lisp/tramp.el
index 0dbbfa59..a25b2715 100644
--- a/lisp/tramp.el
+++ b/lisp/tramp.el
;; This file is part of GNU Emacs.
@@ -3361,10 +3361,12 @@ User is always nil."
(let* ((v (tramp-dissect-file-name filename))
(p (tramp-get-connection-process v))
(c (and (process-live-p p)
- (tramp-get-connection-property p "connected" nil))))
- ;; We expand the file name only, if there is already a connection.
+ (tramp-get-connection-property p "connected" nil)))
+ (e (and c (not (eq identification 'localname)))))
+ ;; We expand the file name only, if there is already a
+ ;; connection, and IDENTIFICATION is not `localname'.
(with-parsed-tramp-file-name
- (if c (expand-file-name filename) filename) nil
+ (if e (expand-file-name filename) filename) nil
(and (or (not connected) c)
(cond
((eq identification 'method) method)
next prev parent reply other threads:[~2019-12-27 17:57 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-06 8:18 bug#34343: [PATCH] Make project--find-regexp-in-files work with remote files Felicián Németh
2019-02-14 1:17 ` Dmitry Gutov
2019-02-15 18:53 ` Felicián Németh
[not found] ` <a54e7498-4ead-dd6f-6a2e-3919ab035b23@yandex.ru>
2019-02-27 9:15 ` Michael Albinus
2019-03-06 7:47 ` Felicián Németh
2019-03-06 14:33 ` Dmitry Gutov
2019-03-06 14:44 ` Dmitry Gutov
2019-03-08 8:28 ` Felicián Németh
2019-12-26 14:04 ` Dmitry Gutov
2019-12-27 8:24 ` Michael Albinus
2019-12-27 14:18 ` Dmitry Gutov
2019-12-27 17:57 ` Michael Albinus [this message]
2019-12-28 10:21 ` Michael Albinus
2019-12-28 14:48 ` Dmitry Gutov
2019-12-28 18:56 ` Michael Albinus
2019-12-28 14:46 ` Dmitry Gutov
2019-12-28 18:46 ` Michael Albinus
2019-12-29 0:15 ` Dmitry Gutov
2019-12-29 12:34 ` Michael Albinus
2019-12-29 13:14 ` Dmitry Gutov
2020-01-01 12:29 ` Michael Albinus
2020-01-02 1:22 ` Dmitry Gutov
2020-01-02 10:48 ` Michael Albinus
2020-01-03 0:52 ` Dmitry Gutov
2020-01-03 9:28 ` Michael Albinus
2020-01-06 14:33 ` Dmitry Gutov
2020-01-06 18:48 ` Michael Albinus
2020-01-07 3:23 ` Dmitry Gutov
2020-01-07 9:19 ` Michael Albinus
2020-01-07 13:40 ` Dmitry Gutov
2020-01-07 14:29 ` Michael Albinus
2020-01-07 14:34 ` Dmitry Gutov
2021-07-22 13:00 ` Lars Ingebrigtsen
2021-07-24 19:42 ` Dmitry Gutov
2021-07-25 6:41 ` Lars Ingebrigtsen
2020-01-03 0:57 ` Dmitry Gutov
2020-01-06 17:29 ` Felician Nemeth
2020-01-07 3:23 ` Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mubdps6s.fsf@gmx.de \
--to=michael.albinus@gmx.de \
--cc=34343@debbugs.gnu.org \
--cc=dgutov@yandex.ru \
--cc=felician.nemeth@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).