From: Dmitry Gutov <dgutov@yandex.ru>
To: "Nicolás Ojeda Bär" <n.oje.bar@gmail.com>
Cc: 55871@debbugs.gnu.org
Subject: bug#55871: Acknowledgement (27.1; vc-git.el log view 'a', 'f', 'd' do not work when following renames)
Date: Tue, 13 Dec 2022 03:23:29 +0200 [thread overview]
Message-ID: <abcdc8ac-e123-d434-e303-b57b8469bab3@yandex.ru> (raw)
In-Reply-To: <CAPunWhBJKx9USG2WxOicPPYZMkbhPNsvVb-5JpiBve7d3MwcgA@mail.gmail.com>
Dear Nicolas,
On 12/12/2022 18:44, Nicolás Ojeda Bär wrote:
> Apologies for the delay in getting back to you; I have been submerged
> in my day job and haven't had any time to look at the code again (the
> copyright assignment is done, by the way).
Good to hear about the copyright assignment.
No problem about delayed replies, I first of all wanted to experiment
with an alternative and see how others deal with it.
> I read your message, and I think immitating GitHub's UI is a great
> idea, as it liberates us from having to do any kind of "pretreatment"
> of the git log (which can be expensive for large repos).
Indeed. I suppose we'll lose out in some more complex cases (e.g. if
--follow tracks copies, it might track the cases when several files had
been copied into one, including when that action spanned several
commits; and thus --follow could show the history of each such file),
but we should win in the most common cases (single-file copies and
renames) OOtB, which we don't have any good support for still.
> We should focus in this direction to fix this issue. If I get some
> spare time over the holidays I will try to take a look (sadly, I
> cannot promise that will be the case...).
We won't be able to put the improvement into Emacs 29 anyway (the
release branch has been cut, it's now bugfix-only), so there is no hurry.
Let's see who gets to this first. If you wanted to finish up your patch
instead, I'm not going to say no either. But GitHub's approach seems
like it should require less (and less complex) code.
Best,
Dmitry.
next prev parent reply other threads:[~2022-12-13 1:23 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-09 9:54 bug#55871: 27.1; vc-git.el log view 'a', 'f', 'd' do not work when following renames Nicolás Ojeda Bär
[not found] ` <handler.55871.B.16547851264967.ack@debbugs.gnu.org>
2022-06-10 17:31 ` bug#55871: Acknowledgement (27.1; vc-git.el log view 'a', 'f', 'd' do not work when following renames) Nicolás Ojeda Bär
2022-08-18 2:10 ` Dmitry Gutov
2022-09-06 10:56 ` bug#55871: 27.1; vc-git.el log view 'a', 'f', 'd' do not work when following renames Lars Ingebrigtsen
2022-09-06 12:12 ` Nicolás Ojeda Bär
2022-09-06 12:13 ` Lars Ingebrigtsen
2022-12-03 2:02 ` Dmitry Gutov
2022-12-11 23:02 ` bug#55871: Acknowledgement (27.1; vc-git.el log view 'a', 'f', 'd' do not work when following renames) Dmitry Gutov
2022-12-12 16:44 ` Nicolás Ojeda Bär
2022-12-13 1:23 ` Dmitry Gutov [this message]
2023-12-14 0:52 ` Dmitry Gutov
2023-12-14 1:23 ` Dmitry Gutov
2023-12-15 2:01 ` Dmitry Gutov
2023-12-15 13:05 ` Eli Zaretskii
2023-12-15 14:39 ` Dmitry Gutov
2023-12-15 15:10 ` Eli Zaretskii
2023-12-15 20:45 ` Dmitry Gutov
2023-12-16 7:21 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=abcdc8ac-e123-d434-e303-b57b8469bab3@yandex.ru \
--to=dgutov@yandex.ru \
--cc=55871@debbugs.gnu.org \
--cc=n.oje.bar@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).