From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#55871: Acknowledgement (27.1; vc-git.el log view 'a', 'f', 'd' do not work when following renames) Date: Tue, 13 Dec 2022 03:23:29 +0200 Message-ID: References: <78f97339-2aca-0dbd-4cb4-3532af78a895@yandex.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="7054"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Cc: 55871@debbugs.gnu.org To: =?UTF-8?Q?Nicol=C3=A1s?= Ojeda =?UTF-8?Q?B=C3=A4r?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Dec 13 02:24:14 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p4u1l-0001dK-Tn for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 13 Dec 2022 02:24:13 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p4u1c-0000vh-Jl; Mon, 12 Dec 2022 20:24:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p4u1a-0000pz-U9 for bug-gnu-emacs@gnu.org; Mon, 12 Dec 2022 20:24:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p4u1a-0008GN-LU for bug-gnu-emacs@gnu.org; Mon, 12 Dec 2022 20:24:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1p4u1a-0006Hu-8v for bug-gnu-emacs@gnu.org; Mon, 12 Dec 2022 20:24:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 13 Dec 2022 01:24:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55871 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 55871-submit@debbugs.gnu.org id=B55871.167089461924156 (code B ref 55871); Tue, 13 Dec 2022 01:24:02 +0000 Original-Received: (at 55871) by debbugs.gnu.org; 13 Dec 2022 01:23:39 +0000 Original-Received: from localhost ([127.0.0.1]:56911 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p4u1C-0006HY-Rv for submit@debbugs.gnu.org; Mon, 12 Dec 2022 20:23:39 -0500 Original-Received: from mail-wm1-f52.google.com ([209.85.128.52]:52092) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p4u1B-0006HR-Ih for 55871@debbugs.gnu.org; Mon, 12 Dec 2022 20:23:38 -0500 Original-Received: by mail-wm1-f52.google.com with SMTP id bg10so7215442wmb.1 for <55871@debbugs.gnu.org>; Mon, 12 Dec 2022 17:23:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:from:to:cc:subject:date:message-id:reply-to; bh=hLUbOjlR894NuzqOtl46SYbHNMn8w8h0qh16b2fbLLc=; b=BawymIawdBCriRBnxia4zneBw70AE3UnvenpbrOcuwSEUC90TDvvQgfoaHAPEJrgUL AJFO/9ht4ljL2pb+xOwz7zkkdmTR0aFiBhksSyyNE7F+HNO95HtX3Z7TvrjSwe9a9EcZ ZLXjwmipY3ACjji+aWgYQjRXpMyEUVI5yJxaJuzq8oZAbh5oG0SRdJmPipEco2Ezo0qC dAhEHEyG/4w1S2oDf/HSSgTXka7W9olvxpq3mKdJ0Crr79yYvyXAQTz5gWM+OhyVC5Hv x/ty26BkDNp11rHU10icw3+TAnDf4iCEsGwLpDOr/zBM5ftmVhlOt2eUg1qD/SDJyVpf W84Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=hLUbOjlR894NuzqOtl46SYbHNMn8w8h0qh16b2fbLLc=; b=4km7SarKFY1xKxLgOa7R5ftxDXjisALI0ucQHe8nsK1/5BdZRv95oTSZyJNaZwVpUX Yr/H+x3mE+AXW5mvQXX2Qu7/GWeZv2BISMdMKzCqck/skLiq2ri3iAfD1VOaHRwcDK14 F0PVGkf109D6ykbbmKh5ph0Uvb83iWVWkt9v/JRhnNb2HNsXME/vZh7QNb2b9wdx/uoe R21Z4pkutulRq3l7jX1fiW32Igqd88kwJXaDFXW9Llp8cfVZpQ7zPCGWGoWARBstXRhH /t+c9pb5UbRG6EuBtQ+nqzwdcqBjSM314EnqYifbg8Izj2Ch7ycqRLQigGesAdhm8xyt jVmw== X-Gm-Message-State: ANoB5pkA+aPJVpF63/NLw1gf9C0mpWcKtXmG/dc5nQNtjYm8NjbeCmB2 RaDAYZlYf9qON0wl6niOgXQ= X-Google-Smtp-Source: AA0mqf6tL2F8KK1Am/IhZZHK50jA8YkP604OYkYM/s4OgxjBzRS6TTE38MYwFUkEOrZH01cIwasI8Q== X-Received: by 2002:a05:600c:3d06:b0:3c6:e60f:3f55 with SMTP id bh6-20020a05600c3d0600b003c6e60f3f55mr14287486wmb.12.1670894611789; Mon, 12 Dec 2022 17:23:31 -0800 (PST) Original-Received: from [192.168.0.2] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id m4-20020a05600c090400b003cf4d99fd2asm10576114wmp.6.2022.12.12.17.23.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 12 Dec 2022 17:23:31 -0800 (PST) Content-Language: en-US In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:250793 Archived-At: Dear Nicolas, On 12/12/2022 18:44, Nicolás Ojeda Bär wrote: > Apologies for the delay in getting back to you; I have been submerged > in my day job and haven't had any time to look at the code again (the > copyright assignment is done, by the way). Good to hear about the copyright assignment. No problem about delayed replies, I first of all wanted to experiment with an alternative and see how others deal with it. > I read your message, and I think immitating GitHub's UI is a great > idea, as it liberates us from having to do any kind of "pretreatment" > of the git log (which can be expensive for large repos). Indeed. I suppose we'll lose out in some more complex cases (e.g. if --follow tracks copies, it might track the cases when several files had been copied into one, including when that action spanned several commits; and thus --follow could show the history of each such file), but we should win in the most common cases (single-file copies and renames) OOtB, which we don't have any good support for still. > We should focus in this direction to fix this issue. If I get some > spare time over the holidays I will try to take a look (sadly, I > cannot promise that will be the case...). We won't be able to put the improvement into Emacs 29 anyway (the release branch has been cut, it's now bugfix-only), so there is no hurry. Let's see who gets to this first. If you wanted to finish up your patch instead, I'm not going to say no either. But GitHub's approach seems like it should require less (and less complex) code. Best, Dmitry.