unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Jim Porter <jporterbugs@gmail.com>
To: 56509@debbugs.gnu.org
Subject: bug#56509: [PATCH] 29.0.50; Eshell variable aliases don't fully support indexing
Date: Mon, 11 Jul 2022 21:11:33 -0700	[thread overview]
Message-ID: <a9686f01-4af0-e9e4-e465-1e808be52f40@gmail.com> (raw)
In-Reply-To: <f68b6ea6-f95e-00b9-9bbe-7851b949d891@gmail.com>

On 7/11/2022 8:06 PM, Jim Porter wrote:
> Finally, the third patch makes sure indexing works on all the alias 
> variables. I tweaked the behavior of a couple of the alias variable 
> functions and also added a flag to members of 
> `eshell-variable-aliases-list' to use the "simple" behavior of passing 
> the result to `eshell-apply-indices'.

Oh, I forgot to mention: in the third patch, I changed how many 
arguments are passed to functions in `eshell-variable-aliases-list'. I 
tried to add a backwards-compatible fallback for the old way in 
`eshell-get-variable'. Maybe there's a better way to do this than what I 
came up with, though...





  reply	other threads:[~2022-07-12  4:11 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-12  2:47 bug#56509: 29.0.50; Eshell variable aliases don't fully support indexing Jim Porter
2022-07-12  3:06 ` bug#56509: [PATCH] " Jim Porter
2022-07-12  4:11   ` Jim Porter [this message]
2022-07-12 13:11   ` bug#56509: " Lars Ingebrigtsen
2022-07-16 12:09 ` Mattias Engdegård
2022-07-17  3:13   ` Jim Porter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a9686f01-4af0-e9e4-e465-1e808be52f40@gmail.com \
    --to=jporterbugs@gmail.com \
    --cc=56509@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).