From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jim Porter Newsgroups: gmane.emacs.bugs Subject: bug#56509: [PATCH] 29.0.50; Eshell variable aliases don't fully support indexing Date: Mon, 11 Jul 2022 21:11:33 -0700 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="39398"; mail-complaints-to="usenet@ciao.gmane.io" To: 56509@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Jul 12 06:12:19 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oB7Fx-000A4Q-Mh for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 12 Jul 2022 06:12:17 +0200 Original-Received: from localhost ([::1]:48488 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oB7Fw-0005d6-Mx for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 12 Jul 2022 00:12:16 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:59096) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oB7Fi-0005ad-Hq for bug-gnu-emacs@gnu.org; Tue, 12 Jul 2022 00:12:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:47520) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oB7Fi-000358-9S for bug-gnu-emacs@gnu.org; Tue, 12 Jul 2022 00:12:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oB7Fi-0005h3-23 for bug-gnu-emacs@gnu.org; Tue, 12 Jul 2022 00:12:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Jim Porter Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 12 Jul 2022 04:12:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56509 X-GNU-PR-Package: emacs Original-Received: via spool by 56509-submit@debbugs.gnu.org id=B56509.165759910221855 (code B ref 56509); Tue, 12 Jul 2022 04:12:02 +0000 Original-Received: (at 56509) by debbugs.gnu.org; 12 Jul 2022 04:11:42 +0000 Original-Received: from localhost ([127.0.0.1]:41417 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oB7FO-0005gR-JO for submit@debbugs.gnu.org; Tue, 12 Jul 2022 00:11:42 -0400 Original-Received: from mail-pl1-f179.google.com ([209.85.214.179]:33769) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oB7FL-0005g9-Ru for 56509@debbugs.gnu.org; Tue, 12 Jul 2022 00:11:40 -0400 Original-Received: by mail-pl1-f179.google.com with SMTP id v21so3691370plo.0 for <56509@debbugs.gnu.org>; Mon, 11 Jul 2022 21:11:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:from:to:references:message-id:date:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=0dLtMKRhRHXKcVxl5AqZeeUZgTRQw8qfIvs0tLyNt3E=; b=JhvrVlOeooTBMczGw8JhprU57N3VgrFFfvcQRuUYzYkjpiRCpGGwOdDPhbLiwtk9Ei A6qQrPVr5P7mnzHjLHHrvzNJm+6qpDUNm4CpXtGONmvlq4QTcFVlFDKXIce90X8ZUZx3 aLSlBek2EIdu550XN0zxynDIHFpWPOv5ou8fQCDcl64C7fsVKUcoUQPYdbaE3XnUsuXb mO7833z37fCDqWuy++eq4gnFmIIFgrxr/4r2Ct22+H8o3o5mPtC9Q0CpD48SrDbwOy6c SG5C7MD7elP4aOdA8PG7hY6yMSvB99rqIIMoqiKDurHizdtR3uwdzhnfy+0UBaRKW3DW OeIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:from:to:references:message-id:date :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=0dLtMKRhRHXKcVxl5AqZeeUZgTRQw8qfIvs0tLyNt3E=; b=oH+9fT68YA2BTy2VOiafWmjwJZEEqzZ3EFAHaH5WEicbEzkD56gV360ufp6zXpfjHN XMT9q5cFDZJUap63db2hm69J1FcqbU/SfkQ0DYbMK8HFj+K1kywlvM39dSJA2IAA0sxX 2dmhLNjJino+ovEOEE2hguzizI+MgTxJg4KhgI/ZCZYgzyqRwFBSKdGxbR3Sb+uOyW8O q76qFtDG65NGMpg/qVK4+D3rz8JWCyBXNgpQ8N30ILtjBie1Zo5mh4XCmrElMQWi/1tY qDTQ+K3U4cJZhbRYDVNjVBxfBmL6O28xWH9hsnINvP2eFsl9dAX0shmVnR5X5CFrCU87 Fkug== X-Gm-Message-State: AJIora8aq8YACXDjN6yZb9oC+hqh5O1fHmF2kTpt0qpP4BaTt2MyNm85 /NMVcWZHS2Jj8Syi3gRsThXBAKeEM7w= X-Google-Smtp-Source: AGRyM1tS58S+u6bZD1cigF+/Dsin7lNTDkKuNIzsPxJ957XBfwwd/BEg5WLqG26duI2wcNAzCA3pow== X-Received: by 2002:a17:902:d642:b0:16b:d5b7:1117 with SMTP id y2-20020a170902d64200b0016bd5b71117mr21354420plh.167.1657599094005; Mon, 11 Jul 2022 21:11:34 -0700 (PDT) Original-Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id h123-20020a62de81000000b005252a06750esm5534128pfg.182.2022.07.11.21.11.32 for <56509@debbugs.gnu.org> (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 11 Jul 2022 21:11:33 -0700 (PDT) In-Reply-To: Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:236738 Archived-At: On 7/11/2022 8:06 PM, Jim Porter wrote: > Finally, the third patch makes sure indexing works on all the alias > variables. I tweaked the behavior of a couple of the alias variable > functions and also added a flag to members of > `eshell-variable-aliases-list' to use the "simple" behavior of passing > the result to `eshell-apply-indices'. Oh, I forgot to mention: in the third patch, I changed how many arguments are passed to functions in `eshell-variable-aliases-list'. I tried to add a backwards-compatible fallback for the old way in `eshell-get-variable'. Maybe there's a better way to do this than what I came up with, though...