unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
* bug#41721: 28.0.50; "f is undefined" in list-packages buffer
@ 2020-06-05 12:31 Platon Pronko
       [not found] ` <handler.41721.B.15913602888633.ack@debbugs.gnu.org>
  2020-06-05 13:32 ` bug#41721: 28.0.50; "f is undefined" in list-packages buffer Basil L. Contovounesios
  0 siblings, 2 replies; 11+ messages in thread
From: Platon Pronko @ 2020-06-05 12:31 UTC (permalink / raw)
  To: 41721

1. 'emacs -Q'
2. 'M-x list-packages'
3. 'f'
4. Observe message "f is undefined"

When I type "h", in the help popup "f" is reserved to mean "filter". Online documentation also mentions only "f" to filter the packages: https://www.gnu.org/software/emacs/manual/html_node/emacs/Package-Menu.html

In describe-mode I see that filtering is done using "/" prefix key, not with "f".

In GNU Emacs 28.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.20, cairo version 1.17.3)
  of 2020-06-04 built on the-big-maker
Repository revision: cdadb7a97cbed523af9f52705d8b03e91d17313f
Repository branch: master
Windowing system distributor 'The X.Org Foundation', version 11.0.12008000
System Description: Arch Linux

Configured using:
  'configure --prefix=/usr --sysconfdir=/etc --libexecdir=/usr/lib
  --localstatedir=/var --mandir=/usr/share/man --with-gameuser=:games
  --with-sound=alsa --with-modules --without-gconf --without-gsettings
  --with-x-toolkit=gtk3 --without-xaw3d --without-compress-install
  'CFLAGS=-march=x86-64 -mtune=generic -O2 -pipe -fno-plt -flto'
  CPPFLAGS=-D_FORTIFY_SOURCE=2
  LDFLAGS=-Wl,-O1,--sort-common,--as-needed,-z,relro,-z,now'

Configured features:
XPM JPEG TIFF GIF PNG RSVG CAIRO SOUND GPM DBUS GLIB NOTIFY INOTIFY ACL
GNUTLS LIBXML2 FREETYPE HARFBUZZ M17N_FLT LIBOTF ZLIB
TOOLKIT_SCROLL_BARS GTK3 X11 XDBE XIM MODULES THREADS LIBSYSTEMD JSON
PDUMPER LCMS2 GMP

Important settings:
   value of $LC_TIME: en_SE.UTF-8
   value of $LANG: en_US.UTF-8
   locale-coding-system: utf-8-unix

Major mode: Lisp Interaction

Minor modes in effect:
   global-magit-file-mode: t
   magit-file-mode: t
   magit-auto-revert-mode: t
   recentf-mode: t
   rainbow-delimiters-mode: t
   counsel-mode: t
   ivy-mode: t
   smartparens-strict-mode: t
   smartparens-mode: t
   global-git-gutter-mode: t
   global-git-commit-mode: t
   async-bytecomp-package-mode: t
   shell-dirtrack-mode: t
   global-auto-revert-mode: t
   global-whitespace-mode: t
   tooltip-mode: t
   global-eldoc-mode: t
   eldoc-mode: t
   electric-indent-mode: t
   mouse-wheel-mode: t
   file-name-shadow-mode: t
   global-font-lock-mode: t
   font-lock-mode: t
   auto-composition-mode: t
   auto-encryption-mode: t
   auto-compression-mode: t
   column-number-mode: t
   line-number-mode: t
   transient-mark-mode: t

Load-path shadows:
/home/platon/.emacs.d/elpa/ivy-20200605.1134/elpa hides /home/platon/.emacs.d/elpa/lispy-20200519.737/elpa
/home/platon/.emacs.d/elpa/cider-20200604.1627/cider-ns hides /usr/share/emacs/site-lisp/cider-ns
/home/platon/.emacs.d/elpa/cider-20200604.1627/cider-classpath hides /usr/share/emacs/site-lisp/cider-classpath
/home/platon/.emacs.d/elpa/cider-20200604.1627/cider-stacktrace hides /usr/share/emacs/site-lisp/cider-stacktrace
/home/platon/.emacs.d/elpa/cider-20200604.1627/cider-clojuredocs hides /usr/share/emacs/site-lisp/cider-clojuredocs
/home/platon/.emacs.d/elpa/cider-20200604.1627/cider-doc hides /usr/share/emacs/site-lisp/cider-doc
/home/platon/.emacs.d/elpa/cider-20200604.1627/cider hides /usr/share/emacs/site-lisp/cider
/home/platon/.emacs.d/elpa/parseclj-20190531.711/parseclj-ast hides /usr/share/emacs/site-lisp/parseclj-ast
/home/platon/.emacs.d/elpa/cider-20200604.1627/cider-connection hides /usr/share/emacs/site-lisp/cider-connection
/home/platon/.emacs.d/elpa/cider-20200604.1627/nrepl-client hides /usr/share/emacs/site-lisp/nrepl-client
/home/platon/.emacs.d/elpa/cider-20200604.1627/cider-popup hides /usr/share/emacs/site-lisp/cider-popup
/home/platon/.emacs.d/elpa/parseedn-20200419.1124/parseedn hides /usr/share/emacs/site-lisp/parseedn
/home/platon/.emacs.d/elpa/cider-20200604.1627/cider-cheatsheet hides /usr/share/emacs/site-lisp/cider-cheatsheet
/home/platon/.emacs.d/elpa/cider-20200604.1627/cider-debug hides /usr/share/emacs/site-lisp/cider-debug
/home/platon/.emacs.d/elpa/cider-20200604.1627/cider-completion hides /usr/share/emacs/site-lisp/cider-completion
/home/platon/.emacs.d/elpa/cider-20200604.1627/cider-eval hides /usr/share/emacs/site-lisp/cider-eval
/home/platon/.emacs.d/elpa/cider-20200604.1627/cider-repl hides /usr/share/emacs/site-lisp/cider-repl
/home/platon/.emacs.d/elpa/cider-20200604.1627/cider-inspector hides /usr/share/emacs/site-lisp/cider-inspector
/home/platon/.emacs.d/elpa/parseclj-20190531.711/parseclj hides /usr/share/emacs/site-lisp/parseclj
/home/platon/.emacs.d/elpa/cider-20200604.1627/cider-util hides /usr/share/emacs/site-lisp/cider-util
/home/platon/.emacs.d/elpa/cider-20200604.1627/cider-eldoc hides /usr/share/emacs/site-lisp/cider-eldoc
/home/platon/.emacs.d/elpa/parseclj-20190531.711/parseclj-parser hides /usr/share/emacs/site-lisp/parseclj-parser
/home/platon/.emacs.d/elpa/cider-20200604.1627/cider-browse-ns hides /usr/share/emacs/site-lisp/cider-browse-ns
/home/platon/.emacs.d/elpa/cider-20200604.1627/cider-macroexpansion hides /usr/share/emacs/site-lisp/cider-macroexpansion
/home/platon/.emacs.d/elpa/cider-20200604.1627/cider-resolve hides /usr/share/emacs/site-lisp/cider-resolve
/home/platon/.emacs.d/elpa/cider-20200604.1627/cider-compat hides /usr/share/emacs/site-lisp/cider-compat
/home/platon/.emacs.d/elpa/cider-20200604.1627/cider-format hides /usr/share/emacs/site-lisp/cider-format
/home/platon/.emacs.d/elpa/cider-20200604.1627/cider-common hides /usr/share/emacs/site-lisp/cider-common
/home/platon/.emacs.d/elpa/a-20180907.953/a hides /usr/share/emacs/site-lisp/a
/home/platon/.emacs.d/elpa/cider-20200604.1627/cider-profile hides /usr/share/emacs/site-lisp/cider-profile
/home/platon/.emacs.d/elpa/cider-20200604.1627/cider-selector hides /usr/share/emacs/site-lisp/cider-selector
/home/platon/.emacs.d/elpa/cider-20200604.1627/cider-client hides /usr/share/emacs/site-lisp/cider-client
/home/platon/.emacs.d/elpa/cider-20200604.1627/cider-scratch hides /usr/share/emacs/site-lisp/cider-scratch
/home/platon/.emacs.d/elpa/cider-20200604.1627/cider-repl-history hides /usr/share/emacs/site-lisp/cider-repl-history
/home/platon/.emacs.d/elpa/cider-20200604.1627/cider-find hides /usr/share/emacs/site-lisp/cider-find
/home/platon/.emacs.d/elpa/cider-20200604.1627/cider-test hides /usr/share/emacs/site-lisp/cider-test
/home/platon/.emacs.d/elpa/cider-20200604.1627/nrepl-dict hides /usr/share/emacs/site-lisp/nrepl-dict
/home/platon/.emacs.d/elpa/cider-20200604.1627/cider-overlays hides /usr/share/emacs/site-lisp/cider-overlays
/home/platon/.emacs.d/elpa/protobuf-mode-20200520.15/protobuf-mode hides /usr/share/emacs/site-lisp/protobuf-mode
/home/platon/.emacs.d/elpa/parseclj-20190531.711/parseclj-lex hides /usr/share/emacs/site-lisp/parseclj-lex
/home/platon/.emacs.d/elpa/cider-20200604.1627/cider-mode hides /usr/share/emacs/site-lisp/cider-mode
/home/platon/.emacs.d/elpa/cider-20200604.1627/cider-xref hides /usr/share/emacs/site-lisp/cider-xref
/home/platon/.emacs.d/elpa/cider-20200604.1627/cider-apropos hides /usr/share/emacs/site-lisp/cider-apropos
/home/platon/.emacs.d/elpa/cider-20200604.1627/cider-browse-spec hides /usr/share/emacs/site-lisp/cider-browse-spec
/home/platon/.emacs.d/elpa/cider-20200604.1627/cider-tracing hides /usr/share/emacs/site-lisp/cider-tracing
/home/platon/.emacs.d/elpa/clojure-mode-20200419.559/clojure-mode hides /usr/share/emacs/site-lisp/clojure-mode
/home/platon/.emacs.d/elpa/epl-20180205.2049/epl hides /usr/share/emacs/site-lisp/epl/epl
/home/platon/.emacs.d/elpa/pkg-info-20150517.1143/pkg-info hides /usr/share/emacs/site-lisp/pkg-info/pkg-info
/home/platon/.emacs.d/elpa/queue-0.2/queue hides /usr/share/emacs/site-lisp/queue/queue
/home/platon/.emacs.d/elpa/sesman-20190909.1754/sesman-browser hides /usr/share/emacs/site-lisp/sesman/sesman-browser
/home/platon/.emacs.d/elpa/sesman-20190909.1754/sesman hides /usr/share/emacs/site-lisp/sesman/sesman
/home/platon/.emacs.d/elpa/spinner-1.7.3/spinner hides /usr/share/emacs/site-lisp/spinner/spinner
/home/platon/.emacs.d/elpa/less-css-mode-20161001.453/less-css-mode hides /usr/share/emacs/28.0.50/lisp/textmodes/less-css-mode

Features:
(shadow sort mail-extr emacsbug sendmail cider-debug cider-repl-history
cider-find cider-scratch pulse cider-inspector cider-browse-ns apropos
cider-mode cider-completion cider-profile cider-eval cider-repl
cider-resolve cider-eldoc cider-test cider-stacktrace cider-overlays
cider-doc cider-browse-spec cider-clojuredocs cider-client
cider-connection sesman-browser nrepl-client queue spinner parseedn
parseclj-parser parseclj-lex a cider-popup cider-common cider-util
smartparens-clojure sesman vc vc-dispatcher clojure-mode align
nrepl-dict cider-compat benchmark vc-git ido autoload tar-mode arc-mode
archive-mode lisp-mnt mm-archive gnutls network-stream url-http url-gw
nsm url-cache url-auth descr-text cus-edit cus-start cus-load ibuf-ext
ibuffer ibuffer-loaddefs cl-print debug mule-util magit-patch
magit-subtree magit-ediff ediff ediff-merg ediff-mult ediff-wind
ediff-diff ediff-help ediff-init ediff-util term disp-table ehelp
sh-script executable scala-mode2 scala-mode2-map scala-mode2-fontlock
scala-mode2-indent scala-mode2-paragraph scala-mode2-syntax
scala-mode2-lib conf-mode term/xterm xterm dabbrev eieio-opt bs sql view
bug-reference magit-extras magit-bookmark magit-submodule magit-obsolete
magit-blame magit-stash magit-reflog magit-bisect magit-push magit-pull
magit-fetch magit-clone magit-remote magit-commit magit-sequence
magit-notes magit-worktree magit-tag magit-merge magit-branch
magit-reset magit-files magit-refs magit-status magit magit-repos
magit-apply magit-wip magit-log which-func magit-diff smerge-mode diff
diff-mode magit-core magit-autorevert magit-margin magit-transient
magit-process magit-mode misearch multi-isearch smartparens-python
python org-indent org-element avl-tree ol-eww ol-rmail ol-mhe ol-irc
ol-info ol-gnus nnir gnus-sum gnus-group gnus-undo gnus-start gnus-cloud
nnimap nnmail mail-source utf7 netrc nnoo gnus-spec gnus-int gnus-range
gnus-win ol-docview doc-view jka-compr image-mode exif ol-bibtex bibtex
ol-bbdb ol-w3m tramp-cache tramp-sh recentf tree-widget bookmark pp ffap
quail rainbow-delimiters lispy pcase lispy-inline avy edebug backtrace
help-fns radix-tree lispy-tags mode-local counsel xdg swiper ivy delsel
ivy-faces ivy-overlay colir smartparens-config smartparens-javascript
smartparens-rust smartparens-ruby smartparens-org smartparens-text
smartparens-html smartparens-c smartparens git-gutter-fringe
fringe-helper git-gutter hydra lv git-commit with-editor async-bytecomp
async transient cl-extra help-mode server magit-git magit-section
magit-utils crm log-edit message rmc dired dired-loaddefs rfc822 mml
mml-sec epa epg epg-config mm-decode mm-bodies mm-encode mail-parse
rfc2231 mailabbrev gmm-utils mailheader pcvs-util dash tramp
tramp-loaddefs trampver tramp-integration files-x tramp-compat shell
parse-time iso8601 ls-lisp lpr rust-mode php-mode rx speedbar ezimage
dframe etags fileloop generator xref project flymake-proc flymake
compile warnings add-log cc-langs autorevert filenotify whitespace
sass-mode haml-mode js cc-mode cc-fonts cc-guess cc-menus cc-cmds
cc-styles cc-align cc-engine cc-vars cc-defs css-mode sgml-mode imenu
eww mm-url gnus nnheader gnus-util rmail rmail-loaddefs rfc2047 rfc2045
ietf-drums mail-utils wid-edit mm-util mail-prsvr thingatpt url-queue
url url-proxy url-privacy url-expand url-methods url-history mailcap shr
text-property-search url-cookie url-domsuf url-util puny svg xml dom
color ruby-mode smie windmove besi derived scala-mode-inf cl
scala-mode-constants scala-mode-lib scala-mode-ui textindent edmacro
kmacro org ob ob-tangle ob-ref ob-lob ob-table ob-exp org-macro
org-footnote org-src ob-comint org-pcomplete pcomplete comint ansi-color
ring org-list org-faces org-entities time-date noutline outline
easy-mmode org-version ob-emacs-lisp ob-core ob-eval org-table ol
org-keys org-compat advice org-macs org-loaddefs format-spec find-func
cal-menu calendar cal-loaddefs darcula-theme finder-inf
scala-mode2-autoloads info package easymenu browse-url url-handlers
url-parse auth-source cl-seq eieio eieio-core cl-macs eieio-loaddefs
password-cache json subr-x map url-vars seq byte-opt gv bytecomp
byte-compile cconv cl-loaddefs cl-lib tooltip eldoc electric uniquify
ediff-hook vc-hooks lisp-float-type mwheel term/x-win x-win
term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe
tabulated-list replace newcomment text-mode elisp-mode lisp-mode
prog-mode register page tab-bar menu-bar rfn-eshadow isearch timer
select scroll-bar mouse jit-lock font-lock syntax facemenu font-core
term/tty-colors frame minibuffer cl-generic cham georgian utf-8-lang
misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms
cp51932 hebrew greek romanian slovak czech european ethiopic indian
cyrillic chinese composite charscript charprop case-table epa-hook
jka-cmpr-hook help simple abbrev obarray cl-preloaded nadvice loaddefs
button faces cus-face macroexp files text-properties overlay sha1 md5
base64 format env code-pages mule custom widget hashtable-print-readable
backquote threads dbusbind inotify lcms2 dynamic-setting
font-render-setting cairo move-toolbar gtk x-toolkit x multi-tty
make-network-process emacs)

Memory information:
((conses 16 2128452 299170)
   (symbols 48 65145 40)
   (strings 32 329750 47799)
   (string-bytes 1 12168452)
   (vectors 16 104653)
   (vector-slots 8 1734436 123099)
   (floats 8 414 625)
   (intervals 56 208232 2133)
   (buffers 992 60))






^ permalink raw reply	[flat|nested] 11+ messages in thread

* bug#41721: Acknowledgement (28.0.50; "f is undefined" in list-packages buffer)
       [not found] ` <handler.41721.B.15913602888633.ack@debbugs.gnu.org>
@ 2020-06-05 13:16   ` Platon Pronko
  0 siblings, 0 replies; 11+ messages in thread
From: Platon Pronko @ 2020-06-05 13:16 UTC (permalink / raw)
  To: 41721

The issue seems simple enough that I could fix it myself and send a patch. However I'm not sure how to best lay out items in the message shown from package-menu-quick-help - any advice?





^ permalink raw reply	[flat|nested] 11+ messages in thread

* bug#41721: 28.0.50; "f is undefined" in list-packages buffer
  2020-06-05 12:31 bug#41721: 28.0.50; "f is undefined" in list-packages buffer Platon Pronko
       [not found] ` <handler.41721.B.15913602888633.ack@debbugs.gnu.org>
@ 2020-06-05 13:32 ` Basil L. Contovounesios
  2020-06-05 13:39   ` Platon Pronko
  1 sibling, 1 reply; 11+ messages in thread
From: Basil L. Contovounesios @ 2020-06-05 13:32 UTC (permalink / raw)
  To: Platon Pronko; +Cc: 41721

[-- Attachment #1: Type: text/plain, Size: 2162 bytes --]

tags 41721 + patch
found 41721 27.0.50
quit

Platon Pronko <platon7pronko@gmail.com> writes:

> 1. 'emacs -Q'
> 2. 'M-x list-packages'
> 3. 'f'
> 4. Observe message "f is undefined"

This is because Emacs 27 introduced new filtering commands under the '/'
prefix, so the old binding 'f' no longer exists:

Filter packages by name in list-packages. (Bug#36981)
f96b8fd27c 2019-10-08 19:24:12 +0200
https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=f96b8fd27c382a941c52c2938544b9b0e3a2fb0e

Here's the relevant etc/NEWS entry:

  *** New functions for filtering packages list.
  A new function has been added which allows users to filter the
  packages list by name: 'package-menu-filter-by-name'.  By default, it
  is bound to '/ n'.  Additionally, the function
  'package-menu-filter-by-keyword' has been renamed from
  'package-menu-filter'.  Its keybinding has also been changed to '/ k'
  (from 'f').  To clear any of the two filters, the user can now call
  the 'package-menu-clear-filter' function, bound to '/ /' by default.

> When I type "h", in the help popup "f" is reserved to mean
> "filter". Online documentation also mentions only "f" to filter the
> packages:
> https://www.gnu.org/software/emacs/manual/html_node/emacs/Package-Menu.html

The online manual has not yet been updated because Emacs 27 is still at
the pretest stage and not officially released.

> In describe-mode I see that filtering is done using "/" prefix key, not with "f".

Indeed.

The problem with 'h' (package-menu-quick-help) is that it is both
overengineered and limited in what it can do.  What it does is take a
word such as 'filter' and highlight a single character to indicate the
corresponding key binding.  E.g. ("filter" . 1) would highlight the 'i',
and "/-filter" would highlight the '/'.  This naively assumes that the
key binding is a single character, which is no longer the case.

On emacs-27, I propose we either remove the mention of filtering from
the quick help altogether, or write "/-filter" and let the user figure
out that '/' is actually a prefix that can be inspected in the usual
ways, such as by following it with C-h or <f1>.  For example:


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Update-package-menu-quick-help.patch --]
[-- Type: text/x-diff, Size: 2124 bytes --]

From 2525ae19d7154abda896f0d2cad2fd57ee3e5c8c Mon Sep 17 00:00:00 2001
From: "Basil L. Contovounesios" <contovob@tcd.ie>
Date: Fri, 5 Jun 2020 14:02:41 +0100
Subject: [PATCH] Update package-menu-quick-help

* lisp/emacs-lisp/package.el (package--quick-help-keys): Filtering
is now bound to the prefix '/', not the key 'f' (bug#41721).
Advertise only the standard 'g' binding now that both it and 'r' are
bound to revert-buffer (bug#35504).
(package--prettify-quick-help-key): Avoid modifying string literals.
(package-menu-filter): Reintroduce as obsolete alias of
package-menu-filter-by-keyword for backward
compatibility (bug#36981).
---
 lisp/emacs-lisp/package.el | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/lisp/emacs-lisp/package.el b/lisp/emacs-lisp/package.el
index 7af40247f3..7d6be3cf4e 100644
--- a/lisp/emacs-lisp/package.el
+++ b/lisp/emacs-lisp/package.el
@@ -3279,7 +3279,7 @@ package--quick-help-keys
   '(("install," "delete," "unmark," ("execute" . 1))
     ("next," "previous")
     ("Hide-package," "(-toggle-hidden")
-    ("refresh-contents," "g-redisplay," "filter," "help")))
+    ("g-refresh-contents," "/-filter," "help")))
 
 (defun package--prettify-quick-help-key (desc)
   "Prettify DESC to be displayed as a help menu."
@@ -3287,7 +3287,7 @@ package--prettify-quick-help-key
       (if (listp (cdr desc))
           (mapconcat #'package--prettify-quick-help-key desc "   ")
         (let ((place (cdr desc))
-              (out (car desc)))
+              (out (copy-sequence (car desc))))
           (add-text-properties place (1+ place)
                                '(face (bold font-lock-warning-face))
                                out)
@@ -3719,6 +3719,9 @@ package-menu-filter-by-keyword
                                    (list keyword)
                                  keyword)))
 
+(define-obsolete-function-alias
+  'package-menu-filter #'package-menu-filter-by-keyword "27.1")
+
 (defun package-menu-filter-by-name (name)
   "Filter the \"*Packages*\" buffer by NAME.
 Show only those items whose name matches the regular expression
-- 
2.26.2


[-- Attachment #3: Type: text/plain, Size: 105 bytes --]


On master, we could change package-menu-quick-help to support arbitrary
key bindings.

WDYT?

-- 
Basil

^ permalink raw reply related	[flat|nested] 11+ messages in thread

* bug#41721: 28.0.50; "f is undefined" in list-packages buffer
  2020-06-05 13:32 ` bug#41721: 28.0.50; "f is undefined" in list-packages buffer Basil L. Contovounesios
@ 2020-06-05 13:39   ` Platon Pronko
  2020-06-05 13:55     ` Basil L. Contovounesios
  0 siblings, 1 reply; 11+ messages in thread
From: Platon Pronko @ 2020-06-05 13:39 UTC (permalink / raw)
  To: Basil L. Contovounesios; +Cc: 41721

I'm for it, if my vote counts.

--
Best regards,
Platon Pronko





^ permalink raw reply	[flat|nested] 11+ messages in thread

* bug#41721: 28.0.50; "f is undefined" in list-packages buffer
  2020-06-05 13:39   ` Platon Pronko
@ 2020-06-05 13:55     ` Basil L. Contovounesios
  2020-06-05 14:10       ` Platon Pronko
  0 siblings, 1 reply; 11+ messages in thread
From: Basil L. Contovounesios @ 2020-06-05 13:55 UTC (permalink / raw)
  To: Platon Pronko; +Cc: 41721

Platon Pronko <platon7pronko@gmail.com> writes:

> I'm for it, if my vote counts.

Of course it does, but what are you for exactly?  Removing the mention
of "filter", changing it to "/-filter" so that the '/' is highlighted,
or something else?

Thanks,

-- 
Basil





^ permalink raw reply	[flat|nested] 11+ messages in thread

* bug#41721: 28.0.50; "f is undefined" in list-packages buffer
  2020-06-05 13:55     ` Basil L. Contovounesios
@ 2020-06-05 14:10       ` Platon Pronko
  2020-06-05 14:18         ` Basil L. Contovounesios
  0 siblings, 1 reply; 11+ messages in thread
From: Platon Pronko @ 2020-06-05 14:10 UTC (permalink / raw)
  To: Basil L. Contovounesios; +Cc: 41721

Apologies - I mean the included patch with "/-filter".

Removing the mention of "filter" completely will hurt discoverability - I suspect I personally would not have discovered that feature if not for the help message.

Best regards,
Platon Pronko





^ permalink raw reply	[flat|nested] 11+ messages in thread

* bug#41721: 28.0.50; "f is undefined" in list-packages buffer
  2020-06-05 14:10       ` Platon Pronko
@ 2020-06-05 14:18         ` Basil L. Contovounesios
  2020-06-05 14:24           ` Eli Zaretskii
  0 siblings, 1 reply; 11+ messages in thread
From: Basil L. Contovounesios @ 2020-06-05 14:18 UTC (permalink / raw)
  To: Platon Pronko; +Cc: 41721

Platon Pronko <platon7pronko@gmail.com> writes:

> Apologies - I mean the included patch with "/-filter".
>
> Removing the mention of "filter" completely will hurt discoverability - I
> suspect I personally would not have discovered that feature if not for the help
> message.

OK, thanks for clarifying.  I'll wait for others, particularly Eli, to
chime in as well before pushing anything.

-- 
Basil





^ permalink raw reply	[flat|nested] 11+ messages in thread

* bug#41721: 28.0.50; "f is undefined" in list-packages buffer
  2020-06-05 14:18         ` Basil L. Contovounesios
@ 2020-06-05 14:24           ` Eli Zaretskii
  2020-06-05 15:53             ` Basil L. Contovounesios
  0 siblings, 1 reply; 11+ messages in thread
From: Eli Zaretskii @ 2020-06-05 14:24 UTC (permalink / raw)
  To: Basil L. Contovounesios; +Cc: platon7pronko, 41721

> From: "Basil L. Contovounesios" <contovob@tcd.ie>
> Date: Fri, 05 Jun 2020 15:18:47 +0100
> Cc: 41721@debbugs.gnu.org
> 
> OK, thanks for clarifying.  I'll wait for others, particularly Eli, to
> chime in as well before pushing anything.

Thanks, but what am I supposed to do or say in this case?





^ permalink raw reply	[flat|nested] 11+ messages in thread

* bug#41721: 28.0.50; "f is undefined" in list-packages buffer
  2020-06-05 14:24           ` Eli Zaretskii
@ 2020-06-05 15:53             ` Basil L. Contovounesios
  2020-06-05 17:26               ` Eli Zaretskii
  0 siblings, 1 reply; 11+ messages in thread
From: Basil L. Contovounesios @ 2020-06-05 15:53 UTC (permalink / raw)
  To: Eli Zaretskii; +Cc: platon7pronko, 41721

Eli Zaretskii <eliz@gnu.org> writes:

>> From: "Basil L. Contovounesios" <contovob@tcd.ie>
>> Date: Fri, 05 Jun 2020 15:18:47 +0100
>> Cc: 41721@debbugs.gnu.org
>> 
>> OK, thanks for clarifying.  I'll wait for others, particularly Eli, to
>> chime in as well before pushing anything.
>
> Thanks, but what am I supposed to do or say in this case?

Whether the patch for emacs-27 in https://debbugs.gnu.org/41721#11 is
kosher.

Thanks,

-- 
Basil





^ permalink raw reply	[flat|nested] 11+ messages in thread

* bug#41721: 28.0.50; "f is undefined" in list-packages buffer
  2020-06-05 15:53             ` Basil L. Contovounesios
@ 2020-06-05 17:26               ` Eli Zaretskii
  2020-06-05 18:09                 ` Basil L. Contovounesios
  0 siblings, 1 reply; 11+ messages in thread
From: Eli Zaretskii @ 2020-06-05 17:26 UTC (permalink / raw)
  To: Basil L. Contovounesios; +Cc: platon7pronko, 41721

> From: "Basil L. Contovounesios" <contovob@tcd.ie>
> Cc: platon7pronko@gmail.com,  41721@debbugs.gnu.org
> Date: Fri, 05 Jun 2020 16:53:47 +0100
> 
> > Thanks, but what am I supposed to do or say in this case?
> 
> Whether the patch for emacs-27 in https://debbugs.gnu.org/41721#11 is
> kosher.

It is, thanks.





^ permalink raw reply	[flat|nested] 11+ messages in thread

* bug#41721: 28.0.50; "f is undefined" in list-packages buffer
  2020-06-05 17:26               ` Eli Zaretskii
@ 2020-06-05 18:09                 ` Basil L. Contovounesios
  0 siblings, 0 replies; 11+ messages in thread
From: Basil L. Contovounesios @ 2020-06-05 18:09 UTC (permalink / raw)
  To: Eli Zaretskii; +Cc: platon7pronko, 41721-done

tags 41721 fixed
close 41721 27.1
quit

Eli Zaretskii <eliz@gnu.org> writes:

>> From: "Basil L. Contovounesios" <contovob@tcd.ie>
>> Cc: platon7pronko@gmail.com,  41721@debbugs.gnu.org
>> Date: Fri, 05 Jun 2020 16:53:47 +0100
>> 
>> > Thanks, but what am I supposed to do or say in this case?
>> 
>> Whether the patch for emacs-27 in https://debbugs.gnu.org/41721#11 is
>> kosher.
>
> It is, thanks.

Thanks, pushed:

Update package-menu-quick-help
cc35b197c7 2020-06-05 19:06:00 +0100
https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=cc35b197c7720e0687c6a994df9a4cf767298712

I'm therefore closing this report.

-- 
Basil





^ permalink raw reply	[flat|nested] 11+ messages in thread

end of thread, other threads:[~2020-06-05 18:09 UTC | newest]

Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-05 12:31 bug#41721: 28.0.50; "f is undefined" in list-packages buffer Platon Pronko
     [not found] ` <handler.41721.B.15913602888633.ack@debbugs.gnu.org>
2020-06-05 13:16   ` bug#41721: Acknowledgement (28.0.50; "f is undefined" in list-packages buffer) Platon Pronko
2020-06-05 13:32 ` bug#41721: 28.0.50; "f is undefined" in list-packages buffer Basil L. Contovounesios
2020-06-05 13:39   ` Platon Pronko
2020-06-05 13:55     ` Basil L. Contovounesios
2020-06-05 14:10       ` Platon Pronko
2020-06-05 14:18         ` Basil L. Contovounesios
2020-06-05 14:24           ` Eli Zaretskii
2020-06-05 15:53             ` Basil L. Contovounesios
2020-06-05 17:26               ` Eli Zaretskii
2020-06-05 18:09                 ` Basil L. Contovounesios

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).