unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Ludovic Brenta <ludovic@ludovic-brenta.org>
To: 32510@debbugs.gnu.org
Subject: bug#32510: xref-find-definitions should return file names, too
Date: Thu, 18 Jul 2019 17:54:59 +0200	[thread overview]
Message-ID: <a2f8902a0885c8a381b662534c59d0fd@ludovic-brenta.org> (raw)
In-Reply-To: <83a7dbweyg.fsf@gnu.org>

Le 2019-07-18 17:16, Eli Zaretskii a écrit :
> [...] if there's only one match, xref goes
> there automatically and immediately, but if there are several
> candidate matches, xref shows them and allows you to select the one(s)
> you want.

Yes, this is exactly what happens.  We have thousands of source files
in our tree and most have names longer than 20 characters.  Our normal
usage pattern is to use partial matching.  Also your patch uses
tag-partial-file-name-match-p, not tag-full-file-name-match-p, so
it's not surprising that it should do partial matching with possibly
more than one match :)

With etags we were used to using "C-u M-." a couple times too, or
start over with a longer substring of the file name we wanted.

I'm not complaining about this new behavior; it will just take a
little getting used to.  Personally I like the fact that M-g M-n
works with the *xref* buffer like it does in a *compilation* buffer.

-- 
Ludovic Brenta.





  reply	other threads:[~2019-07-18 15:54 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <87ftnazlz3.fsf@mouse.gnus.org>
2018-08-23 15:32 ` bug#32510: xref-find-definitions should return file names, too Ludovic Brenta
2019-07-13  2:50   ` Lars Ingebrigtsen
     [not found]   ` <handler.32510.C.15629862456126.notifdonectrl.0@debbugs.gnu.org>
2019-07-13 19:34     ` bug#32510: acknowledged by developer (control message for bug #32510) Ludovic Brenta
2019-07-13 23:25       ` Drew Adams
2019-07-14  5:21       ` Eli Zaretskii
2019-07-30  0:06         ` Dmitry Gutov
2019-07-30 14:00           ` Dmitry Gutov
2019-08-03 10:00             ` Eli Zaretskii
2019-07-15 13:54   ` bug#32510: Tags: wontfix -> patch Ludovic Brenta
2019-07-18 14:53   ` bug#32510: xref-find-definitions should return file names, too Ludovic Brenta
2019-07-18 15:16     ` Eli Zaretskii
2019-07-18 15:54       ` Ludovic Brenta [this message]
2019-07-18 16:07         ` Eli Zaretskii
2019-07-19 22:23       ` Dmitry Gutov
2019-07-20  7:17         ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a2f8902a0885c8a381b662534c59d0fd@ludovic-brenta.org \
    --to=ludovic@ludovic-brenta.org \
    --cc=32510@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).