From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Ludovic Brenta Newsgroups: gmane.emacs.bugs Subject: bug#32510: xref-find-definitions should return file names, too Date: Thu, 18 Jul 2019 17:54:59 +0200 Message-ID: References: <83a7dbweyg.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="242418"; mail-complaints-to="usenet@blaine.gmane.org" To: 32510@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Jul 18 17:56:07 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1ho8lK-0010wb-S1 for geb-bug-gnu-emacs@m.gmane.org; Thu, 18 Jul 2019 17:56:06 +0200 Original-Received: from localhost ([::1]:39380 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1ho8lJ-0002kS-Sc for geb-bug-gnu-emacs@m.gmane.org; Thu, 18 Jul 2019 11:56:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:56330) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1ho8lH-0002kL-Mf for bug-gnu-emacs@gnu.org; Thu, 18 Jul 2019 11:56:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ho8lG-0001L8-Dm for bug-gnu-emacs@gnu.org; Thu, 18 Jul 2019 11:56:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:45739) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ho8lG-0001L2-A7 for bug-gnu-emacs@gnu.org; Thu, 18 Jul 2019 11:56:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ho8lG-0006ax-65 for bug-gnu-emacs@gnu.org; Thu, 18 Jul 2019 11:56:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Ludovic Brenta Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 18 Jul 2019 15:56:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 32510 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 32510-submit@debbugs.gnu.org id=B32510.156346530325260 (code B ref 32510); Thu, 18 Jul 2019 15:56:02 +0000 Original-Received: (at 32510) by debbugs.gnu.org; 18 Jul 2019 15:55:03 +0000 Original-Received: from localhost ([127.0.0.1]:54560 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ho8kJ-0006ZL-CY for submit@debbugs.gnu.org; Thu, 18 Jul 2019 11:55:03 -0400 Original-Received: from webmail.bookmyname.com ([88.191.249.153]:28786 helo=webmail.free.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ho8kH-0006Yq-7o for 32510@debbugs.gnu.org; Thu, 18 Jul 2019 11:55:02 -0400 Original-Received: from 153.98.68.208 (unknown [127.0.1.3]) by webmail.free.org (Postfix) with ESMTP id A3C98380F1; Thu, 18 Jul 2019 17:54:59 +0200 (CEST) Original-Received: from [153.98.68.208] by webmail.ludovic-brenta.org with HTTP (HTTP/1.1 POST); Thu, 18 Jul 2019 17:54:59 +0200 In-Reply-To: <83a7dbweyg.fsf@gnu.org> X-Sender: ludovic@ludovic-brenta.org Original-X-Complaints-To: abuse_at_bookmyname.com X-Abuse-Info: Please be sure to forward a copy of ALL headers X-Origin-Web-Site: webmail.ludovic-brenta.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:163316 Archived-At: Le 2019-07-18 17:16, Eli Zaretskii a =C3=A9crit=C2=A0: > [...] if there's only one match, xref goes > there automatically and immediately, but if there are several > candidate matches, xref shows them and allows you to select the one(s) > you want. Yes, this is exactly what happens. We have thousands of source files in our tree and most have names longer than 20 characters. Our normal usage pattern is to use partial matching. Also your patch uses tag-partial-file-name-match-p, not tag-full-file-name-match-p, so it's not surprising that it should do partial matching with possibly more than one match :) With etags we were used to using "C-u M-." a couple times too, or start over with a longer substring of the file name we wanted. I'm not complaining about this new behavior; it will just take a little getting used to. Personally I like the fact that M-g M-n works with the *xref* buffer like it does in a *compilation* buffer. --=20 Ludovic Brenta.