unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Alan Mackenzie <acm@muc.de>
To: Michael Heerdegen <michael_heerdegen@web.de>
Cc: 65680@debbugs.gnu.org
Subject: bug#65680: cl-print-to-string-with-limit erroneously imposes a maximum print-length of 50
Date: Tue, 3 Oct 2023 09:18:03 +0000	[thread overview]
Message-ID: <ZRvcS2lkPI-N_GT_@ACM> (raw)
In-Reply-To: <87h6n8tpyz.fsf@web.de>

Hello, Michael.

On Tue, Oct 03, 2023 at 04:11:16 +0200, Michael Heerdegen wrote:
> Hello Alan,

> in 01229fe0096 "Stop truncating strings too much in
> cl-print-string-with-limit" there is an error: the first `cond'
> condition will error when limit is nil (`zerop' expects a number):

I think you mean when limit is t.  When limit is nil, the (null limit)
inside the `or' will catch it.

Thanks for pointing out this bug.  I'll fix it.

> | @@ -557,6 +572,11 @@ cl-print-to-string-with-limit
> |                          ((null limit) nil)
> |                          ((eq limit t) print-level)
> |                          (t (min 8 (truncate (log limit))))))
> | +         (cl-print-string-length
> | +          (cond
> | +           ((or (null limit) (zerop limit)) nil)
> | +           ((eq limit t) cl-print-string-length)
> | +           (t (max 0 (- limit 3)))))

> TIA,

> Michael.

-- 
Alan Mackenzie (Nuremberg, Germany).





  reply	other threads:[~2023-10-03  9:18 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-01 14:17 bug#65680: cl-print-to-string-with-limit erroneously imposes a maximum print-length of 50 Alan Mackenzie
2023-09-19 10:32 ` Alan Mackenzie
2023-09-21 16:16 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-09-21 16:36   ` Eli Zaretskii
2023-09-21 17:07   ` Alan Mackenzie
2023-09-21 17:51     ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-09-21 19:22       ` Drew Adams
2023-09-21 20:00         ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-09-21 18:33     ` Eli Zaretskii
     [not found]       ` <ZQ1m766tulSqvuC6@ACM>
     [not found]         ` <83msxe779i.fsf@gnu.org>
     [not found]           ` <ZQ2JVhy-e8NpCJqq@ACM>
     [not found]             ` <837coi74ia.fsf@gnu.org>
     [not found]               ` <jwva5tefif5.fsf-monnier+emacs@gnu.org>
     [not found]                 ` <ZRRGZaRf3WU9z6m_@ACM>
     [not found]                   ` <83v8btywz3.fsf@gnu.org>
2023-09-29 16:49                     ` Alan Mackenzie
2023-09-29 16:53                       ` Eli Zaretskii
2023-10-03  2:11 ` Michael Heerdegen
2023-10-03  9:18   ` Alan Mackenzie [this message]
2023-10-03 10:26   ` Alan Mackenzie
2023-10-03 23:35     ` Michael Heerdegen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZRvcS2lkPI-N_GT_@ACM \
    --to=acm@muc.de \
    --cc=65680@debbugs.gnu.org \
    --cc=michael_heerdegen@web.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).