From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Alan Mackenzie Newsgroups: gmane.emacs.bugs Subject: bug#65680: cl-print-to-string-with-limit erroneously imposes a maximum print-length of 50 Date: Tue, 3 Oct 2023 09:18:03 +0000 Message-ID: References: <87h6n8tpyz.fsf@web.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="10337"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 65680@debbugs.gnu.org To: Michael Heerdegen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Oct 03 11:19:21 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qnbYn-0002Ew-4G for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 03 Oct 2023 11:19:21 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qnbYO-00084u-Tf; Tue, 03 Oct 2023 05:18:57 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qnbYG-00083Y-Dh for bug-gnu-emacs@gnu.org; Tue, 03 Oct 2023 05:18:49 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qnbYE-0002iU-Eo for bug-gnu-emacs@gnu.org; Tue, 03 Oct 2023 05:18:48 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qnbYV-0003SJ-Fv for bug-gnu-emacs@gnu.org; Tue, 03 Oct 2023 05:19:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Alan Mackenzie Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 03 Oct 2023 09:19:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65680 X-GNU-PR-Package: emacs Original-Received: via spool by 65680-submit@debbugs.gnu.org id=B65680.169632471113177 (code B ref 65680); Tue, 03 Oct 2023 09:19:03 +0000 Original-Received: (at 65680) by debbugs.gnu.org; 3 Oct 2023 09:18:31 +0000 Original-Received: from localhost ([127.0.0.1]:38789 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qnbXz-0003QT-8s for submit@debbugs.gnu.org; Tue, 03 Oct 2023 05:18:31 -0400 Original-Received: from mail.muc.de ([193.149.48.3]:64172) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qnbXw-0003Pu-IO for 65680@debbugs.gnu.org; Tue, 03 Oct 2023 05:18:29 -0400 Original-Received: (qmail 90461 invoked by uid 3782); 3 Oct 2023 11:18:04 +0200 Original-Received: from acm.muc.de (p4fe15ffa.dip0.t-ipconnect.de [79.225.95.250]) (using STARTTLS) by colin.muc.de (tmda-ofmipd) with ESMTP; Tue, 03 Oct 2023 11:18:03 +0200 Original-Received: (qmail 4709 invoked by uid 1000); 3 Oct 2023 09:18:03 -0000 Content-Disposition: inline In-Reply-To: <87h6n8tpyz.fsf@web.de> X-Submission-Agent: TMDA/1.3.x (Ph3nix) X-Primary-Address: acm@muc.de X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:271699 Archived-At: Hello, Michael. On Tue, Oct 03, 2023 at 04:11:16 +0200, Michael Heerdegen wrote: > Hello Alan, > in 01229fe0096 "Stop truncating strings too much in > cl-print-string-with-limit" there is an error: the first `cond' > condition will error when limit is nil (`zerop' expects a number): I think you mean when limit is t. When limit is nil, the (null limit) inside the `or' will catch it. Thanks for pointing out this bug. I'll fix it. > | @@ -557,6 +572,11 @@ cl-print-to-string-with-limit > | ((null limit) nil) > | ((eq limit t) print-level) > | (t (min 8 (truncate (log limit)))))) > | + (cl-print-string-length > | + (cond > | + ((or (null limit) (zerop limit)) nil) > | + ((eq limit t) cl-print-string-length) > | + (t (max 0 (- limit 3))))) > TIA, > Michael. -- Alan Mackenzie (Nuremberg, Germany).