From: Alan Third <alan@idiocy.org>
To: Po Lu <luangruo@yahoo.com>
Cc: 56462@debbugs.gnu.org, "Daniel Martín" <mardani29@yahoo.es>
Subject: bug#56462: 29.0.50; [PATCH] Memory leak in ns_draw_relief
Date: Mon, 11 Jul 2022 09:01:07 +0100 [thread overview]
Message-ID: <YsvYw+5aulv3scjI@idiocy.org> (raw)
In-Reply-To: <878rp01kq4.fsf@yahoo.com>
On Mon, Jul 11, 2022 at 09:50:11AM +0800, Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors wrote:
> Daniel Martín <mardani29@yahoo.es> writes:
>
> > Daniel Martín via "Bug reports for GNU Emacs, the Swiss army knife of
> > text editors" <bug-gnu-emacs@gnu.org> writes:
> >
> >>>
> >>> Thanks. But I think the use of static variables there is rather ugly,
> >>> and it would be much nicer if we replicated the `x_setup_relief_color'
> >>> logic there.
> >>>
> >>> Do you want to work on that, or should I?
> >>
> >> Thanks, I can give it a try.
> >
> > Here's a patch where the static variables are now proper fields in the
> > ns_output structure. Is that what you had in mind?
>
> Yes, this would be great. Thanks.
>
> Alan might have some comments; if he doesn't, I'll install this now.
No, looks fine to me.
--
Alan Third
next prev parent reply other threads:[~2022-07-11 8:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <m1fsjaz84s.fsf.ref@yahoo.es>
2022-07-09 14:13 ` bug#56462: 29.0.50; [PATCH] Memory leak in ns_draw_relief Daniel Martín via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-07-10 2:25 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-07-10 10:37 ` Daniel Martín via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-07-10 20:52 ` Daniel Martín via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-07-11 1:50 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-07-11 8:01 ` Alan Third [this message]
2022-07-11 10:25 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-09-05 19:23 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YsvYw+5aulv3scjI@idiocy.org \
--to=alan@idiocy.org \
--cc=56462@debbugs.gnu.org \
--cc=luangruo@yahoo.com \
--cc=mardani29@yahoo.es \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).