From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Alan Third Newsgroups: gmane.emacs.bugs Subject: bug#56462: 29.0.50; [PATCH] Memory leak in ns_draw_relief Date: Mon, 11 Jul 2022 09:01:07 +0100 Message-ID: References: <87tu7p1z75.fsf@yahoo.com> <878rp01kq4.fsf@yahoo.com> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28051"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 56462@debbugs.gnu.org, Daniel =?UTF-8?Q?Mart=C3=ADn?= To: Po Lu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Jul 11 10:02:30 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oAoNB-000765-C3 for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 11 Jul 2022 10:02:29 +0200 Original-Received: from localhost ([::1]:50296 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oAoN9-0002LP-HD for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 11 Jul 2022 04:02:27 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:44526) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oAoMk-000265-6s for bug-gnu-emacs@gnu.org; Mon, 11 Jul 2022 04:02:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:44295) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oAoMj-0008UG-So for bug-gnu-emacs@gnu.org; Mon, 11 Jul 2022 04:02:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oAoMj-0006FX-Me for bug-gnu-emacs@gnu.org; Mon, 11 Jul 2022 04:02:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Alan Third Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 11 Jul 2022 08:02:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56462 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 56462-submit@debbugs.gnu.org id=B56462.165752647023956 (code B ref 56462); Mon, 11 Jul 2022 08:02:01 +0000 Original-Received: (at 56462) by debbugs.gnu.org; 11 Jul 2022 08:01:10 +0000 Original-Received: from localhost ([127.0.0.1]:38192 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oAoLt-0006EK-Rb for submit@debbugs.gnu.org; Mon, 11 Jul 2022 04:01:10 -0400 Original-Received: from outbound.soverin.net ([185.233.34.21]:42643) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oAoLo-0006Df-5X for 56462@debbugs.gnu.org; Mon, 11 Jul 2022 04:01:08 -0400 Original-Received: from smtp.soverin.net (c04smtp-lb01.int.sover.in [10.10.4.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by outbound.soverin.net (Postfix) with ESMTPS id 4LhGXn4Q09zPP; Mon, 11 Jul 2022 08:00:57 +0000 (UTC) Original-Received: from smtp.soverin.net (smtp.soverin.net [10.10.4.99]) by soverin.net DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=idiocy.org; s=soverin; t=1657526457; bh=m7Um2mBXlAVJSADaIV/MhuesxyVxGpB0csVwVy6YG+g=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=b0AoUw5OEJy/GIFIRQ4wUx2PBsCHSA91EHPLh49WS3nrHPmHI0q/zcEjkucm4h1S/ raXNaaUZ3dSD6XmtMZETRntrDE1lPxf1Mcx0RxCnaJG5iTSdQQVLhYoKSyGx1hUEUb CUTek+zNMVE9phIxsQz0ZVUAZ8yMVWa5kONZmRYVwG31OCPiB9XbjL37qWF1paqPrx dPYDZEv3GnwU+f6gnlfJqheOxuSQx4VZPKUoQLbj0qN4qGzPOe+wli16PC+wa5d5Jh YZYdMxsHKafhFt38mNimmj5EC78UDl8k5gZMET8BvB3HOZT6BfefpF9MA0/o0AqnTn LfYDKx4DiRsFA== Original-Received: from alan by faroe.holly.idiocy.org with local (Exim 4.95) (envelope-from ) id 1oAoLr-000GYS-St; Mon, 11 Jul 2022 09:01:07 +0100 Mail-Followup-To: Alan Third , Po Lu , Daniel =?UTF-8?Q?Mart=C3=ADn?= , 56462@debbugs.gnu.org Content-Disposition: inline In-Reply-To: <878rp01kq4.fsf@yahoo.com> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:236607 Archived-At: On Mon, Jul 11, 2022 at 09:50:11AM +0800, Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors wrote: > Daniel Martín writes: > > > Daniel Martín via "Bug reports for GNU Emacs, the Swiss army knife of > > text editors" writes: > > > >>> > >>> Thanks. But I think the use of static variables there is rather ugly, > >>> and it would be much nicer if we replicated the `x_setup_relief_color' > >>> logic there. > >>> > >>> Do you want to work on that, or should I? > >> > >> Thanks, I can give it a try. > > > > Here's a patch where the static variables are now proper fields in the > > ns_output structure. Is that what you had in mind? > > Yes, this would be great. Thanks. > > Alan might have some comments; if he doesn't, I'll install this now. No, looks fine to me. -- Alan Third