From: Alan Third <alan@idiocy.org>
To: Timo Taipalus <timo@taipalus.cc>
Cc: 47095@debbugs.gnu.org
Subject: bug#47095: [PATCH] Add support for image mirroring (Bug#47095)
Date: Tue, 28 Dec 2021 11:22:11 +0000 [thread overview]
Message-ID: <YcrzY297jC/MFYU8@idiocy.org> (raw)
In-Reply-To: <9d31c48598c3fc1cd6a90a1845f518cb@taipalus.cc>
On Mon, Dec 27, 2021 at 10:36:43AM +0200, Timo Taipalus wrote:
> It seems image-mode does not have capability for image mirroring, so
> here's a patch for it. Tested NS (macOS) and XRender/Cairo
> implementations. As it is, it has no effect if ImageMagick is
> enabled.
I suspect this won't work at all on windows due to the way the
transform is implemented there, but someone should probably check.
> I chose 'h' as the action key because 'm' and 'f' were reserved, and
> 'h' is easy to memorize ("horizontal").
'r' for reverse, maybe?
Is it possible to do the mirroring before the rotation instead of as
part of it? I feel like it would make the code a little clearer,
although I suspect you're doing it in the rotation to reduce the
number of calculations? Would it be possible to have both horizontal
and vertical mirroring?
--
Alan Third
next prev parent reply other threads:[~2021-12-28 11:22 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-12 10:34 bug#47095: 27.1; Feature request: mirror image display ynyaaa
2021-12-27 8:36 ` bug#47095: [PATCH] Add support for image mirroring (Bug#47095) Timo Taipalus
2021-12-28 1:01 ` bug#47095: 27.1; Feature request: mirror image display Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-12-28 9:54 ` Timo Taipalus
2021-12-28 10:07 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-12-28 11:22 ` Alan Third [this message]
2021-12-28 18:09 ` bug#47095: [External] : bug#47095: [PATCH] Add support for image mirroring (Bug#47095) Drew Adams
2021-12-29 9:10 ` Timo Taipalus
2022-01-02 14:54 ` Alan Third
2022-01-04 10:25 ` Alan Third
2022-01-05 16:14 ` Lars Ingebrigtsen
2022-01-07 17:00 ` Timo Taipalus
2022-06-24 12:45 ` bug#47095: 27.1; Feature request: mirror image display Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YcrzY297jC/MFYU8@idiocy.org \
--to=alan@idiocy.org \
--cc=47095@debbugs.gnu.org \
--cc=timo@taipalus.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).