From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Alan Third Newsgroups: gmane.emacs.bugs Subject: bug#47095: [PATCH] Add support for image mirroring (Bug#47095) Date: Tue, 28 Dec 2021 11:22:11 +0000 Message-ID: References: <86a6r8hd8q.fsf@gmail.com> <9d31c48598c3fc1cd6a90a1845f518cb@taipalus.cc> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33962"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 47095@debbugs.gnu.org To: Timo Taipalus Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Dec 28 12:23:12 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n2AZU-0008bc-5i for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 28 Dec 2021 12:23:12 +0100 Original-Received: from localhost ([::1]:52778 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n2AZS-0001xf-G5 for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 28 Dec 2021 06:23:10 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:42062) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n2AZK-0001w1-5K for bug-gnu-emacs@gnu.org; Tue, 28 Dec 2021 06:23:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:33666) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1n2AZJ-00076d-SL for bug-gnu-emacs@gnu.org; Tue, 28 Dec 2021 06:23:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1n2AZJ-0000FF-Pf for bug-gnu-emacs@gnu.org; Tue, 28 Dec 2021 06:23:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Alan Third Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 28 Dec 2021 11:23:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47095 X-GNU-PR-Package: emacs Original-Received: via spool by 47095-submit@debbugs.gnu.org id=B47095.1640690545884 (code B ref 47095); Tue, 28 Dec 2021 11:23:01 +0000 Original-Received: (at 47095) by debbugs.gnu.org; 28 Dec 2021 11:22:25 +0000 Original-Received: from localhost ([127.0.0.1]:45212 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n2AYi-0000EC-NM for submit@debbugs.gnu.org; Tue, 28 Dec 2021 06:22:24 -0500 Original-Received: from outbound.soverin.net ([116.202.126.228]:33875) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n2AYf-0000Dw-R9 for 47095@debbugs.gnu.org; Tue, 28 Dec 2021 06:22:23 -0500 Original-Received: from smtp.soverin.net (unknown [10.10.3.24]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by outbound.soverin.net (Postfix) with ESMTPS id 55660807; Tue, 28 Dec 2021 11:22:15 +0000 (UTC) Original-Received: from smtp.soverin.net (smtp.soverin.net [159.69.232.138]) by soverin.net DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=idiocy.org; s=soverin; t=1640690534; bh=NH9MzDxOt47iXj3D5mgsy2XDQuzBgPmUFHhHIYk1hGo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=n00AA9tSRJKSPeJLTM7DQTRUA9jvuE0XmfYFy554Q6EtEgNJm2zOwYmObH8uKnwE4 4rjvMzVXl616avUQGLz/JBnZWRSEX6I07DTKrGl/HHwYcG0jrJyuHiX5u65a1U6iDK KtRg9DmtSbFJRZbon3adBGmk6GZBTxUax4QHWwxOUQbEWoMnXY8v+lEGiqVHQgRPWd rdk8mCmd/sPkdEr7JAyx+A6Y6Q3p/sxB/8WA2e5XY48gsR4sP/PC8U5WjWWoCAg/bR rbeRgsMysNxLGQPGmUN1l9HRupSgaAQ4KJdv6wEs/hp+sfukPDBSwJmFLsRTr2BiI3 liBoHZ33jb/gQ== Original-Received: from alan by faroe.holly.idiocy.org with local (Exim 4.95-RC2) (envelope-from ) id 1n2AYV-0022T8-Ew; Tue, 28 Dec 2021 11:22:11 +0000 Mail-Followup-To: Alan Third , Timo Taipalus , 47095@debbugs.gnu.org Content-Disposition: inline In-Reply-To: <9d31c48598c3fc1cd6a90a1845f518cb@taipalus.cc> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:223243 Archived-At: On Mon, Dec 27, 2021 at 10:36:43AM +0200, Timo Taipalus wrote: > It seems image-mode does not have capability for image mirroring, so > here's a patch for it. Tested NS (macOS) and XRender/Cairo > implementations. As it is, it has no effect if ImageMagick is > enabled. I suspect this won't work at all on windows due to the way the transform is implemented there, but someone should probably check. > I chose 'h' as the action key because 'm' and 'f' were reserved, and > 'h' is easy to memorize ("horizontal"). 'r' for reverse, maybe? Is it possible to do the mirroring before the rotation instead of as part of it? I feel like it would make the code a little clearer, although I suspect you're doing it in the rotation to reduce the number of calculations? Would it be possible to have both horizontal and vertical mirroring? -- Alan Third