From: Alan Third <alan@idiocy.org>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: Po Lu <luangruo@yahoo.com>, 51653@debbugs.gnu.org
Subject: bug#51653: [PATCH] Fix dumping stretch glyph when drawing s->next in NS port
Date: Sun, 7 Nov 2021 23:40:22 +0000 [thread overview]
Message-ID: <YYhj5o1ZiBYr0pnu@idiocy.org> (raw)
In-Reply-To: <875yt3g0ib.fsf@gnus.org>
On Sun, Nov 07, 2021 at 09:43:24PM +0100, Lars Ingebrigtsen wrote:
> Po Lu <luangruo@yahoo.com> writes:
>
> > * src/nsterm.m (ns_draw_glyph_string): Always focus even when dumping
> > stretch glyphs in s->next.
>
> Alan, do you have any comments here?
I asked Po Lu to move the focus call out of ns_dumpglyphs_stretch and
into ns_draw_glyph_string as it's the only caller (in two places) and
it meant we didn't have to handle nested ns_focus calls further down.
I forgot to check this call had been fixed in subsequent patch sets.
So yeah, it's good.
--
Alan Third
next prev parent reply other threads:[~2021-11-07 23:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <871r3swg23.fsf.ref@yahoo.com>
2021-11-07 8:00 ` bug#51653: [PATCH] Fix dumping stretch glyph when drawing s->next in NS port Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-11-07 20:43 ` Lars Ingebrigtsen
2021-11-07 23:40 ` Alan Third [this message]
2021-11-08 0:16 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YYhj5o1ZiBYr0pnu@idiocy.org \
--to=alan@idiocy.org \
--cc=51653@debbugs.gnu.org \
--cc=larsi@gnus.org \
--cc=luangruo@yahoo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).