From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Alan Third Newsgroups: gmane.emacs.bugs Subject: bug#51653: [PATCH] Fix dumping stretch glyph when drawing s->next in NS port Date: Sun, 7 Nov 2021 23:40:22 +0000 Message-ID: References: <871r3swg23.fsf.ref@yahoo.com> <871r3swg23.fsf@yahoo.com> <875yt3g0ib.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="5242"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Po Lu , 51653@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Nov 08 00:41:15 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mjrmk-0001BY-8d for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 08 Nov 2021 00:41:14 +0100 Original-Received: from [::1] (port=35682 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mjrmj-0000cM-2G for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 07 Nov 2021 18:41:13 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:48950) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mjrmY-0000aE-Oz for bug-gnu-emacs@gnu.org; Sun, 07 Nov 2021 18:41:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:43704) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mjrmY-0001fL-HB for bug-gnu-emacs@gnu.org; Sun, 07 Nov 2021 18:41:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mjrmY-0003Q1-8g for bug-gnu-emacs@gnu.org; Sun, 07 Nov 2021 18:41:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Alan Third Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 07 Nov 2021 23:41:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51653 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 51653-submit@debbugs.gnu.org id=B51653.163632844113105 (code B ref 51653); Sun, 07 Nov 2021 23:41:02 +0000 Original-Received: (at 51653) by debbugs.gnu.org; 7 Nov 2021 23:40:41 +0000 Original-Received: from localhost ([127.0.0.1]:55250 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mjrm3-0003P9-C7 for submit@debbugs.gnu.org; Sun, 07 Nov 2021 18:40:41 -0500 Original-Received: from outbound.soverin.net ([116.202.126.228]:45259) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mjrlz-0003Oy-Ow for 51653@debbugs.gnu.org; Sun, 07 Nov 2021 18:40:29 -0500 Original-Received: from smtp.soverin.net (unknown [10.10.3.24]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by outbound.soverin.net (Postfix) with ESMTPS id D4B633E7; Sun, 7 Nov 2021 23:40:25 +0000 (UTC) Original-Received: from smtp.soverin.net (smtp.soverin.net [159.69.232.138]) by soverin.net DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=idiocy.org; s=soverin; t=1636328425; bh=xyZkDtWZVDo1YSTCrASa8M7IoO4FGkbF9teB1LuUXu4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=m2+BYIPtckZyh+oCfrAlqqSWGBoy9a82gjfE7vlIHEhTaap3yMHMyLhzduos4zCtO I0lNb/HvD0K9gQjzZ4YaEI50pfDpf3oBHEa6Ni+LK1zlCflF635WQvzAmp8F4CN39L vGZhWMMHlAPOntuZ5NaiKZW/hBSs7rIY3vciwxlA2w8/XTuoZ/4gZZX2eLYPrw6e/+ ine0NjjCkKK+hz5WNkTEKVwesBOoOEQuI68aJJwSt8orrkhN9Hu3zifcTnX9gA9JEo mnf3+1gk8aFzWKRAVDDq+M82COIoZG8EaEFNMMislGRnAmcGmYM5DB/a3mGE4w5Atm /2XdyXouJrqEw== Original-Received: from alan by faroe.holly.idiocy.org with local (Exim 4.95-RC2) (envelope-from ) id 1mjrlu-000EQq-3M; Sun, 07 Nov 2021 23:40:22 +0000 Mail-Followup-To: Alan Third , Lars Ingebrigtsen , Po Lu , 51653@debbugs.gnu.org Content-Disposition: inline In-Reply-To: <875yt3g0ib.fsf@gnus.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:219304 Archived-At: On Sun, Nov 07, 2021 at 09:43:24PM +0100, Lars Ingebrigtsen wrote: > Po Lu writes: > > > * src/nsterm.m (ns_draw_glyph_string): Always focus even when dumping > > stretch glyphs in s->next. > > Alan, do you have any comments here? I asked Po Lu to move the focus call out of ns_dumpglyphs_stretch and into ns_draw_glyph_string as it's the only caller (in two places) and it meant we didn't have to handle nested ns_focus calls further down. I forgot to check this call had been fixed in subsequent patch sets. So yeah, it's good. -- Alan Third