From: Alan Third <alan@idiocy.org>
To: tsuucat <tsuucat@icloud.com>
Cc: 50160@debbugs.gnu.org
Subject: bug#50160: 28.0.50; Wrong NSToolbarItem identifier
Date: Sun, 22 Aug 2021 21:09:35 +0100 [thread overview]
Message-ID: <YSKu/xRH8TnxyqEc@idiocy.org> (raw)
In-Reply-To: <A2CA4B55-093D-4E9D-834B-649C359B1280@icloud.com>
On Sun, Aug 22, 2021 at 11:32:05AM +0900, tsuucat via Bug reports for GNU Emacs, the Swiss army knife of text editors wrote:
> Emacs version: 28.0.50
> window system: ns
>
> EmacsToolbar now uses [img hash] as NSToolbarItem’s identifier
> (see addDisplayItemWithImage in src/nsmenu.m).
>
> This is not good because this causes conflict.
> For example, “close” icon is used as `kill-this-buffer' by default but
> isearch-tool-bar-map uses “close” icon as `isearch-cancel’.
> addDisplayItemWithImage reuses NSToolbarItem which has same
> identifier so when in isearch “close” icon on toolbar doesn’t work.
Ah, hmm... Perhaps we should append the label text to the hash or
something?
--
Alan Third
next prev parent reply other threads:[~2021-08-22 20:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-22 2:32 bug#50160: 28.0.50; Wrong NSToolbarItem identifier tsuucat via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-08-22 20:09 ` Alan Third [this message]
2021-09-09 17:33 ` tsuucat via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-09-09 20:59 ` Alan Third
2021-12-22 20:50 ` Alan Third
2022-08-22 13:54 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YSKu/xRH8TnxyqEc@idiocy.org \
--to=alan@idiocy.org \
--cc=50160@debbugs.gnu.org \
--cc=tsuucat@icloud.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).