From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Alan Third Newsgroups: gmane.emacs.bugs Subject: bug#50160: 28.0.50; Wrong NSToolbarItem identifier Date: Sun, 22 Aug 2021 21:09:35 +0100 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="5699"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 50160@debbugs.gnu.org To: tsuucat Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Aug 22 22:10:11 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mHtnG-0001H6-Lg for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 22 Aug 2021 22:10:10 +0200 Original-Received: from localhost ([::1]:50396 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mHtnF-0007gJ-In for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 22 Aug 2021 16:10:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:43194) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mHtn8-0007fw-ON for bug-gnu-emacs@gnu.org; Sun, 22 Aug 2021 16:10:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:56526) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mHtn8-00020J-BB for bug-gnu-emacs@gnu.org; Sun, 22 Aug 2021 16:10:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mHtn8-0000rX-6J for bug-gnu-emacs@gnu.org; Sun, 22 Aug 2021 16:10:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Alan Third Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 22 Aug 2021 20:10:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50160 X-GNU-PR-Package: emacs Original-Received: via spool by 50160-submit@debbugs.gnu.org id=B50160.16296629853290 (code B ref 50160); Sun, 22 Aug 2021 20:10:02 +0000 Original-Received: (at 50160) by debbugs.gnu.org; 22 Aug 2021 20:09:45 +0000 Original-Received: from localhost ([127.0.0.1]:39839 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mHtmr-0000qz-Ej for submit@debbugs.gnu.org; Sun, 22 Aug 2021 16:09:45 -0400 Original-Received: from outbound.soverin.net ([116.202.126.228]:37077) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mHtmp-0000ql-9i for 50160@debbugs.gnu.org; Sun, 22 Aug 2021 16:09:44 -0400 Original-Received: from smtp.soverin.net (unknown [10.10.3.24]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by outbound.soverin.net (Postfix) with ESMTPS id 34705148; Sun, 22 Aug 2021 20:09:37 +0000 (UTC) Original-Received: from smtp.soverin.net (smtp.soverin.net [159.69.232.138]) by soverin.net DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=idiocy.org; s=soverin; t=1629662976; bh=wLdS/vrRmMVjvngDOQKmFlLwu8hO5S37MmBlKVymFkc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=oiWh/tOyj/BAk54d6jRT7JK+XxJd18HylK5xyy8wIJWanNOit0qOQOLIdugd6xUmg x0wagiUNnkgPEuYL5qzMoIeY5DaDismnDpK/6RTYQWQT4BkiLFzeI1yAFXoGTWZjVN FT/6SLW9yqFbZWGZvsigSvDFjgiDZRQdhFkvGEQdFZt2ajrLXyIgYniBNcC0+1+jgR UYEQUCVVCzrzZ448RMB162hdr08YfUnWvu5uqMMJJJ7LxHecBfc7Vx8LK3wtnFf6kj 0dW/5x+8EurTU0QJhulpKwLHFotYEqkokKbG3KF3SDZQ/i9u/nYnOM87JSfvMBOh/5 qEUzj7+2X3/Tg== Original-Received: from alan by faroe.holly.idiocy.org with local (Exim 4.94.2) (envelope-from ) id 1mHtmh-000qhI-3S; Sun, 22 Aug 2021 21:09:35 +0100 Mail-Followup-To: Alan Third , tsuucat , 50160@debbugs.gnu.org Content-Disposition: inline In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:212437 Archived-At: On Sun, Aug 22, 2021 at 11:32:05AM +0900, tsuucat via Bug reports for GNU Emacs, the Swiss army knife of text editors wrote: > Emacs version: 28.0.50 > window system: ns > > EmacsToolbar now uses [img hash] as NSToolbarItem’s identifier > (see addDisplayItemWithImage in src/nsmenu.m). > > This is not good because this causes conflict. > For example, “close” icon is used as `kill-this-buffer' by default but > isearch-tool-bar-map uses “close” icon as `isearch-cancel’. > addDisplayItemWithImage reuses NSToolbarItem which has same > identifier so when in isearch “close” icon on toolbar doesn’t work. Ah, hmm... Perhaps we should append the label text to the hash or something? -- Alan Third