unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Alan Third <alan@idiocy.org>
To: Robert Pluim <rpluim@gmail.com>
Cc: Lars Ingebrigtsen <larsi@gnus.org>,
	49937@debbugs.gnu.org, Visuwesh <visuwesh@tutanota.com>
Subject: bug#49937: 28.0.50; feature/pgtk: tetris blocks are comparatively larger
Date: Sat, 21 Aug 2021 13:30:49 +0100	[thread overview]
Message-ID: <YSDx+QlA6aeloSZ5@idiocy.org> (raw)
In-Reply-To: <87zgtpqrhf.fsf@gmail.com>

On Tue, Aug 10, 2021 at 04:55:24PM +0200, Robert Pluim wrote:
> >>>>> On Tue, 10 Aug 2021 14:51:44 +0200, Lars Ingebrigtsen <larsi@gnus.org> said:
> 
>     Lars> Alan Third <alan@idiocy.org> writes:
>     >> They're images, ostensibly 7mm in height but it appears on X (and NS)
>     >> they're much smaller. I imagine it depends on the screen's reported
>     >> DPI since the gamegrid code appears to calculate the size using it.
> 
>     Lars> I think this is bug#47039 -- pgtk scales images correctly, which images
>     Lars> found via `find-image' are not scaled correctly on the trunk.
> 
> The images in this case are created on the fly by gamegrid.el, which
> uses 'display-mm-height', which gives the wrong answer under X:
> 
> ELISP> (display-mm-height)
> 572
> 
> In pgtk itʼs correct:
> 
> ELISP> (display-mm-height)
> 190 (#o276, #xbe)
> 
> We could change gamegrid.el to use 'display-monitor-attributes-list'
> instead, that gives the right values under both:

Sounds reasonable to me, although I wonder if we'll get a bunch of bug
reports complaining their tetris is too big for their screen now. ;)

Alternatively, should we fix display-mm-height to give the correct
value? Presumably it must be possible. I think we manage to display
SVG images at the correct size by calculating the real DPI...

(Except on macOS where the "DPI" is a magic number decided by Apple.)
-- 
Alan Third





  reply	other threads:[~2021-08-21 12:30 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-08  3:01 bug#49937: 28.0.50; feature/pgtk: tetris blocks are comparatively larger Visuwesh via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-08-09 16:12 ` Robert Pluim
2021-08-09 16:48   ` Visuwesh via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-08-09 21:45   ` Alan Third
2021-08-10 12:51     ` Lars Ingebrigtsen
2021-08-10 14:55       ` Robert Pluim
2021-08-21 12:30         ` Alan Third [this message]
2021-08-21 12:47           ` Eli Zaretskii
2021-08-22  9:14           ` Visuwesh via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-08-22 11:53         ` Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YSDx+QlA6aeloSZ5@idiocy.org \
    --to=alan@idiocy.org \
    --cc=49937@debbugs.gnu.org \
    --cc=larsi@gnus.org \
    --cc=rpluim@gmail.com \
    --cc=visuwesh@tutanota.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).