From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Alan Third Newsgroups: gmane.emacs.bugs Subject: bug#49937: 28.0.50; feature/pgtk: tetris blocks are comparatively larger Date: Sat, 21 Aug 2021 13:30:49 +0100 Message-ID: References: <874kbysiku.fsf@gmail.com> <87zgtpzcm7.fsf@gnus.org> <87zgtpqrhf.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="38104"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Lars Ingebrigtsen , 49937@debbugs.gnu.org, Visuwesh To: Robert Pluim Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Aug 21 14:32:30 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mHQAn-0009iS-1G for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 21 Aug 2021 14:32:29 +0200 Original-Received: from localhost ([::1]:52754 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mHQAl-0001AX-Kb for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 21 Aug 2021 08:32:27 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:54104) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mHQAM-0001AP-VG for bug-gnu-emacs@gnu.org; Sat, 21 Aug 2021 08:32:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:52662) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mHQAM-000367-NB for bug-gnu-emacs@gnu.org; Sat, 21 Aug 2021 08:32:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mHQAM-00006p-Hn for bug-gnu-emacs@gnu.org; Sat, 21 Aug 2021 08:32:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Alan Third Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 21 Aug 2021 12:32:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 49937 X-GNU-PR-Package: emacs Original-Received: via spool by 49937-submit@debbugs.gnu.org id=B49937.1629549064353 (code B ref 49937); Sat, 21 Aug 2021 12:32:02 +0000 Original-Received: (at 49937) by debbugs.gnu.org; 21 Aug 2021 12:31:04 +0000 Original-Received: from localhost ([127.0.0.1]:35975 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mHQ9Q-00005d-AR for submit@debbugs.gnu.org; Sat, 21 Aug 2021 08:31:04 -0400 Original-Received: from outbound.soverin.net ([116.202.126.228]:35243) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mHQ9N-00004y-Tl for 49937@debbugs.gnu.org; Sat, 21 Aug 2021 08:31:02 -0400 Original-Received: from smtp.soverin.net (unknown [10.10.3.24]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by outbound.soverin.net (Postfix) with ESMTPS id AFEC2272; Sat, 21 Aug 2021 12:30:55 +0000 (UTC) Original-Received: from smtp.soverin.net (smtp.soverin.net [159.69.232.138]) by soverin.net DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=idiocy.org; s=soverin; t=1629549054; bh=feGm5tfc1FpBOoT865eD7VMsHe/N+yvMbAzWKlxMKb0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=jqZWH+wnPCcIfpnbKpgw5+6o8MsGmYbYf3DFjI8kRyzEan7ER/gPlZAa8UMtnVT2Q B6ohO6tX3fUuNZUSB2AljcfO7eBEFXNj5kLTj5eqhWK1Yh60XcjILcU7s15L+2Sfn1 dvOkb21JGrbSJnEPtDbP5nCqbQlwthQCSpmuVsvXYtzt4RXOCVydbHz6MYdb7h39Jj BHd7hAwoat4vfIRVrhqY+Dh2GZYxEs3HTBU8lbJz1aJPwppsyg6O+G0EbZ5JIKAPgw B7E5GnzwPOuUUOP4sqIa5jyJoTPKmPlArlzxMsO8ukdf1l9q3KzY3/v7tko4gfkBlt kxXzu4xJmQQ1g== Original-Received: from alan by faroe.holly.idiocy.org with local (Exim 4.94.2) (envelope-from ) id 1mHQ9B-000jIu-C8; Sat, 21 Aug 2021 13:30:49 +0100 Mail-Followup-To: Alan Third , Robert Pluim , Lars Ingebrigtsen , 49937@debbugs.gnu.org, Visuwesh Content-Disposition: inline In-Reply-To: <87zgtpqrhf.fsf@gmail.com> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:212335 Archived-At: On Tue, Aug 10, 2021 at 04:55:24PM +0200, Robert Pluim wrote: > >>>>> On Tue, 10 Aug 2021 14:51:44 +0200, Lars Ingebrigtsen said: > > Lars> Alan Third writes: > >> They're images, ostensibly 7mm in height but it appears on X (and NS) > >> they're much smaller. I imagine it depends on the screen's reported > >> DPI since the gamegrid code appears to calculate the size using it. > > Lars> I think this is bug#47039 -- pgtk scales images correctly, which images > Lars> found via `find-image' are not scaled correctly on the trunk. > > The images in this case are created on the fly by gamegrid.el, which > uses 'display-mm-height', which gives the wrong answer under X: > > ELISP> (display-mm-height) > 572 > > In pgtk itʼs correct: > > ELISP> (display-mm-height) > 190 (#o276, #xbe) > > We could change gamegrid.el to use 'display-monitor-attributes-list' > instead, that gives the right values under both: Sounds reasonable to me, although I wonder if we'll get a bunch of bug reports complaining their tetris is too big for their screen now. ;) Alternatively, should we fix display-mm-height to give the correct value? Presumably it must be possible. I think we manage to display SVG images at the correct size by calculating the real DPI... (Except on macOS where the "DPI" is a magic number decided by Apple.) -- Alan Third