From: Alan Third <alan@idiocy.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: stefan@marxist.se, 47074@debbugs.gnu.org
Subject: bug#47074: Replace XPM icons with Unicode codepoints in customize/widgets
Date: Sun, 4 Apr 2021 12:44:00 +0100 [thread overview]
Message-ID: <YGmmgCd+8ScslnMA@breton.holly.idiocy.org> (raw)
In-Reply-To: <83wnticmc7.fsf@gnu.org>
On Sun, Apr 04, 2021 at 02:37:12PM +0300, Eli Zaretskii wrote:
> > Date: Sat, 3 Apr 2021 23:28:35 +0100
> > From: Alan Third <alan@idiocy.org>
> > Cc: Eli Zaretskii <eliz@gnu.org>, 47074-done@debbugs.gnu.org
> >
> > I've pushed a change up, so hopefully it should all Just Work now.
>
> Alan, this patch calls malloc to allocate face_font_family, but then
> calls xfree to free it. Why didn't you call xmalloc to allocate?
> that's currently the only caller of malloc in the entire image.c.
I originally used malloc, then realised every other call is to xmalloc
and thought I'd fixed them all.
This change appears to have been particularly bad, apologies to
everyone for the mess I've caused.
--
Alan Third
next prev parent reply other threads:[~2021-04-04 11:44 UTC|newest]
Thread overview: 61+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-11 16:51 bug#47074: Replace XPM icons with Unicode codepoints in customize/widgets Stefan Kangas
2021-03-11 17:01 ` Lars Ingebrigtsen
2021-03-11 17:22 ` Stefan Kangas
2021-03-11 17:38 ` Eli Zaretskii
2021-03-11 17:51 ` Stefan Kangas
2021-03-11 19:59 ` Eli Zaretskii
2021-03-11 17:28 ` Eli Zaretskii
2021-03-11 17:51 ` Stefan Kangas
2021-03-11 18:03 ` Lars Ingebrigtsen
2021-03-11 20:21 ` Eli Zaretskii
2021-03-11 20:27 ` Lars Ingebrigtsen
2021-03-12 1:38 ` Stefan Kangas
2021-03-12 1:43 ` Lars Ingebrigtsen
2021-03-12 2:24 ` Stefan Kangas
2021-03-12 2:34 ` Lars Ingebrigtsen
2021-03-12 8:12 ` Eli Zaretskii
2021-03-11 20:01 ` Eli Zaretskii
2021-03-11 23:49 ` Alan Third
2021-03-12 0:12 ` Lars Ingebrigtsen
2021-03-12 18:21 ` Alan Third
2021-03-12 7:27 ` Eli Zaretskii
2021-03-12 18:25 ` Alan Third
2021-03-12 18:37 ` Eli Zaretskii
2021-03-12 18:43 ` Alan Third
2021-03-12 19:27 ` Eli Zaretskii
2021-03-13 2:44 ` Stefan Kangas
2021-03-13 7:29 ` Eli Zaretskii
2021-03-13 7:47 ` Stefan Kangas
2021-03-13 8:37 ` Eli Zaretskii
2021-03-13 10:35 ` Stefan Kangas
2021-03-13 10:54 ` Eli Zaretskii
2021-03-13 11:51 ` Stefan Kangas
2021-03-13 16:27 ` Eli Zaretskii
2021-03-13 16:44 ` Stefan Kangas
2021-03-13 17:02 ` Eli Zaretskii
2021-03-13 20:24 ` Alan Third
2021-03-14 13:46 ` Alan Third
2021-03-14 18:44 ` Stefan Kangas
2021-03-14 18:49 ` Eli Zaretskii
2021-03-14 19:37 ` Alan Third
2021-03-14 19:52 ` Eli Zaretskii
2021-03-15 21:34 ` Alan Third
2021-03-16 3:29 ` Eli Zaretskii
2021-04-03 20:06 ` Stefan Kangas
2021-04-03 22:28 ` Alan Third
2021-04-04 9:21 ` Stefan Kangas
2021-04-04 11:37 ` Eli Zaretskii
2021-04-04 11:44 ` Alan Third [this message]
2021-04-04 11:55 ` Eli Zaretskii
2021-04-04 6:55 ` Eli Zaretskii
2021-04-04 9:21 ` Stefan Kangas
2021-04-04 11:13 ` Eli Zaretskii
2021-04-04 11:37 ` Alan Third
2021-04-04 11:48 ` Eli Zaretskii
2021-04-04 12:38 ` Eli Zaretskii
2021-04-04 13:15 ` Alan Third
2021-04-04 13:14 ` Alan Third
2021-04-04 13:22 ` Eli Zaretskii
2021-04-04 13:28 ` Alan Third
2021-04-04 13:36 ` Eli Zaretskii
2021-04-04 11:39 ` Stefan Kangas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YGmmgCd+8ScslnMA@breton.holly.idiocy.org \
--to=alan@idiocy.org \
--cc=47074@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=stefan@marxist.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).