From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Alan Third Newsgroups: gmane.emacs.bugs Subject: bug#47074: Replace XPM icons with Unicode codepoints in customize/widgets Date: Sun, 4 Apr 2021 12:44:00 +0100 Message-ID: References: <83o8flfu4l.fsf@gnu.org> <83im5tfr6t.fsf@gnu.org> <83sg4vepym.fsf@gnu.org> <83wnticmc7.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="21207"; mail-complaints-to="usenet@ciao.gmane.io" Cc: stefan@marxist.se, 47074@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Apr 04 13:45:49 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lT1CP-0005R8-0L for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 04 Apr 2021 13:45:49 +0200 Original-Received: from localhost ([::1]:40834 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lT1CN-0004H3-Ka for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 04 Apr 2021 07:45:47 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:54988) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lT1Be-0004GD-EZ for bug-gnu-emacs@gnu.org; Sun, 04 Apr 2021 07:45:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:51668) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lT1Be-0006l6-6q for bug-gnu-emacs@gnu.org; Sun, 04 Apr 2021 07:45:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lT1Be-00083p-3t for bug-gnu-emacs@gnu.org; Sun, 04 Apr 2021 07:45:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Alan Third Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 04 Apr 2021 11:45:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47074 X-GNU-PR-Package: emacs Original-Received: via spool by 47074-submit@debbugs.gnu.org id=B47074.161753665530917 (code B ref 47074); Sun, 04 Apr 2021 11:45:02 +0000 Original-Received: (at 47074) by debbugs.gnu.org; 4 Apr 2021 11:44:15 +0000 Original-Received: from localhost ([127.0.0.1]:34981 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lT1As-00082a-Fx for submit@debbugs.gnu.org; Sun, 04 Apr 2021 07:44:15 -0400 Original-Received: from outbound.soverin.net ([116.202.65.218]:35691) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lT1Aq-00082M-6R for 47074@debbugs.gnu.org; Sun, 04 Apr 2021 07:44:12 -0400 Original-Received: from smtp.soverin.net (unknown [10.10.3.28]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by outbound.soverin.net (Postfix) with ESMTPS id 46DF9600CB; Sun, 4 Apr 2021 11:44:06 +0000 (UTC) Original-Received: from smtp.soverin.net (smtp.soverin.net [159.69.232.142]) by soverin.net DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=idiocy.org; s=soverin; t=1617536645; bh=uiLi2s3zP0jloICcedYIVzpSL/DTVxaPAHSf3Agn2bQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=kFn0C2EQr7qhN4U2mXQ6D0VC9CHfkQO5tzXr063up8TCyTnHP4p4zI+JTSR2ZJkEC lleFQaHEDXTOUvutEVmuKj1p8UcIupjqYKcBdWlglY/okZdykm28oaDY0jrFsI3fYe F8EJl5Xb2mRQvtsaDI+C1XLFjQtsAh1Rnk4azVdEu8nqu2YFUrP8xkCb/FWYu1jRgu qXTTJxqvi63bExVpDRHu9hq5MIt72fzrzXSNeKtJYmcfAwnFzqhkPyAfUnm8semX+a i6Q7hSmH9/ujNs5bWFxEcCOuqWj/huDUnEwomkLV40UFCfNFVshAK7RqxGRggVsYh8 UE3n5waFUfsKQ== Original-Received: by breton.holly.idiocy.org (Postfix, from userid 501) id 2462D202B853B5; Sun, 4 Apr 2021 12:44:00 +0100 (BST) Mail-Followup-To: Alan Third , Eli Zaretskii , stefan@marxist.se, 47074@debbugs.gnu.org Content-Disposition: inline In-Reply-To: <83wnticmc7.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:203536 Archived-At: On Sun, Apr 04, 2021 at 02:37:12PM +0300, Eli Zaretskii wrote: > > Date: Sat, 3 Apr 2021 23:28:35 +0100 > > From: Alan Third > > Cc: Eli Zaretskii , 47074-done@debbugs.gnu.org > > > > I've pushed a change up, so hopefully it should all Just Work now. > > Alan, this patch calls malloc to allocate face_font_family, but then > calls xfree to free it. Why didn't you call xmalloc to allocate? > that's currently the only caller of malloc in the entire image.c. I originally used malloc, then realised every other call is to xmalloc and thought I'd fixed them all. This change appears to have been particularly bad, apologies to everyone for the mess I've caused. -- Alan Third