From: Randy Taylor <dev@rjt.dev>
To: sskostyaev@gmail.com
Cc: 61006@debbugs.gnu.org
Subject: bug#61006: 29.0.60; Wrong indentation in go-ts-mode
Date: Thu, 26 Jan 2023 02:39:46 +0000 [thread overview]
Message-ID: <Va5FJo_UMAl6YNxo7LQYGkPyksv-oEud-pBJ3fEIo5YMQzIH8KoaL8CmgYWSKmo0PzawY3G3T_xOWB7FxbDoqjc_mSmhkyEDaqgAdr72UMk=@rjt.dev> (raw)
In-Reply-To: <94c6de01accfebc10cd7a0377e0c1087fdae5086.camel@gmail.com>
On Tuesday, January 24th, 2023 at 23:06, sskostyaev@gmail.com <sskostyaev@gmail.com> wrote:
>
> Thank you!
>
> Fixed now.
Thanks for testing. Can someone install the patch to emacs-29?
>
> В Ср, 25/01/2023 в 02:46 +0000, Randy Taylor пишет:
>
> > On Tuesday, January 24th, 2023 at 21:35, Randy Taylor dev@rjt.dev
> > wrote:
> >
> > > On Sunday, January 22nd, 2023 at 05:00,
> > > sskostyaev@gmail.com sskostyaev@gmail.com wrote:
> > >
> > > > Hi. Thank you all for great work.
> > > > In go-ts-mode indentation breaks in function or method definition
> > > > if
> > > > arguments placed on separate lines like this:
> > > > `func transform( s string, ) string {`
> > > > This code should be indented like this:
> > > > `func transform( s string, ) string {`
> > >
> > > Thanks for the report. I've attached a patch that fixes this.
> > >
> > > > Also `go-ts-mode-indent-offset' should be 8 by default. In go
> > > > world there is gofmt which is a real standart for code
> > > > indentation. It would be great if emacs will provide the same
> > > > indentation out of the box.
> > >
> > > And addresses this.
> > >
> > > > There is also other issue - sometimes go-ts-mode syntax
> > > > highliting breaks when I actively use it with `lsp-mode`-
> > > > refactorings, auto formatting etc. But I can't reproduce it
> > > > with`eglot`.
> > >
> > > Seems like an `lsp-mode` problem then? I only use `eglot` and
> > > haven't noticed anything amiss.
> >
> > Addendum to my last patch: added indentation support for interfaces
> > as it was missing. Everything else is the same.
next prev parent reply other threads:[~2023-01-26 2:39 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-22 10:00 bug#61006: 29.0.60; Wrong indentation in go-ts-mode sskostyaev
2023-01-25 2:35 ` Randy Taylor
2023-01-25 2:46 ` Randy Taylor
2023-01-25 4:06 ` sskostyaev
2023-01-26 2:39 ` Randy Taylor [this message]
2023-01-26 8:30 ` Eli Zaretskii
2023-01-25 9:54 ` sskostyaev
2023-01-25 10:13 ` sskostyaev
2023-01-26 2:41 ` Randy Taylor
2023-01-26 4:43 ` Sergey Kostyaev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='Va5FJo_UMAl6YNxo7LQYGkPyksv-oEud-pBJ3fEIo5YMQzIH8KoaL8CmgYWSKmo0PzawY3G3T_xOWB7FxbDoqjc_mSmhkyEDaqgAdr72UMk=@rjt.dev' \
--to=dev@rjt.dev \
--cc=61006@debbugs.gnu.org \
--cc=sskostyaev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).